Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
yangql
googletest
Commits
265efde9
"docs/FrequentlyAskedQuestions.md" did not exist on "c3d8269e34b965db50385c1b2ec6d5089b500f6d"
Commit
265efde9
authored
Aug 14, 2018
by
Gennadiy Civil
Browse files
Comments changes, no functionality changes.
parent
3306848f
Changes
47
Hide whitespace changes
Inline
Side-by-side
Showing
20 changed files
with
29 additions
and
35 deletions
+29
-35
googlemock/include/gmock/gmock-matchers.h
googlemock/include/gmock/gmock-matchers.h
+3
-3
googlemock/include/gmock/gmock-spec-builders.h
googlemock/include/gmock/gmock-spec-builders.h
+2
-2
googlemock/include/gmock/internal/gmock-internal-utils.h
googlemock/include/gmock/internal/gmock-internal-utils.h
+1
-1
googlemock/test/gmock-actions_test.cc
googlemock/test/gmock-actions_test.cc
+1
-1
googlemock/test/gmock-spec-builders_test.cc
googlemock/test/gmock-spec-builders_test.cc
+1
-1
googlemock/test/gmock_leak_test.py
googlemock/test/gmock_leak_test.py
+0
-2
googlemock/test/gmock_output_test.py
googlemock/test/gmock_output_test.py
+0
-2
googlemock/test/gmock_test_utils.py
googlemock/test/gmock_test_utils.py
+0
-2
googletest/include/gtest/gtest-death-test.h
googletest/include/gtest/gtest-death-test.h
+1
-1
googletest/include/gtest/gtest-printers.h
googletest/include/gtest/gtest-printers.h
+1
-1
googletest/include/gtest/gtest.h
googletest/include/gtest/gtest.h
+2
-2
googletest/include/gtest/internal/gtest-linked_ptr.h
googletest/include/gtest/internal/gtest-linked_ptr.h
+1
-1
googletest/include/gtest/internal/gtest-port.h
googletest/include/gtest/internal/gtest-port.h
+5
-5
googletest/include/gtest/internal/gtest-tuple.h
googletest/include/gtest/internal/gtest-tuple.h
+1
-1
googletest/include/gtest/internal/gtest-tuple.h.pump
googletest/include/gtest/internal/gtest-tuple.h.pump
+1
-1
googletest/src/gtest-death-test.cc
googletest/src/gtest-death-test.cc
+2
-2
googletest/src/gtest-filepath.cc
googletest/src/gtest-filepath.cc
+2
-2
googletest/src/gtest-internal-inl.h
googletest/src/gtest-internal-inl.h
+1
-1
googletest/src/gtest-port.cc
googletest/src/gtest-port.cc
+3
-3
googletest/src/gtest-printers.cc
googletest/src/gtest-printers.cc
+1
-1
No files found.
googlemock/include/gmock/gmock-matchers.h
View file @
265efde9
...
@@ -73,7 +73,7 @@ namespace testing {
...
@@ -73,7 +73,7 @@ namespace testing {
// MatchResultListener is an abstract class. Its << operator can be
// MatchResultListener is an abstract class. Its << operator can be
// used by a matcher to explain why a value matches or doesn't match.
// used by a matcher to explain why a value matches or doesn't match.
//
//
//
TODO(wan@google.com)
: add method
//
FIXME
: add method
// bool InterestedInWhy(bool result) const;
// bool InterestedInWhy(bool result) const;
// to indicate whether the listener is interested in why the match
// to indicate whether the listener is interested in why the match
// result is 'result'.
// result is 'result'.
...
@@ -922,7 +922,7 @@ class TuplePrefix {
...
@@ -922,7 +922,7 @@ class TuplePrefix {
GTEST_REFERENCE_TO_CONST_
(
Value
)
value
=
get
<
N
-
1
>
(
values
);
GTEST_REFERENCE_TO_CONST_
(
Value
)
value
=
get
<
N
-
1
>
(
values
);
StringMatchResultListener
listener
;
StringMatchResultListener
listener
;
if
(
!
matcher
.
MatchAndExplain
(
value
,
&
listener
))
{
if
(
!
matcher
.
MatchAndExplain
(
value
,
&
listener
))
{
//
TODO(wan)
: include in the message the name of the parameter
//
FIXME
: include in the message the name of the parameter
// as used in MOCK_METHOD*() when possible.
// as used in MOCK_METHOD*() when possible.
*
os
<<
" Expected arg #"
<<
N
-
1
<<
": "
;
*
os
<<
" Expected arg #"
<<
N
-
1
<<
": "
;
get
<
N
-
1
>
(
matchers
).
DescribeTo
(
os
);
get
<
N
-
1
>
(
matchers
).
DescribeTo
(
os
);
...
@@ -2420,7 +2420,7 @@ class WhenDynamicCastToMatcher : public WhenDynamicCastToMatcherBase<To> {
...
@@ -2420,7 +2420,7 @@ class WhenDynamicCastToMatcher : public WhenDynamicCastToMatcherBase<To> {
template
<
typename
From
>
template
<
typename
From
>
bool
MatchAndExplain
(
From
from
,
MatchResultListener
*
listener
)
const
{
bool
MatchAndExplain
(
From
from
,
MatchResultListener
*
listener
)
const
{
//
TODO(sbenza)
: Add more detail on failures. ie did the dyn_cast fail?
//
FIXME
: Add more detail on failures. ie did the dyn_cast fail?
To
to
=
dynamic_cast
<
To
>
(
from
);
To
to
=
dynamic_cast
<
To
>
(
from
);
return
MatchPrintAndExplain
(
to
,
this
->
matcher_
,
listener
);
return
MatchPrintAndExplain
(
to
,
this
->
matcher_
,
listener
);
}
}
...
...
googlemock/include/gmock/gmock-spec-builders.h
View file @
265efde9
...
@@ -184,7 +184,7 @@ class GTEST_API_ UntypedFunctionMockerBase {
...
@@ -184,7 +184,7 @@ class GTEST_API_ UntypedFunctionMockerBase {
// this information in the global mock registry. Will be called
// this information in the global mock registry. Will be called
// whenever an EXPECT_CALL() or ON_CALL() is executed on this mock
// whenever an EXPECT_CALL() or ON_CALL() is executed on this mock
// method.
// method.
//
TODO(wan@google.com)
: rename to SetAndRegisterOwner().
//
FIXME
: rename to SetAndRegisterOwner().
void
RegisterOwner
(
const
void
*
mock_obj
)
void
RegisterOwner
(
const
void
*
mock_obj
)
GTEST_LOCK_EXCLUDED_
(
g_gmock_mutex
);
GTEST_LOCK_EXCLUDED_
(
g_gmock_mutex
);
...
@@ -1207,7 +1207,7 @@ class TypedExpectation : public ExpectationBase {
...
@@ -1207,7 +1207,7 @@ class TypedExpectation : public ExpectationBase {
mocker
->
DescribeDefaultActionTo
(
args
,
what
);
mocker
->
DescribeDefaultActionTo
(
args
,
what
);
DescribeCallCountTo
(
why
);
DescribeCallCountTo
(
why
);
//
TODO(wan@google.com)
: allow the user to control whether
//
FIXME
: allow the user to control whether
// unexpected calls should fail immediately or continue using a
// unexpected calls should fail immediately or continue using a
// flag --gmock_unexpected_calls_are_fatal.
// flag --gmock_unexpected_calls_are_fatal.
return
NULL
;
return
NULL
;
...
...
googlemock/include/gmock/internal/gmock-internal-utils.h
View file @
265efde9
...
@@ -360,7 +360,7 @@ class WithoutMatchers {
...
@@ -360,7 +360,7 @@ class WithoutMatchers {
// Internal use only: access the singleton instance of WithoutMatchers.
// Internal use only: access the singleton instance of WithoutMatchers.
GTEST_API_
WithoutMatchers
GetWithoutMatchers
();
GTEST_API_
WithoutMatchers
GetWithoutMatchers
();
//
TODO(wan@google.com)
: group all type utilities together.
//
FIXME
: group all type utilities together.
// Type traits.
// Type traits.
...
...
googlemock/test/gmock-actions_test.cc
View file @
265efde9
...
@@ -1343,7 +1343,7 @@ TEST(FunctorActionTest, UnusedArguments) {
...
@@ -1343,7 +1343,7 @@ TEST(FunctorActionTest, UnusedArguments) {
}
}
// Test that basic built-in actions work with move-only arguments.
// Test that basic built-in actions work with move-only arguments.
//
TODO(rburny)
: Currently, almost all ActionInterface-based actions will not
//
FIXME
: Currently, almost all ActionInterface-based actions will not
// work, even if they only try to use other, copyable arguments. Implement them
// work, even if they only try to use other, copyable arguments. Implement them
// if necessary (but note that DoAll cannot work on non-copyable types anyway -
// if necessary (but note that DoAll cannot work on non-copyable types anyway -
// so maybe it's better to make users use lambdas instead.
// so maybe it's better to make users use lambdas instead.
...
...
googlemock/test/gmock-spec-builders_test.cc
View file @
265efde9
...
@@ -1175,7 +1175,7 @@ TEST(UnexpectedCallTest, UnsatisifiedPrerequisites) {
...
@@ -1175,7 +1175,7 @@ TEST(UnexpectedCallTest, UnsatisifiedPrerequisites) {
TEST
(
UndefinedReturnValueTest
,
TEST
(
UndefinedReturnValueTest
,
ReturnValueIsMandatoryWhenNotDefaultConstructible
)
{
ReturnValueIsMandatoryWhenNotDefaultConstructible
)
{
MockA
a
;
MockA
a
;
//
TODO(wan@google.com)
: We should really verify the output message,
//
FIXME
: We should really verify the output message,
// but we cannot yet due to that EXPECT_DEATH only captures stderr
// but we cannot yet due to that EXPECT_DEATH only captures stderr
// while Google Mock logs to stdout.
// while Google Mock logs to stdout.
#if GTEST_HAS_EXCEPTIONS
#if GTEST_HAS_EXCEPTIONS
...
...
googlemock/test/gmock_leak_test.py
View file @
265efde9
...
@@ -31,8 +31,6 @@
...
@@ -31,8 +31,6 @@
"""Tests that leaked mock objects can be caught be Google Mock."""
"""Tests that leaked mock objects can be caught be Google Mock."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
gmock_test_utils
import
gmock_test_utils
PROGRAM_PATH
=
gmock_test_utils
.
GetTestExecutablePath
(
'gmock_leak_test_'
)
PROGRAM_PATH
=
gmock_test_utils
.
GetTestExecutablePath
(
'gmock_leak_test_'
)
...
...
googlemock/test/gmock_output_test.py
View file @
265efde9
...
@@ -39,8 +39,6 @@ gmock_output_test.py
...
@@ -39,8 +39,6 @@ gmock_output_test.py
"""
"""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
re
import
re
import
sys
import
sys
...
...
googlemock/test/gmock_test_utils.py
View file @
265efde9
...
@@ -29,8 +29,6 @@
...
@@ -29,8 +29,6 @@
"""Unit test utilities for Google C++ Mocking Framework."""
"""Unit test utilities for Google C++ Mocking Framework."""
__author__
=
'wan@google.com (Zhanyong Wan)'
import
os
import
os
import
sys
import
sys
...
...
googletest/include/gtest/gtest-death-test.h
View file @
265efde9
...
@@ -161,7 +161,7 @@ GTEST_API_ bool InDeathTestChild();
...
@@ -161,7 +161,7 @@ GTEST_API_ bool InDeathTestChild();
// is rarely a problem as people usually don't put the test binary
// is rarely a problem as people usually don't put the test binary
// directory in PATH.
// directory in PATH.
//
//
//
TODO(wan@google.com)
: make thread-safe death tests search the PATH.
//
FIXME
: make thread-safe death tests search the PATH.
// Asserts that a given statement causes the program to exit, with an
// Asserts that a given statement causes the program to exit, with an
// integer exit status that satisfies predicate, and emitting error output
// integer exit status that satisfies predicate, and emitting error output
...
...
googletest/include/gtest/gtest-printers.h
View file @
265efde9
...
@@ -826,7 +826,7 @@ void UniversalPrintArray(const T* begin, size_t len, ::std::ostream* os) {
...
@@ -826,7 +826,7 @@ void UniversalPrintArray(const T* begin, size_t len, ::std::ostream* os) {
// If the array has more than kThreshold elements, we'll have to
// If the array has more than kThreshold elements, we'll have to
// omit some details by printing only the first and the last
// omit some details by printing only the first and the last
// kChunkSize elements.
// kChunkSize elements.
//
TODO(wan@google.com)
: let the user control the threshold using a flag.
//
FIXME
: let the user control the threshold using a flag.
if
(
len
<=
kThreshold
)
{
if
(
len
<=
kThreshold
)
{
PrintRawArrayTo
(
begin
,
len
,
os
);
PrintRawArrayTo
(
begin
,
len
,
os
);
}
else
{
}
else
{
...
...
googletest/include/gtest/gtest.h
View file @
265efde9
...
@@ -315,7 +315,7 @@ class GTEST_API_ AssertionResult {
...
@@ -315,7 +315,7 @@ class GTEST_API_ AssertionResult {
const
char
*
message
()
const
{
const
char
*
message
()
const
{
return
message_
.
get
()
!=
NULL
?
message_
->
c_str
()
:
""
;
return
message_
.
get
()
!=
NULL
?
message_
->
c_str
()
:
""
;
}
}
//
TODO(vladl@google.com)
: Remove this after making sure no clients use it.
//
FIXME
: Remove this after making sure no clients use it.
// Deprecated; please use message() instead.
// Deprecated; please use message() instead.
const
char
*
failure_message
()
const
{
return
message
();
}
const
char
*
failure_message
()
const
{
return
message
();
}
...
@@ -621,7 +621,7 @@ class GTEST_API_ TestResult {
...
@@ -621,7 +621,7 @@ class GTEST_API_ TestResult {
// Adds a failure if the key is a reserved attribute of Google Test
// Adds a failure if the key is a reserved attribute of Google Test
// testcase tags. Returns true if the property is valid.
// testcase tags. Returns true if the property is valid.
//
TODO(russr)
: Validate attribute names are legal and human readable.
//
FIXME
: Validate attribute names are legal and human readable.
static
bool
ValidateTestProperty
(
const
std
::
string
&
xml_element
,
static
bool
ValidateTestProperty
(
const
std
::
string
&
xml_element
,
const
TestProperty
&
test_property
);
const
TestProperty
&
test_property
);
...
...
googletest/include/gtest/internal/gtest-linked_ptr.h
View file @
265efde9
...
@@ -60,7 +60,7 @@
...
@@ -60,7 +60,7 @@
// raw pointer (e.g. via get()) concurrently, and
// raw pointer (e.g. via get()) concurrently, and
// - it's safe to write to two linked_ptrs that point to the same
// - it's safe to write to two linked_ptrs that point to the same
// shared object concurrently.
// shared object concurrently.
//
TODO(wan@google.com)
: rename this to safe_linked_ptr to avoid
//
FIXME
: rename this to safe_linked_ptr to avoid
// confusion with normal linked_ptr.
// confusion with normal linked_ptr.
// GOOGLETEST_CM0001 DO NOT DELETE
// GOOGLETEST_CM0001 DO NOT DELETE
...
...
googletest/include/gtest/internal/gtest-port.h
View file @
265efde9
...
@@ -547,7 +547,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
...
@@ -547,7 +547,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
#ifndef GTEST_HAS_STD_WSTRING
#ifndef GTEST_HAS_STD_WSTRING
// The user didn't tell us whether ::std::wstring is available, so we need
// The user didn't tell us whether ::std::wstring is available, so we need
// to figure it out.
// to figure it out.
//
TODO(wan@google.com)
: uses autoconf to detect whether ::std::wstring
//
FIXME
: uses autoconf to detect whether ::std::wstring
// is available.
// is available.
// Cygwin 1.7 and below doesn't support ::std::wstring.
// Cygwin 1.7 and below doesn't support ::std::wstring.
...
@@ -759,7 +759,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
...
@@ -759,7 +759,7 @@ typedef struct _RTL_CRITICAL_SECTION GTEST_CRITICAL_SECTION;
// Until version 4.3.2, gcc has a bug that causes <tr1/functional>,
// Until version 4.3.2, gcc has a bug that causes <tr1/functional>,
// which is #included by <tr1/tuple>, to not compile when RTTI is
// which is #included by <tr1/tuple>, to not compile when RTTI is
// disabled. _TR1_FUNCTIONAL is the header guard for
// disabled. _TR1_FUNCTIONAL is the header guard for
// <tr1/functional>. Hence the following #define is
a hack
to prevent
// <tr1/functional>. Hence the following #define is
used
to prevent
// <tr1/functional> from being included.
// <tr1/functional> from being included.
# define _TR1_FUNCTIONAL 1
# define _TR1_FUNCTIONAL 1
# include <tr1/tuple>
# include <tr1/tuple>
...
@@ -1264,7 +1264,7 @@ class GTEST_API_ RE {
...
@@ -1264,7 +1264,7 @@ class GTEST_API_ RE {
// PartialMatch(str, re) returns true iff regular expression re
// PartialMatch(str, re) returns true iff regular expression re
// matches a substring of str (including str itself).
// matches a substring of str (including str itself).
//
//
//
TODO(wan@google.com)
: make FullMatch() and PartialMatch() work
//
FIXME
: make FullMatch() and PartialMatch() work
// when str contains NUL characters.
// when str contains NUL characters.
static
bool
FullMatch
(
const
::
std
::
string
&
str
,
const
RE
&
re
)
{
static
bool
FullMatch
(
const
::
std
::
string
&
str
,
const
RE
&
re
)
{
return
FullMatch
(
str
.
c_str
(),
re
);
return
FullMatch
(
str
.
c_str
(),
re
);
...
@@ -1291,7 +1291,7 @@ class GTEST_API_ RE {
...
@@ -1291,7 +1291,7 @@ class GTEST_API_ RE {
void
Init
(
const
char
*
regex
);
void
Init
(
const
char
*
regex
);
// We use a const char* instead of an std::string, as Google Test used to be
// We use a const char* instead of an std::string, as Google Test used to be
// used where std::string is not available.
TODO(wan@google.com)
: change to
// used where std::string is not available.
FIXME
: change to
// std::string.
// std::string.
const
char
*
pattern_
;
const
char
*
pattern_
;
bool
is_valid_
;
bool
is_valid_
;
...
@@ -2684,7 +2684,7 @@ typedef TypeWithSize<8>::Int TimeInMillis; // Represents time in milliseconds.
...
@@ -2684,7 +2684,7 @@ typedef TypeWithSize<8>::Int TimeInMillis; // Represents time in milliseconds.
// Parses 'str' for a 32-bit signed integer. If successful, writes the result
// Parses 'str' for a 32-bit signed integer. If successful, writes the result
// to *value and returns true; otherwise leaves *value unchanged and returns
// to *value and returns true; otherwise leaves *value unchanged and returns
// false.
// false.
//
TODO(chandlerc)
: Find a better way to refactor flag and environment parsing
//
FIXME
: Find a better way to refactor flag and environment parsing
// out of both gtest-port.cc and gtest.cc to avoid exporting this utility
// out of both gtest-port.cc and gtest.cc to avoid exporting this utility
// function.
// function.
bool
ParseInt32
(
const
Message
&
src_text
,
const
char
*
str
,
Int32
*
value
);
bool
ParseInt32
(
const
Message
&
src_text
,
const
char
*
str
,
Int32
*
value
);
...
...
googletest/include/gtest/internal/gtest-tuple.h
View file @
265efde9
...
@@ -43,7 +43,7 @@
...
@@ -43,7 +43,7 @@
// The compiler used in Symbian has a bug that prevents us from declaring the
// The compiler used in Symbian has a bug that prevents us from declaring the
// tuple template as a friend (it complains that tuple is redefined). This
// tuple template as a friend (it complains that tuple is redefined). This
//
hack
bypasses the bug by declaring the members that should otherwise be
// bypasses the bug by declaring the members that should otherwise be
// private as public.
// private as public.
// Sun Studio versions < 12 also have the above bug.
// Sun Studio versions < 12 also have the above bug.
#if defined(__SYMBIAN32__) || (defined(__SUNPRO_CC) && __SUNPRO_CC < 0x590)
#if defined(__SYMBIAN32__) || (defined(__SUNPRO_CC) && __SUNPRO_CC < 0x590)
...
...
googletest/include/gtest/internal/gtest-tuple.h.pump
View file @
265efde9
...
@@ -42,7 +42,7 @@ $$ This meta comment fixes auto-indentation in Emacs. }}
...
@@ -42,7 +42,7 @@ $$ This meta comment fixes auto-indentation in Emacs. }}
// The compiler used in Symbian has a bug that prevents us from declaring the
// The compiler used in Symbian has a bug that prevents us from declaring the
// tuple template as a friend (it complains that tuple is redefined). This
// tuple template as a friend (it complains that tuple is redefined). This
//
hack
bypasses the bug by declaring the members that should otherwise be
// bypasses the bug by declaring the members that should otherwise be
// private as public.
// private as public.
// Sun Studio versions < 12 also have the above bug.
// Sun Studio versions < 12 also have the above bug.
#if defined(__SYMBIAN32__) || (defined(__SUNPRO_CC) && __SUNPRO_CC < 0x590)
#if defined(__SYMBIAN32__) || (defined(__SUNPRO_CC) && __SUNPRO_CC < 0x590)
...
...
googletest/src/gtest-death-test.cc
View file @
265efde9
...
@@ -266,7 +266,7 @@ static const int kFuchsiaReadPipeFd = 3;
...
@@ -266,7 +266,7 @@ static const int kFuchsiaReadPipeFd = 3;
// statement, which is not allowed; THREW means that the test statement
// statement, which is not allowed; THREW means that the test statement
// returned control by throwing an exception. IN_PROGRESS means the test
// returned control by throwing an exception. IN_PROGRESS means the test
// has not yet concluded.
// has not yet concluded.
//
TODO(vladl@google.com)
: Unify names and possibly values for
//
FIXME
: Unify names and possibly values for
// AbortReason, DeathTestOutcome, and flag characters above.
// AbortReason, DeathTestOutcome, and flag characters above.
enum
DeathTestOutcome
{
IN_PROGRESS
,
DIED
,
LIVED
,
RETURNED
,
THREW
};
enum
DeathTestOutcome
{
IN_PROGRESS
,
DIED
,
LIVED
,
RETURNED
,
THREW
};
...
@@ -1458,7 +1458,7 @@ static int GetStatusFileDescriptor(unsigned int parent_process_id,
...
@@ -1458,7 +1458,7 @@ static int GetStatusFileDescriptor(unsigned int parent_process_id,
StreamableToString
(
parent_process_id
));
StreamableToString
(
parent_process_id
));
}
}
//
TODO(vladl@google.com)
: Replace the following check with a
//
FIXME
: Replace the following check with a
// compile-time assertion when available.
// compile-time assertion when available.
GTEST_CHECK_
(
sizeof
(
HANDLE
)
<=
sizeof
(
size_t
));
GTEST_CHECK_
(
sizeof
(
HANDLE
)
<=
sizeof
(
size_t
));
...
...
googletest/src/gtest-filepath.cc
View file @
265efde9
...
@@ -250,7 +250,7 @@ bool FilePath::DirectoryExists() const {
...
@@ -250,7 +250,7 @@ bool FilePath::DirectoryExists() const {
// root directory per disk drive.)
// root directory per disk drive.)
bool
FilePath
::
IsRootDirectory
()
const
{
bool
FilePath
::
IsRootDirectory
()
const
{
#if GTEST_OS_WINDOWS
#if GTEST_OS_WINDOWS
//
TODO(wan@google.com)
: on Windows a network share like
//
FIXME
: on Windows a network share like
// \\server\share can be a root directory, although it cannot be the
// \\server\share can be a root directory, although it cannot be the
// current directory. Handle this properly.
// current directory. Handle this properly.
return
pathname_
.
length
()
==
3
&&
IsAbsolutePath
();
return
pathname_
.
length
()
==
3
&&
IsAbsolutePath
();
...
@@ -350,7 +350,7 @@ FilePath FilePath::RemoveTrailingPathSeparator() const {
...
@@ -350,7 +350,7 @@ FilePath FilePath::RemoveTrailingPathSeparator() const {
// Removes any redundant separators that might be in the pathname.
// Removes any redundant separators that might be in the pathname.
// For example, "bar///foo" becomes "bar/foo". Does not eliminate other
// For example, "bar///foo" becomes "bar/foo". Does not eliminate other
// redundancies that might be in a pathname involving "." or "..".
// redundancies that might be in a pathname involving "." or "..".
//
TODO(wan@google.com)
: handle Windows network shares (e.g. \\server\share).
//
FIXME
: handle Windows network shares (e.g. \\server\share).
void
FilePath
::
Normalize
()
{
void
FilePath
::
Normalize
()
{
if
(
pathname_
.
c_str
()
==
NULL
)
{
if
(
pathname_
.
c_str
()
==
NULL
)
{
pathname_
=
""
;
pathname_
=
""
;
...
...
googletest/src/gtest-internal-inl.h
View file @
265efde9
...
@@ -991,7 +991,7 @@ bool ParseNaturalNumber(const ::std::string& str, Integer* number) {
...
@@ -991,7 +991,7 @@ bool ParseNaturalNumber(const ::std::string& str, Integer* number) {
const
bool
parse_success
=
*
end
==
'\0'
&&
errno
==
0
;
const
bool
parse_success
=
*
end
==
'\0'
&&
errno
==
0
;
//
TODO(vladl@google.com)
: Convert this to compile time assertion when it is
//
FIXME
: Convert this to compile time assertion when it is
// available.
// available.
GTEST_CHECK_
(
sizeof
(
Integer
)
<=
sizeof
(
parsed
));
GTEST_CHECK_
(
sizeof
(
Integer
)
<=
sizeof
(
parsed
));
...
...
googletest/src/gtest-port.cc
View file @
265efde9
...
@@ -261,7 +261,7 @@ Mutex::Mutex()
...
@@ -261,7 +261,7 @@ Mutex::Mutex()
Mutex
::~
Mutex
()
{
Mutex
::~
Mutex
()
{
// Static mutexes are leaked intentionally. It is not thread-safe to try
// Static mutexes are leaked intentionally. It is not thread-safe to try
// to clean them up.
// to clean them up.
//
TODO(yukawa)
: Switch to Slim Reader/Writer (SRW) Locks, which requires
//
FIXME
: Switch to Slim Reader/Writer (SRW) Locks, which requires
// nothing to clean it up but is available only on Vista and later.
// nothing to clean it up but is available only on Vista and later.
// https://docs.microsoft.com/en-us/windows/desktop/Sync/slim-reader-writer--srw--locks
// https://docs.microsoft.com/en-us/windows/desktop/Sync/slim-reader-writer--srw--locks
if
(
type_
==
kDynamic
)
{
if
(
type_
==
kDynamic
)
{
...
@@ -343,7 +343,7 @@ class ThreadWithParamSupport : public ThreadWithParamBase {
...
@@ -343,7 +343,7 @@ class ThreadWithParamSupport : public ThreadWithParamBase {
Notification
*
thread_can_start
)
{
Notification
*
thread_can_start
)
{
ThreadMainParam
*
param
=
new
ThreadMainParam
(
runnable
,
thread_can_start
);
ThreadMainParam
*
param
=
new
ThreadMainParam
(
runnable
,
thread_can_start
);
DWORD
thread_id
;
DWORD
thread_id
;
//
TODO(yukawa)
: Consider to use _beginthreadex instead.
//
FIXME
: Consider to use _beginthreadex instead.
HANDLE
thread_handle
=
::
CreateThread
(
HANDLE
thread_handle
=
::
CreateThread
(
NULL
,
// Default security.
NULL
,
// Default security.
0
,
// Default stack size.
0
,
// Default stack size.
...
@@ -695,7 +695,7 @@ static std::string FormatRegexSyntaxError(const char* regex, int index) {
...
@@ -695,7 +695,7 @@ static std::string FormatRegexSyntaxError(const char* regex, int index) {
// otherwise returns true.
// otherwise returns true.
bool
ValidateRegex
(
const
char
*
regex
)
{
bool
ValidateRegex
(
const
char
*
regex
)
{
if
(
regex
==
NULL
)
{
if
(
regex
==
NULL
)
{
//
TODO(wan@google.com)
: fix the source file location in the
//
FIXME
: fix the source file location in the
// assertion failures to match where the regex is used in user
// assertion failures to match where the regex is used in user
// code.
// code.
ADD_FAILURE
()
<<
"NULL is not a valid simple regular expression."
;
ADD_FAILURE
()
<<
"NULL is not a valid simple regular expression."
;
...
...
googletest/src/gtest-printers.cc
View file @
265efde9
...
@@ -89,7 +89,7 @@ void PrintBytesInObjectToImpl(const unsigned char* obj_bytes, size_t count,
...
@@ -89,7 +89,7 @@ void PrintBytesInObjectToImpl(const unsigned char* obj_bytes, size_t count,
// If the object size is bigger than kThreshold, we'll have to omit
// If the object size is bigger than kThreshold, we'll have to omit
// some details by printing only the first and the last kChunkSize
// some details by printing only the first and the last kChunkSize
// bytes.
// bytes.
//
TODO(wan)
: let the user control the threshold using a flag.
//
FIXME
: let the user control the threshold using a flag.
if
(
count
<
kThreshold
)
{
if
(
count
<
kThreshold
)
{
PrintByteSegmentInObjectTo
(
obj_bytes
,
0
,
count
,
os
);
PrintByteSegmentInObjectTo
(
obj_bytes
,
0
,
count
,
os
);
}
else
{
}
else
{
...
...
Prev
1
2
3
Next
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment