"git@developer.sourcefind.cn:yangql/googletest.git" did not exist on "33605ba45417979cff7254c1196dfee65a7275b3"
Commit 1b4cf359 authored by Ayush Joshi's avatar Ayush Joshi
Browse files

FIX #3719 -- Fix `clang` conversion warnings



We should perform an explicit type conversion to `unsigned char` before passing the
`const char` data to `IsValidXmlCharacter()` and `IsNormalizableWhitespace()` functions
in order to avoid compile time conversion warnings
Signed-off-by: default avatarAyush Joshi <ayush854032@gmail.com>
parent 6b74da47
...@@ -4079,8 +4079,9 @@ std::string XmlUnitTestResultPrinter::EscapeXml( ...@@ -4079,8 +4079,9 @@ std::string XmlUnitTestResultPrinter::EscapeXml(
m << '"'; m << '"';
break; break;
default: default:
if (IsValidXmlCharacter(ch)) { if (IsValidXmlCharacter(static_cast<unsigned char>(ch))) {
if (is_attribute && IsNormalizableWhitespace(ch)) if (is_attribute && IsNormalizableWhitespace(
static_cast<unsigned char>(ch)))
m << "&#x" << String::FormatByte(static_cast<unsigned char>(ch)) m << "&#x" << String::FormatByte(static_cast<unsigned char>(ch))
<< ";"; << ";";
else else
...@@ -4101,7 +4102,7 @@ std::string XmlUnitTestResultPrinter::RemoveInvalidXmlCharacters( ...@@ -4101,7 +4102,7 @@ std::string XmlUnitTestResultPrinter::RemoveInvalidXmlCharacters(
std::string output; std::string output;
output.reserve(str.size()); output.reserve(str.size());
for (std::string::const_iterator it = str.begin(); it != str.end(); ++it) for (std::string::const_iterator it = str.begin(); it != str.end(); ++it)
if (IsValidXmlCharacter(*it)) if (IsValidXmlCharacter(static_cast<unsigned char>(*it)))
output.push_back(*it); output.push_back(*it);
return output; return output;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment