Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
yangql
googletest
Commits
026735da
Commit
026735da
authored
Aug 20, 2017
by
Gennadiy Civil
Committed by
GitHub
Aug 20, 2017
Browse files
Proposing these changes, please review
Slightly better names and cleaner tests. Please review
parent
35737ac7
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
12 deletions
+9
-12
googlemock/test/gmock-nice-strict_test.cc
googlemock/test/gmock-nice-strict_test.cc
+9
-12
No files found.
googlemock/test/gmock-nice-strict_test.cc
View file @
026735da
...
...
@@ -62,10 +62,10 @@ using testing::internal::CaptureStdout;
using
testing
::
internal
::
GetCapturedStdout
;
#endif
//
Dummy c
lass without default constructor.
class
Dummy
{
//
C
lass without default constructor.
class
NotDefaultConstructible
{
public:
Dummy
(
int
)
{}
NotDefaultConstructible
(
int
)
{}
};
// Defines some mock classes needed by the tests.
...
...
@@ -85,7 +85,7 @@ class MockFoo : public Foo {
MOCK_METHOD0
(
DoThis
,
void
());
MOCK_METHOD1
(
DoThat
,
int
(
bool
flag
));
MOCK_METHOD0
(
Return
Something
,
Dummy
());
MOCK_METHOD0
(
Return
NonDefaultConstructible
,
NotDefaultConstructible
());
private:
GTEST_DISALLOW_COPY_AND_ASSIGN_
(
MockFoo
);
...
...
@@ -214,23 +214,20 @@ TEST(NiceMockTest, AllowsExpectedCall) {
nice_foo
.
DoThis
();
}
// Tests that an unexpected call on a nice mock which returns a non-built in
// default value throws an exception and the exception contains the name of
// the method.
// Tests that an unexpected call on a nice mock which returns a not-default-constructible
// type throws an exception and the exception contains the method's name.
TEST
(
NiceMockTest
,
ThrowsExceptionForUnknownReturnTypes
)
{
NiceMock
<
MockFoo
>
nice_foo
;
#if GTEST_HAS_EXCEPTIONS
try
{
nice_foo
.
Return
Something
();
nice_foo
.
Return
NonDefaultConstructible
();
FAIL
();
}
catch
(
const
std
::
runtime_error
&
ex
)
{
const
std
::
string
exception_msg
(
ex
.
what
());
EXPECT_
NE
(
exception_msg
.
find
(
"ReturnSomething"
),
std
::
string
::
npos
);
EXPECT_
THAT
(
ex
.
what
(),
HasSubstr
(
"ReturnNonDefaultConstructible"
)
);
}
#else
EXPECT_DEATH_IF_SUPPORTED
({
nice_foo
.
ReturnSomething
();
},
""
);
EXPECT_DEATH_IF_SUPPORTED
({
nice_foo
.
ReturnNonDefaultConstructible
();
},
""
);
#endif
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment