CONTRIBUTING.md 5.55 KB
Newer Older
1
2
3
4
# How to become a contributor and submit your own code

## Contributor License Agreements

misterg's avatar
misterg committed
5
6
We'd love to accept your patches! Before we can take them, we have to jump a
couple of legal hurdles.
7
8
9
10

Please fill out either the individual or corporate Contributor License Agreement
(CLA).

misterg's avatar
misterg committed
11
*   If you are an individual writing original source code and you're sure you
12
13
    own the intellectual property, then you'll need to sign an
    [individual CLA](https://developers.google.com/open-source/cla/individual).
misterg's avatar
misterg committed
14
*   If you work for a company that wants to allow you to contribute your work,
15
16
17
18
19
20
21
    then you'll need to sign a
    [corporate CLA](https://developers.google.com/open-source/cla/corporate).

Follow either of the two links above to access the appropriate CLA and
instructions for how to sign and return it. Once we receive it, we'll be able to
accept your pull requests.

Gennadiy Civil's avatar
Gennadiy Civil committed
22
23
## Are you a Googler?

Abseil Team's avatar
Abseil Team committed
24
25
If you are a Googler, please make an attempt to submit an internal contribution
rather than a GitHub Pull Request. If you are not able to submit internally, a
misterg's avatar
misterg committed
26
PR is acceptable as an alternative.
Gennadiy Civil's avatar
Gennadiy Civil committed
27

28
29
## Contributing A Patch

misterg's avatar
misterg committed
30
1.  Submit an issue describing your proposed change to the
31
    [issue tracker](https://github.com/google/googletest/issues).
32
2.  Please don't mix more than one logical change per submittal, because it
misterg's avatar
misterg committed
33
34
    makes the history hard to follow. If you want to make a change that doesn't
    have a corresponding issue in the issue tracker, please create one.
35
3.  Also, coordinate with team members that are listed on the issue in question.
misterg's avatar
misterg committed
36
37
    This ensures that work isn't being duplicated and communicating your plan
    early also generally leads to better patches.
38
4.  If your proposed change is accepted, and you haven't already done so, sign a
39
40
    Contributor License Agreement
    ([see details above](#contributor-license-agreements)).
41
42
5.  Fork the desired repo, develop and test your code changes.
6.  Ensure that your code adheres to the existing style in the sample to which
misterg's avatar
misterg committed
43
    you are contributing.
44
45
7.  Ensure that your code has an appropriate set of unit tests which all pass.
8.  Submit a pull request.
misterg's avatar
misterg committed
46
47

## The Google Test and Google Mock Communities
48
49

The Google Test community exists primarily through the
misterg's avatar
misterg committed
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
[discussion group](http://groups.google.com/group/googletestframework) and the
GitHub repository. Likewise, the Google Mock community exists primarily through
their own [discussion group](http://groups.google.com/group/googlemock). You are
definitely encouraged to contribute to the discussion and you can also help us
to keep the effectiveness of the group high by following and promoting the
guidelines listed here.

### Please Be Friendly

Showing courtesy and respect to others is a vital part of the Google culture,
and we strongly encourage everyone participating in Google Test development to
join us in accepting nothing less. Of course, being courteous is not the same as
failing to constructively disagree with each other, but it does mean that we
should be respectful of each other when enumerating the 42 technical reasons
that a particular proposal may not be the best choice. There's never a reason to
be antagonistic or dismissive toward anyone who is sincerely trying to
66
67
contribute to a discussion.

misterg's avatar
misterg committed
68
69
70
Sure, C++ testing is serious business and all that, but it's also a lot of fun.
Let's keep it that way. Let's strive to be one of the friendliest communities in
all of open source.
71

misterg's avatar
misterg committed
72
73
As always, discuss Google Test in the official GoogleTest discussion group. You
don't have to actually submit code in order to sign up. Your participation
74
75
itself is a valuable contribution.

76
77
## Style

misterg's avatar
misterg committed
78
79
80
81
82
To keep the source consistent, readable, diffable and easy to merge, we use a
fairly rigid coding style, as defined by the
[google-styleguide](https://github.com/google/styleguide) project. All patches
will be expected to conform to the style outlined
[here](https://google.github.io/styleguide/cppguide.html). Use
83
84
[.clang-format](https://github.com/google/googletest/blob/main/.clang-format) to
check your formatting.
85

misterg's avatar
misterg committed
86
## Requirements for Contributors
87

misterg's avatar
misterg committed
88
89
If you plan to contribute a patch, you need to build Google Test, Google Mock,
and their own tests from a git checkout, which has further requirements:
90

Tom Hughes's avatar
Tom Hughes committed
91
*   [Python](https://www.python.org/) v3.6 or newer (for running some of the
misterg's avatar
misterg committed
92
    tests and re-generating certain source files from templates)
Chuck Atkins's avatar
Chuck Atkins committed
93
*   [CMake](https://cmake.org/) v2.8.12 or newer
94

95
## Developing Google Test and Google Mock
96

97
This section discusses how to make your own changes to the Google Test project.
98

99
### Testing Google Test and Google Mock Themselves
100
101

To make sure your changes work as intended and don't break existing
102
103
functionality, you'll want to compile and run Google Test and GoogleMock's own
tests. For that you can use CMake:
104
105
106

    mkdir mybuild
    cd mybuild
107
108
109
110
111
112
113
    cmake -Dgtest_build_tests=ON -Dgmock_build_tests=ON ${GTEST_REPO_DIR}

To choose between building only Google Test or Google Mock, you may modify your
cmake command to be one of each

    cmake -Dgtest_build_tests=ON ${GTEST_DIR} # sets up Google Test tests
    cmake -Dgmock_build_tests=ON ${GMOCK_DIR} # sets up Google Mock tests
114

misterg's avatar
misterg committed
115
116
117
118
Make sure you have Python installed, as some of Google Test's tests are written
in Python. If the cmake command complains about not being able to find Python
(`Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)`), try telling it
explicitly where your Python executable can be found:
119

120
121
    cmake -DPYTHON_EXECUTABLE=path/to/python ...

122
123
Next, you can build Google Test and / or Google Mock and all desired tests. On
\*nix, this is usually done by
124
125

    make
126

127
To run the tests, do
128
129
130
131

    make test

All tests should pass.