Merge remote-tracking branch 'upstream/master'

platforms/reference/include/ReferenceProperDihedralBond.h

@@ -27,7 +27,7 @@
 
 #include "ReferenceBondIxn.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class OPENMM_EXPORT ReferenceProperDihedralBond : public ReferenceBondIxn {
 
@@ -41,7 +41,7 @@ class OPENMM_EXPORT ReferenceProperDihedralBond : public ReferenceBondIxn {
       
          --------------------------------------------------------------------------------------- */
 
-       ReferenceProperDihedralBond( );
+       ReferenceProperDihedralBond();
 
       /**---------------------------------------------------------------------------------------
       
@@ -49,7 +49,7 @@ class OPENMM_EXPORT ReferenceProperDihedralBond : public ReferenceBondIxn {
       
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceProperDihedralBond( );
+       ~ReferenceProperDihedralBond();
 
       /**---------------------------------------------------------------------------------------
       
@@ -65,12 +65,12 @@ class OPENMM_EXPORT ReferenceProperDihedralBond : public ReferenceBondIxn {
       
          --------------------------------------------------------------------------------------- */
       
-      void calculateBondIxn( int* atomIndices, std::vector<OpenMM::RealVec>& atomCoordinates,
+      void calculateBondIxn(int* atomIndices, std::vector<OpenMM::RealVec>& atomCoordinates,
                             RealOpenMM* parameters, std::vector<OpenMM::RealVec>& forces,
-                            RealOpenMM* totalEnergy ) const;
+                            RealOpenMM* totalEnergy) const;
 
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceProperDihedralBond_H__

platforms/reference/include/ReferenceRbDihedralBond.h

@@ -27,7 +27,7 @@
 
 #include "ReferenceBondIxn.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class OPENMM_EXPORT ReferenceRbDihedralBond : public ReferenceBondIxn {
 
@@ -41,7 +41,7 @@ class OPENMM_EXPORT ReferenceRbDihedralBond : public ReferenceBondIxn {
       
          --------------------------------------------------------------------------------------- */
 
-       ReferenceRbDihedralBond( );
+       ReferenceRbDihedralBond();
 
       /**---------------------------------------------------------------------------------------
       
@@ -49,7 +49,7 @@ class OPENMM_EXPORT ReferenceRbDihedralBond : public ReferenceBondIxn {
       
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceRbDihedralBond( );
+       ~ReferenceRbDihedralBond();
 
       /**---------------------------------------------------------------------------------------
       
@@ -63,12 +63,12 @@ class OPENMM_EXPORT ReferenceRbDihedralBond : public ReferenceBondIxn {
             
          --------------------------------------------------------------------------------------- */
       
-      void calculateBondIxn( int* atomIndices, std::vector<OpenMM::RealVec>& atomCoordinates,
+      void calculateBondIxn(int* atomIndices, std::vector<OpenMM::RealVec>& atomCoordinates,
                             RealOpenMM* parameters, std::vector<OpenMM::RealVec>& forces,
-                            RealOpenMM* totalEnergy ) const;
+                            RealOpenMM* totalEnergy) const;
 
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceRbDihedralBond_H__

platforms/reference/include/ReferenceStochasticDynamics.h

@@ -28,7 +28,7 @@
 #include "ReferenceDynamics.h"
 #include "openmm/internal/windowsExport.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
 
@@ -51,7 +51,7 @@ class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
 
-       ReferenceStochasticDynamics( int numberOfAtoms, RealOpenMM deltaT, RealOpenMM tau, RealOpenMM temperature );
+       ReferenceStochasticDynamics(int numberOfAtoms, RealOpenMM deltaT, RealOpenMM tau, RealOpenMM temperature);
 
       /**---------------------------------------------------------------------------------------
       
@@ -59,7 +59,7 @@ class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceStochasticDynamics( );
+       ~ReferenceStochasticDynamics();
 
       /**---------------------------------------------------------------------------------------
       
@@ -69,7 +69,7 @@ class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
       
-      RealOpenMM getTau( void ) const;
+      RealOpenMM getTau() const;
       
       /**---------------------------------------------------------------------------------------
       
@@ -100,8 +100,8 @@ class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
       
-      virtual void updatePart1( int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
-                       std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& inverseMasses, std::vector<OpenMM::RealVec>& xPrime );
+      virtual void updatePart1(int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
+                       std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& inverseMasses, std::vector<OpenMM::RealVec>& xPrime);
       
       /**---------------------------------------------------------------------------------------
       
@@ -115,11 +115,11 @@ class OPENMM_EXPORT ReferenceStochasticDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
       
-      virtual void updatePart2( int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
-                       std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& inverseMasses, std::vector<OpenMM::RealVec>& xPrime );
+      virtual void updatePart2(int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
+                       std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& inverseMasses, std::vector<OpenMM::RealVec>& xPrime);
       
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceStochasticDynamics_H__

platforms/reference/include/ReferenceVariableStochasticDynamics.h

@@ -27,7 +27,7 @@
 
 #include "ReferenceDynamics.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
@@ -50,7 +50,7 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-       ReferenceVariableStochasticDynamics( int numberOfAtoms, RealOpenMM tau, RealOpenMM temperature, RealOpenMM accuracy );
+       ReferenceVariableStochasticDynamics(int numberOfAtoms, RealOpenMM tau, RealOpenMM temperature, RealOpenMM accuracy);
 
       /**---------------------------------------------------------------------------------------
 
@@ -58,7 +58,7 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceVariableStochasticDynamics( );
+       ~ReferenceVariableStochasticDynamics();
 
       /**---------------------------------------------------------------------------------------
 
@@ -68,7 +68,7 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      RealOpenMM getTau( void ) const;
+      RealOpenMM getTau() const;
       
       /**---------------------------------------------------------------------------------------
 
@@ -78,7 +78,7 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      RealOpenMM getAccuracy( void ) const;
+      RealOpenMM getAccuracy() const;
 
       /**---------------------------------------------------------------------------------------
 
@@ -86,7 +86,7 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      void setAccuracy( RealOpenMM accuracy );
+      void setAccuracy(RealOpenMM accuracy);
 
       /**---------------------------------------------------------------------------------------
 
@@ -120,9 +120,9 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      void updatePart1( int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
+      void updatePart1(int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
                        std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& masses, std::vector<RealOpenMM>& inverseMasses,
-                       std::vector<OpenMM::RealVec>& xPrime, RealOpenMM maxStepSize );
+                       std::vector<OpenMM::RealVec>& xPrime, RealOpenMM maxStepSize);
 
       /**---------------------------------------------------------------------------------------
 
@@ -136,12 +136,12 @@ class ReferenceVariableStochasticDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      void updatePart2( int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
+      void updatePart2(int numberOfAtoms, std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& velocities,
                        std::vector<OpenMM::RealVec>& forces, std::vector<RealOpenMM>& inverseMasses,
-                       std::vector<OpenMM::RealVec>& xPrime );
+                       std::vector<OpenMM::RealVec>& xPrime);
       
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceVariableStochasticDynamics_H__

platforms/reference/include/ReferenceVariableVerletDynamics.h

@@ -27,7 +27,7 @@
 
 #include "ReferenceDynamics.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
@@ -48,7 +48,7 @@ class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-       ReferenceVariableVerletDynamics( int numberOfAtoms, RealOpenMM accuracy );
+       ReferenceVariableVerletDynamics(int numberOfAtoms, RealOpenMM accuracy);
 
       /**---------------------------------------------------------------------------------------
 
@@ -56,7 +56,7 @@ class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceVariableVerletDynamics( );
+       ~ReferenceVariableVerletDynamics();
 
       /**---------------------------------------------------------------------------------------
 
@@ -66,7 +66,7 @@ class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      RealOpenMM getAccuracy( void ) const;
+      RealOpenMM getAccuracy() const;
 
       /**---------------------------------------------------------------------------------------
 
@@ -74,7 +74,7 @@ class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
          --------------------------------------------------------------------------------------- */
 
-      void setAccuracy( RealOpenMM accuracy );
+      void setAccuracy(RealOpenMM accuracy);
 
       /**---------------------------------------------------------------------------------------
 
@@ -95,6 +95,6 @@ class ReferenceVariableVerletDynamics : public ReferenceDynamics {
 
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceVariableVerletDynamics_H__

platforms/reference/include/ReferenceVerletDynamics.h

@@ -27,7 +27,7 @@
 
 #include "ReferenceDynamics.h"
 
-// ---------------------------------------------------------------------------------------
+namespace OpenMM {
 
 class ReferenceVerletDynamics : public ReferenceDynamics {
 
@@ -49,7 +49,7 @@ class ReferenceVerletDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
 
-       ReferenceVerletDynamics( int numberOfAtoms, RealOpenMM deltaT );
+       ReferenceVerletDynamics(int numberOfAtoms, RealOpenMM deltaT);
 
       /**---------------------------------------------------------------------------------------
       
@@ -57,7 +57,7 @@ class ReferenceVerletDynamics : public ReferenceDynamics {
       
          --------------------------------------------------------------------------------------- */
 
-       ~ReferenceVerletDynamics( );
+       ~ReferenceVerletDynamics();
 
       /**---------------------------------------------------------------------------------------
       
@@ -77,6 +77,6 @@ class ReferenceVerletDynamics : public ReferenceDynamics {
       
 };
 
-// ---------------------------------------------------------------------------------------
+} // namespace OpenMM
 
 #endif // __ReferenceVerletDynamics_H__

platforms/reference/include/ReferenceVirtualSites.h

@@ -36,6 +36,8 @@
 #include "RealVec.h"
 #include <vector>
 
+namespace OpenMM {
+
 class OPENMM_EXPORT ReferenceVirtualSites {
 public:
     /**
@@ -48,4 +50,6 @@ public:
     static void distributeForces(const OpenMM::System& system, const std::vector<OpenMM::RealVec>& atomCoordinates, std::vector<OpenMM::RealVec>& forces);
 };
 
+} // namespace OpenMM
+
 #endif // __ReferenceVirtualSites_H__

platforms/reference/include/SimTKOpenMMCommon.h

-
-/* Portions copyright (c) 2006 Stanford University and Simbios.
- * Contributors: Pande Group
- *
- * Permission is hereby granted, free of charge, to any person obtaining
- * a copy of this software and associated documentation files (the
- * "Software"), to deal in the Software without restriction, including
- * without limitation the rights to use, copy, modify, merge, publish,
- * distribute, sublicense, and/or sell copies of the Software, and to
- * permit persons to whom the Software is furnished to do so, subject
- * to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included
- * in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
- * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
- * IN NO EVENT SHALL THE AUTHORS, CONTRIBUTORS OR COPYRIGHT HOLDERS BE
- * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
- * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
- * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
- */
-
-#ifndef __SimTKOpenMMCommon_H__
-#define __SimTKOpenMMCommon_H__
-
-// include file containing entries commonly used
-
-// STL includes
-
-#include <vector>
-#include <string>
-
-// ---------------------------------------------------------------------------------------
-
-#include "RealVec.h"
-
-// ---------------------------------------------------------------------------------------
-
-typedef std::vector<RealOpenMM> RealOpenMMVector;
-typedef RealOpenMMVector::iterator RealOpenMMVectorI;
-typedef RealOpenMMVector::const_iterator RealOpenMMVectorCI;
-
-// ---------------------------------------------------------------------------------------
-
-class SimTKOpenMMCommon {
-
-   public:
-
-      static const std::string NotSet;
-      static const RealOpenMM BigCutoffValue;
-      static const std::string Comment;
-      static const std::string Tab;
-      static const std::string YesU;
-      static const std::string YesUl;
-      static const std::string YesL;
-
-      // subroutine returns
-
-      static const int DefaultReturn;
-      static const int ErrorReturn;
-};
-
-#endif // __SimTKOpenMMCommon_H__

platforms/reference/include/SimTKOpenMMUtilities.h

@@ -27,12 +27,14 @@
 
 // class of shared, static utility methods
 
-#include "SimTKOpenMMCommon.h" 
+#include "RealVec.h"
 #include "sfmt/SFMT.h"
 #include "openmm/internal/windowsExport.h"
 
 #include <string>
 
+namespace OpenMM {
+
 /**---------------------------------------------------------------------------------------
 
    Class of static methods to be shared
@@ -54,8 +56,8 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
 
       // dummy constructor/destructor
 
-       SimTKOpenMMUtilities(){};
-      ~SimTKOpenMMUtilities(){};
+       SimTKOpenMMUtilities() {};
+      ~SimTKOpenMMUtilities() {};
       
       /**---------------------------------------------------------------------------------------
       
@@ -73,9 +75,9 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static RealOpenMM* allocateOneDRealOpenMMArray( int iSize, RealOpenMM* array1D, int initialize,
+      static RealOpenMM* allocateOneDRealOpenMMArray(int iSize, RealOpenMM* array1D, int initialize,
                                                       RealOpenMM initialValue,
-                                                      const std::string& idString = std::string( "1DArray" ) );
+                                                      const std::string& idString = std::string("1DArray"));
       
       /**---------------------------------------------------------------------------------------
       
@@ -94,10 +96,10 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static RealOpenMM** allocateTwoDRealOpenMMArray( int iSize, int jSize,
+      static RealOpenMM** allocateTwoDRealOpenMMArray(int iSize, int jSize,
                                                        RealOpenMM** array2D, int initialize,
                                                        RealOpenMM initialValue,
-                                                       const std::string& idString = std::string( "2DArray" ) );
+                                                       const std::string& idString = std::string("2DArray"));
       
       /* ---------------------------------------------------------------------------------------
       
@@ -110,8 +112,8 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static void freeOneDRealOpenMMArray( RealOpenMM* array1D,
-                                          const std::string& idString = std::string( "1DArray" ) );
+      static void freeOneDRealOpenMMArray(RealOpenMM* array1D,
+                                          const std::string& idString = std::string("1DArray"));
       
       /* ---------------------------------------------------------------------------------------
       
@@ -124,8 +126,8 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static void freeTwoDRealOpenMMArray( RealOpenMM** array2D,
-                                          const std::string& idString = std::string( "2DArray" ) );
+      static void freeTwoDRealOpenMMArray(RealOpenMM** array2D,
+                                          const std::string& idString = std::string("2DArray"));
       
       /**---------------------------------------------------------------------------------------
       
@@ -140,8 +142,8 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static void initialize2DRealOpenMMArray( int iSize, int jSize,
-                                              RealOpenMM** array2D, RealOpenMM initialValue );
+      static void initialize2DRealOpenMMArray(int iSize, int jSize,
+                                              RealOpenMM** array2D, RealOpenMM initialValue);
 
       /**---------------------------------------------------------------------------------------
       
@@ -157,7 +159,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static void crossProductVector3( RealOpenMM* vectorX, RealOpenMM* vectorY, RealOpenMM* vectorZ );
+      static void crossProductVector3(RealOpenMM* vectorX, RealOpenMM* vectorY, RealOpenMM* vectorZ);
       
       /**---------------------------------------------------------------------------------------
       
@@ -167,7 +169,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static RealOpenMM getNormallyDistributedRandomNumber( void );
+      static RealOpenMM getNormallyDistributedRandomNumber();
       
       /**---------------------------------------------------------------------------------------
       
@@ -177,7 +179,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static RealOpenMM getUniformlyDistributedRandomNumber( void );
+      static RealOpenMM getUniformlyDistributedRandomNumber();
 
       /**---------------------------------------------------------------------------------------
       
@@ -187,7 +189,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static uint32_t getRandomNumberSeed( void );
+      static uint32_t getRandomNumberSeed();
       
       /**---------------------------------------------------------------------------------------
       
@@ -197,7 +199,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
       
          --------------------------------------------------------------------------------------- */
       
-      static void setRandomNumberSeed( uint32_t seed );
+      static void setRandomNumberSeed(uint32_t seed);
       
       /**---------------------------------------------------------------------------------------
       
@@ -219,7 +221,7 @@ class OPENMM_EXPORT SimTKOpenMMUtilities {
 
       static void loadCheckpoint(std::istream& stream);
 };
-   
-// ---------------------------------------------------------------------------------------
+
+} // namespace OpenMM
 
 #endif // __SimTKOpenMMUtilities_H__

platforms/reference/include/fftpack.h

@@ -14,14 +14,13 @@
 * drop a line to lindahl@cbr.su.se and let me know about it!
 */
 
-#include "SimTKOpenMMCommon.h"
-
 #ifndef _FFTPACK_H_
 #define _FFTPACK_H_
 
 
 #include <stdio.h>
 
+#include "RealVec.h"
 #include "openmm/internal/windowsExport.h"
 
 #ifdef __cplusplus

platforms/reference/src/ReferenceKernelFactory.cpp

@@ -100,5 +100,5 @@ KernelImpl* ReferenceKernelFactory::createKernelImpl(std::string name, const Pla
         return new ReferenceApplyMonteCarloBarostatKernel(name, platform);
     if (name == RemoveCMMotionKernel::Name())
         return new ReferenceRemoveCMMotionKernel(name, platform, data);
-    throw OpenMMException( (std::string("Tried to create kernel with illegal kernel name '") + name + "'").c_str() );
+    throw OpenMMException((std::string("Tried to create kernel with illegal kernel name '") + name + "'").c_str());
 }