Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
tsoc
openmm
Commits
ac6f8942
Commit
ac6f8942
authored
Mar 31, 2020
by
peastman
Browse files
Patches can define virtual sites
parent
a8bc6f65
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
0 deletions
+19
-0
wrappers/python/simtk/openmm/app/forcefield.py
wrappers/python/simtk/openmm/app/forcefield.py
+14
-0
wrappers/python/tests/TestPatches.py
wrappers/python/tests/TestPatches.py
+5
-0
No files found.
wrappers/python/simtk/openmm/app/forcefield.py
View file @
ac6f8942
...
@@ -358,6 +358,9 @@ class ForceField(object):
...
@@ -358,6 +358,9 @@ class ForceField(object):
for
bond
in
patch
.
findall
(
'RemoveExternalBond'
):
for
bond
in
patch
.
findall
(
'RemoveExternalBond'
):
atom
=
ForceField
.
_PatchAtomData
(
bond
.
attrib
[
'atomName'
])
atom
=
ForceField
.
_PatchAtomData
(
bond
.
attrib
[
'atomName'
])
patchData
.
deletedExternalBonds
.
append
(
atom
)
patchData
.
deletedExternalBonds
.
append
(
atom
)
atomIndices
=
dict
((
atom
.
name
,
i
)
for
i
,
atom
in
enumerate
(
patchData
.
addedAtoms
[
atomDescription
.
residue
]
+
patchData
.
changedAtoms
[
atomDescription
.
residue
]))
for
site
in
patch
.
findall
(
'VirtualSite'
):
patchData
.
virtualSites
[
atomDescription
.
residue
].
append
(
ForceField
.
_VirtualSiteData
(
site
,
atomIndices
))
for
residue
in
patch
.
findall
(
'ApplyToResidue'
):
for
residue
in
patch
.
findall
(
'ApplyToResidue'
):
name
=
residue
.
attrib
[
'name'
]
name
=
residue
.
attrib
[
'name'
]
if
':'
in
name
:
if
':'
in
name
:
...
@@ -740,6 +743,7 @@ class ForceField(object):
...
@@ -740,6 +743,7 @@ class ForceField(object):
self
.
addedExternalBonds
=
[]
self
.
addedExternalBonds
=
[]
self
.
deletedExternalBonds
=
[]
self
.
deletedExternalBonds
=
[]
self
.
allAtomNames
=
set
()
self
.
allAtomNames
=
set
()
self
.
virtualSites
=
[[]
for
i
in
range
(
numResidues
)]
def
createPatchedTemplates
(
self
,
templates
):
def
createPatchedTemplates
(
self
,
templates
):
"""Apply this patch to a set of templates, creating new modified ones."""
"""Apply this patch to a set of templates, creating new modified ones."""
...
@@ -801,6 +805,16 @@ class ForceField(object):
...
@@ -801,6 +805,16 @@ class ForceField(object):
newTemplate
.
addExternalBondByName
(
atom2
.
name
)
newTemplate
.
addExternalBondByName
(
atom2
.
name
)
for
atom
in
self
.
addedExternalBonds
:
for
atom
in
self
.
addedExternalBonds
:
newTemplate
.
addExternalBondByName
(
atom
.
name
)
newTemplate
.
addExternalBondByName
(
atom
.
name
)
# Add new virtual sites.
indexMap
=
dict
((
i
,
newAtomIndex
[
atom
.
name
])
for
i
,
atom
in
enumerate
(
self
.
addedAtoms
[
index
]
+
self
.
changedAtoms
[
index
]))
for
site
in
self
.
virtualSites
[
index
]:
newSite
=
deepcopy
(
site
)
newSite
.
index
=
indexMap
[
site
.
index
]
newSite
.
atoms
=
[
indexMap
[
i
]
for
i
in
site
.
atoms
]
newTemplate
.
virtualSites
=
[
site
for
site
in
newTemplate
.
virtualSites
if
site
.
index
!=
newSite
.
index
]
newTemplate
.
virtualSites
.
append
(
newSite
)
return
newTemplates
return
newTemplates
class
_PatchAtomData
(
object
):
class
_PatchAtomData
(
object
):
...
...
wrappers/python/tests/TestPatches.py
View file @
ac6f8942
...
@@ -32,6 +32,7 @@ class TestPatches(unittest.TestCase):
...
@@ -32,6 +32,7 @@ class TestPatches(unittest.TestCase):
<AddExternalBond atomName="A"/>
<AddExternalBond atomName="A"/>
<RemoveExternalBond atomName="C"/>
<RemoveExternalBond atomName="C"/>
<ApplyToResidue name="RES"/>
<ApplyToResidue name="RES"/>
<VirtualSite type="average2" siteName="A" atomName1="B" atomName2="B" weight1="0.8" weight2="0.2"/>
</Patch>
</Patch>
</Patches>
</Patches>
</ForceField>"""
</ForceField>"""
...
@@ -47,6 +48,7 @@ class TestPatches(unittest.TestCase):
...
@@ -47,6 +48,7 @@ class TestPatches(unittest.TestCase):
self
.
assertEqual
(
1
,
len
(
patch
.
deletedBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
deletedBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
addedExternalBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
addedExternalBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
deletedExternalBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
deletedExternalBonds
))
self
.
assertEqual
(
1
,
len
(
patch
.
virtualSites
))
self
.
assertEqual
(
1
,
len
(
ff
.
_templatePatches
))
self
.
assertEqual
(
1
,
len
(
ff
.
_templatePatches
))
self
.
assertEqual
(
1
,
len
(
ff
.
_templatePatches
[
'RES'
]))
self
.
assertEqual
(
1
,
len
(
ff
.
_templatePatches
[
'RES'
]))
self
.
assertEqual
(
'A'
,
patch
.
addedAtoms
[
0
][
0
].
name
)
self
.
assertEqual
(
'A'
,
patch
.
addedAtoms
[
0
][
0
].
name
)
...
@@ -67,6 +69,9 @@ class TestPatches(unittest.TestCase):
...
@@ -67,6 +69,9 @@ class TestPatches(unittest.TestCase):
self
.
assertEqual
(
0
,
patch
.
addedExternalBonds
[
0
].
residue
)
self
.
assertEqual
(
0
,
patch
.
addedExternalBonds
[
0
].
residue
)
self
.
assertEqual
(
'C'
,
patch
.
deletedExternalBonds
[
0
].
name
)
self
.
assertEqual
(
'C'
,
patch
.
deletedExternalBonds
[
0
].
name
)
self
.
assertEqual
(
0
,
patch
.
deletedExternalBonds
[
0
].
residue
)
self
.
assertEqual
(
0
,
patch
.
deletedExternalBonds
[
0
].
residue
)
self
.
assertEqual
(
0
,
patch
.
virtualSites
[
0
][
0
].
index
)
self
.
assertEqual
([
1
,
1
],
patch
.
virtualSites
[
0
][
0
].
atoms
)
self
.
assertEqual
([
0.8
,
0.2
],
patch
.
virtualSites
[
0
][
0
].
weights
)
patch
=
list
(
ff
.
_templatePatches
[
'RES'
])[
0
]
patch
=
list
(
ff
.
_templatePatches
[
'RES'
])[
0
]
self
.
assertEqual
(
'Test'
,
patch
[
0
])
self
.
assertEqual
(
'Test'
,
patch
[
0
])
self
.
assertEqual
(
0
,
patch
[
1
])
self
.
assertEqual
(
0
,
patch
[
1
])
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment