Check type in __eq__() and __ne__(), simplify code

Check type in eq() and ne(), simplify code
8d6d5521 · Patrick Grinaway · 1f1a28b5 · 8d6d5521
Commit 8d6d5521 authored Dec 05, 2013 by Patrick Grinaway
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 5 deletions

wrappers/python/simtk/unit/basedimension.py wrappers/python/simtk/unit/basedimension.py +5 -5

No files found.
--- a/wrappers/python/simtk/unit/basedimension.py
+++ b/wrappers/python/simtk/unit/basedimension.py
@@ -91,14 +91,14 @@ class BaseDimension(object):
        return 'BaseDimension("%s")' % self.name
    def __eq__(self, other):
-        if self._index == other._index:
+        if isInstance(other, BaseDimension):
-            return True
+            return self._index == other._index
        return False
    def __ne__(self, other):
-        if self._index == other._index:
+        if isInstance(other, BaseDimension):
-            return False
+            return self._index != other._index
-        return True
+        return False
 # run module directly for testing