Created serialization proxy for CustomCompoundBondForce (see bug 1712)

serialization/include/openmm/serialization/CustomCompoundBondForceProxy.h

+#ifndef OPENMM_CUSTOMCOMPOUNDBONDFORCE_PROXY_H_
+#define OPENMM_CUSTOMCOMPOUNDBONDFORCE_PROXY_H_
+
+/* -------------------------------------------------------------------------- *
+ *                                   OpenMM                                   *
+ * -------------------------------------------------------------------------- *
+ * This is part of the OpenMM molecular simulation toolkit originating from   *
+ * Simbios, the NIH National Center for Physics-Based Simulation of           *
+ * Biological Structures at Stanford, funded under the NIH Roadmap for        *
+ * Medical Research, grant U54 GM072970. See https://simtk.org.               *
+ *                                                                            *
+ * Portions copyright (c) 2012 Stanford University and the Authors.           *
+ * Authors: Peter Eastman                                                     *
+ * Contributors:                                                              *
+ *                                                                            *
+ * Permission is hereby granted, free of charge, to any person obtaining a    *
+ * copy of this software and associated documentation files (the "Software"), *
+ * to deal in the Software without restriction, including without limitation  *
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,   *
+ * and/or sell copies of the Software, and to permit persons to whom the      *
+ * Software is furnished to do so, subject to the following conditions:       *
+ *                                                                            *
+ * The above copyright notice and this permission notice shall be included in *
+ * all copies or substantial portions of the Software.                        *
+ *                                                                            *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR *
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,   *
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL    *
+ * THE AUTHORS, CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,    *
+ * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR      *
+ * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE  *
+ * USE OR OTHER DEALINGS IN THE SOFTWARE.                                     *
+ * -------------------------------------------------------------------------- */
+
+#include "openmm/internal/windowsExport.h"
+#include "openmm/serialization/SerializationProxy.h"
+
+namespace OpenMM {
+
+/**
+ * This is a proxy for serializing CustomCompoundBondForce objects.
+ */
+
+class OPENMM_EXPORT CustomCompoundBondForceProxy : public SerializationProxy {
+public:
+    CustomCompoundBondForceProxy();
+    void serialize(const void* object, SerializationNode& node) const;
+    void* deserialize(const SerializationNode& node) const;
+};
+
+} // namespace OpenMM
+
+#endif /*OPENMM_CUSTOMCOMPOUNDBONDFORCE_PROXY_H_*/

serialization/src/CustomCompoundBondForceProxy.cpp

+/* -------------------------------------------------------------------------- *
+ *                                   OpenMM                                   *
+ * -------------------------------------------------------------------------- *
+ * This is part of the OpenMM molecular simulation toolkit originating from   *
+ * Simbios, the NIH National Center for Physics-Based Simulation of           *
+ * Biological Structures at Stanford, funded under the NIH Roadmap for        *
+ * Medical Research, grant U54 GM072970. See https://simtk.org.               *
+ *                                                                            *
+ * Portions copyright (c) 2010-2012 Stanford University and the Authors.      *
+ * Authors: Peter Eastman                                                     *
+ * Contributors:                                                              *
+ *                                                                            *
+ * Permission is hereby granted, free of charge, to any person obtaining a    *
+ * copy of this software and associated documentation files (the "Software"), *
+ * to deal in the Software without restriction, including without limitation  *
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,   *
+ * and/or sell copies of the Software, and to permit persons to whom the      *
+ * Software is furnished to do so, subject to the following conditions:       *
+ *                                                                            *
+ * The above copyright notice and this permission notice shall be included in *
+ * all copies or substantial portions of the Software.                        *
+ *                                                                            *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR *
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,   *
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL    *
+ * THE AUTHORS, CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,    *
+ * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR      *
+ * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE  *
+ * USE OR OTHER DEALINGS IN THE SOFTWARE.                                     *
+ * -------------------------------------------------------------------------- */
+
+#include "openmm/serialization/CustomCompoundBondForceProxy.h"
+#include "openmm/serialization/SerializationNode.h"
+#include "openmm/Force.h"
+#include "openmm/CustomCompoundBondForce.h"
+#include <sstream>
+
+using namespace OpenMM;
+using namespace std;
+
+CustomCompoundBondForceProxy::CustomCompoundBondForceProxy() : SerializationProxy("CustomCompoundBondForce") {
+}
+
+void CustomCompoundBondForceProxy::serialize(const void* object, SerializationNode& node) const {
+    node.setIntProperty("version", 1);
+    const CustomCompoundBondForce& force = *reinterpret_cast<const CustomCompoundBondForce*>(object);
+    node.setIntProperty("particles", force.getNumParticlesPerBond());
+    node.setStringProperty("energy", force.getEnergyFunction());
+    SerializationNode& perBondParams = node.createChildNode("PerBondParameters");
+    for (int i = 0; i < force.getNumPerBondParameters(); i++) {
+        perBondParams.createChildNode("Parameter").setStringProperty("name", force.getPerBondParameterName(i));
+    }
+    SerializationNode& globalParams = node.createChildNode("GlobalParameters");
+    for (int i = 0; i < force.getNumGlobalParameters(); i++) {
+        globalParams.createChildNode("Parameter").setStringProperty("name", force.getGlobalParameterName(i)).setDoubleProperty("default", force.getGlobalParameterDefaultValue(i));
+    }
+    SerializationNode& bonds = node.createChildNode("Bonds");
+    for (int i = 0; i < force.getNumBonds(); i++) {
+        vector<int> particles;
+        vector<double> params;
+        force.getBondParameters(i, particles, params);
+        SerializationNode& node = bonds.createChildNode("Bond");
+        for (int j = 0; j < (int) particles.size(); j++) {
+            stringstream key;
+            key << "p";
+            key << j+1;
+            node.setIntProperty(key.str(), particles[j]);
+        }
+        for (int j = 0; j < (int) params.size(); j++) {
+            stringstream key;
+            key << "param";
+            key << j+1;
+            node.setDoubleProperty(key.str(), params[j]);
+        }
+    }
+}
+
+void* CustomCompoundBondForceProxy::deserialize(const SerializationNode& node) const {
+    if (node.getIntProperty("version") != 1)
+        throw OpenMMException("Unsupported version number");
+    CustomCompoundBondForce* force = NULL;
+    try {
+        CustomCompoundBondForce* force = new CustomCompoundBondForce(node.getIntProperty("particles"), node.getStringProperty("energy"));
+        const SerializationNode& perBondParams = node.getChildNode("PerBondParameters");
+        for (int i = 0; i < (int) perBondParams.getChildren().size(); i++) {
+            const SerializationNode& parameter = perBondParams.getChildren()[i];
+            force->addPerBondParameter(parameter.getStringProperty("name"));
+        }
+        const SerializationNode& globalParams = node.getChildNode("GlobalParameters");
+        for (int i = 0; i < (int) globalParams.getChildren().size(); i++) {
+            const SerializationNode& parameter = globalParams.getChildren()[i];
+            force->addGlobalParameter(parameter.getStringProperty("name"), parameter.getDoubleProperty("default"));
+        }
+        const SerializationNode& bonds = node.getChildNode("Bonds");
+        vector<int> particles(force->getNumParticlesPerBond());
+        vector<double> params(force->getNumPerBondParameters());
+        for (int i = 0; i < (int) bonds.getChildren().size(); i++) {
+            const SerializationNode& bond = bonds.getChildren()[i];
+            for (int j = 0; j < (int) particles.size(); j++) {
+                stringstream key;
+                key << "p";
+                key << j+1;
+                particles[j] = bond.getIntProperty(key.str());
+            }
+            for (int j = 0; j < (int) params.size(); j++) {
+                stringstream key;
+                key << "param";
+                key << j+1;
+                params[j] = bond.getDoubleProperty(key.str());
+            }
+            force->addBond(particles, params);
+        }
+        return force;
+    }
+    catch (...) {
+        if (force != NULL)
+            delete force;
+        throw;
+    }
+}

serialization/src/SerializationProxyRegistration.cpp

@@ -34,6 +34,7 @@
 #include "openmm/CMMotionRemover.h"
 #include "openmm/CustomAngleForce.h"
 #include "openmm/CustomBondForce.h"
+#include "openmm/CustomCompoundBondForce.h"
 #include "openmm/CustomExternalForce.h"
 #include "openmm/CustomGBForce.h"
 #include "openmm/CustomHbondForce.h"
@@ -54,6 +55,7 @@
 #include "openmm/serialization/CMMotionRemoverProxy.h"
 #include "openmm/serialization/CustomAngleForceProxy.h"
 #include "openmm/serialization/CustomBondForceProxy.h"
+#include "openmm/serialization/CustomCompoundBondForceProxy.h"
 #include "openmm/serialization/CustomExternalForceProxy.h"
 #include "openmm/serialization/CustomGBForceProxy.h"
 #include "openmm/serialization/CustomHbondForceProxy.h"
@@ -89,6 +91,7 @@ extern "C" void registerSerializationProxies() {
     SerializationProxy::registerProxy(typeid(CMMotionRemover), new CMMotionRemoverProxy());
     SerializationProxy::registerProxy(typeid(CustomAngleForce), new CustomAngleForceProxy());
     SerializationProxy::registerProxy(typeid(CustomBondForce), new CustomBondForceProxy());
+    SerializationProxy::registerProxy(typeid(CustomCompoundBondForce), new CustomCompoundBondForceProxy());
     SerializationProxy::registerProxy(typeid(CustomExternalForce), new CustomExternalForceProxy());
     SerializationProxy::registerProxy(typeid(CustomGBForce), new CustomGBForceProxy());
     SerializationProxy::registerProxy(typeid(CustomHbondForce), new CustomHbondForceProxy());

serialization/tests/TestSerializeCustomCompoundBondForce.cpp

+/* -------------------------------------------------------------------------- *
+ *                                   OpenMM                                   *
+ * -------------------------------------------------------------------------- *
+ * This is part of the OpenMM molecular simulation toolkit originating from   *
+ * Simbios, the NIH National Center for Physics-Based Simulation of           *
+ * Biological Structures at Stanford, funded under the NIH Roadmap for        *
+ * Medical Research, grant U54 GM072970. See https://simtk.org.               *
+ *                                                                            *
+ * Portions copyright (c) 2010-2012 Stanford University and the Authors.      *
+ * Authors: Peter Eastman                                                     *
+ * Contributors:                                                              *
+ *                                                                            *
+ * Permission is hereby granted, free of charge, to any person obtaining a    *
+ * copy of this software and associated documentation files (the "Software"), *
+ * to deal in the Software without restriction, including without limitation  *
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,   *
+ * and/or sell copies of the Software, and to permit persons to whom the      *
+ * Software is furnished to do so, subject to the following conditions:       *
+ *                                                                            *
+ * The above copyright notice and this permission notice shall be included in *
+ * all copies or substantial portions of the Software.                        *
+ *                                                                            *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR *
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,   *
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL    *
+ * THE AUTHORS, CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,    *
+ * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR      *
+ * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE  *
+ * USE OR OTHER DEALINGS IN THE SOFTWARE.                                     *
+ * -------------------------------------------------------------------------- */
+
+#include "openmm/internal/AssertionUtilities.h"
+#include "openmm/CustomCompoundBondForce.h"
+#include "openmm/serialization/XmlSerializer.h"
+#include <iostream>
+#include <sstream>
+
+using namespace OpenMM;
+using namespace std;
+
+void testSerialization() {
+    // Create a Force.
+
+    CustomCompoundBondForce force(3, "5*sin(distance(p1,p2))^2+y*z");
+    force.addGlobalParameter("x", 1.3);
+    force.addGlobalParameter("y", 2.221);
+    force.addPerBondParameter("z");
+    vector<int> particles(3);
+    vector<double> params(1);
+    particles[0] = 0;
+    particles[1] = 1;
+    particles[2] = 2;
+    params[0] = 1.0;
+    force.addBond(particles, params);
+    particles[0] = 2;
+    particles[1] = 3;
+    particles[2] = 4;
+    params[0] = -3.3;
+    force.addBond(particles, params);
+    particles[0] = 3;
+    particles[1] = 5;
+    particles[2] = 1;
+    params[0] = 2.1;
+    force.addBond(particles, params);
+
+    // Serialize and then deserialize it.
+
+    stringstream buffer;
+    XmlSerializer::serialize<CustomCompoundBondForce>(&force, "Force", buffer);
+    CustomCompoundBondForce* copy = XmlSerializer::deserialize<CustomCompoundBondForce>(buffer);
+
+    // Compare the two forces to see if they are identical.
+
+    CustomCompoundBondForce& force2 = *copy;
+    ASSERT_EQUAL(force.getNumParticlesPerBond(), force2.getNumParticlesPerBond());
+    ASSERT_EQUAL(force.getEnergyFunction(), force2.getEnergyFunction());
+    ASSERT_EQUAL(force.getNumPerBondParameters(), force2.getNumPerBondParameters());
+    for (int i = 0; i < force.getNumPerBondParameters(); i++)
+        ASSERT_EQUAL(force.getPerBondParameterName(i), force2.getPerBondParameterName(i));
+    ASSERT_EQUAL(force.getNumGlobalParameters(), force2.getNumGlobalParameters());
+    for (int i = 0; i < force.getNumGlobalParameters(); i++) {
+        ASSERT_EQUAL(force.getGlobalParameterName(i), force2.getGlobalParameterName(i));
+        ASSERT_EQUAL(force.getGlobalParameterDefaultValue(i), force2.getGlobalParameterDefaultValue(i));
+    }
+    ASSERT_EQUAL(force.getNumBonds(), force2.getNumBonds());
+    for (int i = 0; i < force.getNumBonds(); i++) {
+        vector<int> particles1, particles2;
+        vector<double> params1, params2;
+        force.getBondParameters(i, particles1, params1);
+        force2.getBondParameters(i, particles2, params2);
+        ASSERT_EQUAL(params1.size(), params2.size());
+        for (int j = 0; j < (int) params1.size(); j++)
+            ASSERT_EQUAL(params1[j], params2[j]);
+        ASSERT_EQUAL(particles1.size(), particles2.size());
+        for (int j = 0; j < (int) particles1.size(); j++)
+            ASSERT_EQUAL(particles1[j], particles2[j]);
+    }
+}
+
+int main() {
+    try {
+        testSerialization();
+    }
+    catch(const exception& e) {
+        cout << "exception: " << e.what() << endl;
+        return 1;
+    }
+    cout << "Done" << endl;
+    return 0;
+}