ReferenceLJCoulombIxn.cpp 23.7 KB
Newer Older
1

2
/* Portions copyright (c) 2006-2013 Stanford University and Simbios.
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
 * Contributors: Pande Group
 *
 * Permission is hereby granted, free of charge, to any person obtaining
 * a copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation the rights to use, copy, modify, merge, publish,
 * distribute, sublicense, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject
 * to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included
 * in all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
 * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 * IN NO EVENT SHALL THE AUTHORS, CONTRIBUTORS OR COPYRIGHT HOLDERS BE
 * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 */

#include <string.h>
#include <sstream>
27
#include <complex>
28
#include <algorithm>
29

30
31
32
#include "SimTKOpenMMCommon.h"
#include "SimTKOpenMMLog.h"
#include "SimTKOpenMMUtilities.h"
33
34
#include "ReferenceLJCoulombIxn.h"
#include "ReferenceForce.h"
35
#include "ReferencePME.h"
36

37
38
// In case we're using some primitive version of Visual Studio this will
// make sure that erf() and erfc() are defined.
39
#include "openmm/internal/MSVC_erfc.h"
40

41
using std::set;
42
using std::vector;
43
using OpenMM::RealVec;
44

45
46
47
48
49
50
/**---------------------------------------------------------------------------------------

   ReferenceLJCoulombIxn constructor

   --------------------------------------------------------------------------------------- */

51
ReferenceLJCoulombIxn::ReferenceLJCoulombIxn( ) : cutoff(false), useSwitch(false), periodic(false), ewald(false), pme(false) {
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76

   // ---------------------------------------------------------------------------------------

   // static const char* methodName = "\nReferenceLJCoulombIxn::ReferenceLJCoulombIxn";

   // ---------------------------------------------------------------------------------------

}

/**---------------------------------------------------------------------------------------

   ReferenceLJCoulombIxn destructor

   --------------------------------------------------------------------------------------- */

ReferenceLJCoulombIxn::~ReferenceLJCoulombIxn( ){

   // ---------------------------------------------------------------------------------------

   // static const char* methodName = "\nReferenceLJCoulombIxn::~ReferenceLJCoulombIxn";

   // ---------------------------------------------------------------------------------------

}

77
78
79
80
81
82
83
84
85
86
  /**---------------------------------------------------------------------------------------

     Set the force to use a cutoff.

     @param distance            the cutoff distance
     @param neighbors           the neighbor list to use
     @param solventDielectric   the dielectric constant of the bulk solvent

     --------------------------------------------------------------------------------------- */

87
  void ReferenceLJCoulombIxn::setUseCutoff( RealOpenMM distance, const OpenMM::NeighborList& neighbors, RealOpenMM solventDielectric ) {
88

89
90
91
    cutoff = true;
    cutoffDistance = distance;
    neighborList = &neighbors;
92
93
    krf = pow(cutoffDistance, -3.0)*(solventDielectric-1.0)/(2.0*solventDielectric+1.0);
    crf = (1.0/cutoffDistance)*(3.0*solventDielectric)/(2.0*solventDielectric+1.0);
94
95
  }

96
97
98
99
100
101
102
103
104
105
106
107
108
/**---------------------------------------------------------------------------------------

   Set the force to use a switching function on the Lennard-Jones interaction.

   @param distance            the switching distance

   --------------------------------------------------------------------------------------- */

void ReferenceLJCoulombIxn::setUseSwitchingFunction( RealOpenMM distance ) {
    useSwitch = true;
    switchingDistance = distance;
}

109
110
111
112
113
114
  /**---------------------------------------------------------------------------------------

     Set the force to use periodic boundary conditions.  This requires that a cutoff has
     also been set, and the smallest side of the periodic box is at least twice the cutoff
     distance.

115
     @param vectors    the vectors defining the periodic box
116
117
118

     --------------------------------------------------------------------------------------- */

119
  void ReferenceLJCoulombIxn::setPeriodic(OpenMM::RealVec* vectors) {
120
121

    assert(cutoff);
122
123
124
    assert(vectors[0][0] >= 2.0*cutoffDistance);
    assert(vectors[1][1] >= 2.0*cutoffDistance);
    assert(vectors[2][2] >= 2.0*cutoffDistance);
125
    periodic = true;
126
127
128
    periodicBoxVectors[0] = vectors[0];
    periodicBoxVectors[1] = vectors[1];
    periodicBoxVectors[2] = vectors[2];
129
130
  }

131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
  /**---------------------------------------------------------------------------------------

     Set the force to use Ewald summation.

     @param alpha  the Ewald separation parameter
     @param kmaxx  the largest wave vector in the x direction
     @param kmaxy  the largest wave vector in the y direction
     @param kmaxz  the largest wave vector in the z direction

     --------------------------------------------------------------------------------------- */

  void ReferenceLJCoulombIxn::setUseEwald(RealOpenMM alpha, int kmaxx, int kmaxy, int kmaxz) {
      alphaEwald = alpha;
      numRx = kmaxx;
      numRy = kmaxy;
      numRz = kmaxz;
      ewald = true;
  }

150
151
152
153
154
  /**---------------------------------------------------------------------------------------

     Set the force to use Particle-Mesh Ewald (PME) summation.

     @param alpha  the Ewald separation parameter
155
     @param gridSize the dimensions of the mesh
156
157
158

     --------------------------------------------------------------------------------------- */

159
  void ReferenceLJCoulombIxn::setUsePME(RealOpenMM alpha, int meshSize[3]) {
160
      alphaEwald = alpha;
161
162
163
      meshDim[0] = meshSize[0];
      meshDim[1] = meshSize[1];
      meshDim[2] = meshSize[2];
164
165
166
      pme = true;
  }

167
168
169
170
171
172
173
/**---------------------------------------------------------------------------------------

   Calculate Ewald ixn

   @param numberOfAtoms    number of atoms
   @param atomCoordinates  atom coordinates
   @param atomParameters   atom parameters                             atomParameters[atomIndex][paramterIndex]
174
175
   @param exclusions       atom exclusion indices
                           exclusions[atomIndex] contains the list of exclusions for that atom
176
177
178
179
   @param fixedParameters  non atom parameters (not currently used)
   @param forces           force array (forces added)
   @param energyByAtom     atom energy
   @param totalEnergy      total energy
180
181
   @param includeDirect      true if direct space interactions should be included
   @param includeReciprocal  true if reciprocal space interactions should be included
182
183

   --------------------------------------------------------------------------------------- */
184

185
void ReferenceLJCoulombIxn::calculateEwaldIxn(int numberOfAtoms, vector<RealVec>& atomCoordinates,
186
                                             RealOpenMM** atomParameters, vector<set<int> >& exclusions,
187
                                             RealOpenMM* fixedParameters, vector<RealVec>& forces,
188
                                             RealOpenMM* energyByAtom, RealOpenMM* totalEnergy, bool includeDirect, bool includeReciprocal) const {
189
190
    typedef std::complex<RealOpenMM> d_complex;

191
    static const RealOpenMM epsilon     =  1.0;
192
    static const RealOpenMM one         =  1.0;
193
194
    static const RealOpenMM six         =  6.0;
    static const RealOpenMM twelve      = 12.0;
195

196
    int kmax                            = (ewald ? std::max(numRx, std::max(numRy,numRz)) : 0);
197
    RealOpenMM  factorEwald             = -1 / (4*alphaEwald*alphaEwald);
Peter Eastman's avatar
Peter Eastman committed
198
199
    RealOpenMM SQRT_PI                  = sqrt(PI_M);
    RealOpenMM TWO_PI                   = 2.0 * PI_M;
200
    RealOpenMM recipCoeff               = (RealOpenMM)(ONE_4PI_EPS0*4*PI_M/(periodicBoxVectors[0][0] * periodicBoxVectors[1][1] * periodicBoxVectors[2][2]) /epsilon);
201

202
    RealOpenMM totalSelfEwaldEnergy     = 0.0;
203
204
    RealOpenMM realSpaceEwaldEnergy     = 0.0;
    RealOpenMM recipEnergy              = 0.0;
205
    RealOpenMM totalRecipEnergy         = 0.0;
206
    RealOpenMM vdwEnergy                = 0.0;
207
208
209
210
211

// **************************************************************************************
// SELF ENERGY
// **************************************************************************************

212
213
214
215
216
217
218
    if (includeReciprocal) {
        for( int atomID = 0; atomID < numberOfAtoms; atomID++ ){
            RealOpenMM selfEwaldEnergy       = (RealOpenMM) (ONE_4PI_EPS0*atomParameters[atomID][QIndex]*atomParameters[atomID][QIndex] * alphaEwald/SQRT_PI);
            totalSelfEwaldEnergy            -= selfEwaldEnergy;
            if( energyByAtom ){
                energyByAtom[atomID]        -= selfEwaldEnergy;
            }
219
        }
220
221
    }

222
223
224
225
    if( totalEnergy ){
        *totalEnergy += totalSelfEwaldEnergy;
    }

226
227
228
// **************************************************************************************
// RECIPROCAL SPACE EWALD ENERGY AND FORCES
// **************************************************************************************
229
    // PME
230

231
  if (pme && includeReciprocal) {
232
233
    pme_t          pmedata; /* abstract handle for PME data */
    RealOpenMM virial[3][3];
234

235
    pme_init(&pmedata,alphaEwald,numberOfAtoms,meshDim,5,1);
236

peastman's avatar
peastman committed
237
238
239
    vector<RealOpenMM> charges(numberOfAtoms);
    for (int i = 0; i < numberOfAtoms; i++)
        charges[i] = atomParameters[i][QIndex];
240
    RealOpenMM periodicBoxSize[] = {periodicBoxVectors[0][0], periodicBoxVectors[1][1], periodicBoxVectors[2][2]};
peastman's avatar
peastman committed
241
    pme_exec(pmedata,atomCoordinates,forces,charges,periodicBoxSize,&recipEnergy,virial);
242

243
    if( totalEnergy )
244
245
246
247
248
249
       *totalEnergy += recipEnergy;

    if( energyByAtom )
        for(int n = 0; n < numberOfAtoms; n++)
            energyByAtom[n] += recipEnergy;

250
        pme_destroy(pmedata);
251
252
253
254
  }

    // Ewald method

255
  else if (ewald && includeReciprocal) {
256
257

    // setup reciprocal box
258

259
         RealOpenMM recipBoxSize[3] = { TWO_PI / periodicBoxVectors[0][0], TWO_PI / periodicBoxVectors[1][1], TWO_PI / periodicBoxVectors[2][2]};
260
261


262
    // setup K-vectors
263

264
  #define EIR(x, y, z) eir[(x)*numberOfAtoms*3+(y)*3+z]
265
266
267
  vector<d_complex> eir(kmax*numberOfAtoms*3);
  vector<d_complex> tab_xy(numberOfAtoms);
  vector<d_complex> tab_qxyz(numberOfAtoms);
268
269
270
271
272
273
274

  if (kmax < 1) {
      std::stringstream message;
      message << " kmax < 1 , Aborting" << std::endl;
      SimTKOpenMMLog::printError( message );
  }

275
276
  for(int i = 0; (i < numberOfAtoms); i++) {
    for(int m = 0; (m < 3); m++)
277
      EIR(0, i, m) = d_complex(1,0);
278

279
    for(int m=0; (m<3); m++)
280
281
      EIR(1, i, m) = d_complex(cos(atomCoordinates[i][m]*recipBoxSize[m]),
                               sin(atomCoordinates[i][m]*recipBoxSize[m]));
282

283
284
    for(int j=2; (j<kmax); j++)
      for(int m=0; (m<3); m++)
285
        EIR(j, i, m) = EIR(j-1, i, m) * EIR(1, i, m);
286
287
  }

288
289
    // calculate reciprocal space energy and forces

290
291
292
293
294
295
296
297
298
299
300
301
    int lowry = 0;
    int lowrz = 1;

    for(int rx = 0; rx < numRx; rx++) {

      RealOpenMM kx = rx * recipBoxSize[0];

      for(int ry = lowry; ry < numRy; ry++) {

        RealOpenMM ky = ry * recipBoxSize[1];

        if(ry >= 0) {
302
          for(int n = 0; n < numberOfAtoms; n++)
303
            tab_xy[n] = EIR(rx, n, 0) * EIR(ry, n, 1);
304
305
306
        }

        else {
307
          for(int n = 0; n < numberOfAtoms; n++)
308
            tab_xy[n]= EIR(rx, n, 0) * conj (EIR(-ry, n, 1));
309
310
311
312
313
        }

        for (int rz = lowrz; rz < numRz; rz++) {

          if( rz >= 0) {
314
315
           for( int n = 0; n < numberOfAtoms; n++)
             tab_qxyz[n] = atomParameters[n][QIndex] * (tab_xy[n] * EIR(rz, n, 2));
316
317
318
          }

          else {
319
320
            for( int n = 0; n < numberOfAtoms; n++)
              tab_qxyz[n] = atomParameters[n][QIndex] * (tab_xy[n] * conj(EIR(-rz, n, 2)));
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
          }

          RealOpenMM cs = 0.0f;
          RealOpenMM ss = 0.0f;

          for( int n = 0; n < numberOfAtoms; n++) {
            cs += tab_qxyz[n].real();
            ss += tab_qxyz[n].imag();
          }

          RealOpenMM kz = rz * recipBoxSize[2];
          RealOpenMM k2 = kx * kx + ky * ky + kz * kz;
          RealOpenMM ak = exp(k2*factorEwald) / k2;

          for(int n = 0; n < numberOfAtoms; n++) {
            RealOpenMM force = ak * (cs * tab_qxyz[n].imag() - ss * tab_qxyz[n].real());
337
338
339
            forces[n][0] += 2 * recipCoeff * force * kx ;
            forces[n][1] += 2 * recipCoeff * force * ky ;
            forces[n][2] += 2 * recipCoeff * force * kz ;
340
          }
341

342
343
          recipEnergy       = recipCoeff * ak * ( cs * cs + ss * ss);
          totalRecipEnergy += recipEnergy;
344
345
346
347
348
349
350
351

          if( totalEnergy )
             *totalEnergy += recipEnergy;

          if( energyByAtom )
             for(int n = 0; n < numberOfAtoms; n++)
               energyByAtom[n] += recipEnergy;

352
353
354
355
356
          lowrz = 1 - numRz;
        }
        lowry = 1 - numRy;
      }
    }
357
  }
358
359
360
361
362

// **************************************************************************************
// SHORT-RANGE ENERGY AND FORCES
// **************************************************************************************

363
364
    if (!includeDirect)
        return;
365
366
367
    RealOpenMM totalVdwEnergy            = 0.0f;
    RealOpenMM totalRealSpaceEwaldEnergy = 0.0f;

368
369
370
371
    for (int i = 0; i < (int) neighborList->size(); i++) {
       OpenMM::AtomPair pair = (*neighborList)[i];
       int ii = pair.first;
       int jj = pair.second;
372

373
       RealOpenMM deltaR[2][ReferenceForce::LastDeltaRIndex];
374
       ReferenceForce::getDeltaRPeriodic( atomCoordinates[jj], atomCoordinates[ii], periodicBoxVectors, deltaR[0] );
375
376
       RealOpenMM r         = deltaR[0][ReferenceForce::RIndex];
       RealOpenMM inverseR  = one/(deltaR[0][ReferenceForce::RIndex]);
377
378
379
380
381
382
       RealOpenMM switchValue = 1, switchDeriv = 0;
       if (useSwitch && r > switchingDistance) {
           RealOpenMM t = (r-switchingDistance)/(cutoffDistance-switchingDistance);
           switchValue = 1+t*t*t*(-10+t*(15-t*6));
           switchDeriv = t*t*(-30+t*(60-t*30))/(cutoffDistance-switchingDistance);
       }
383
       RealOpenMM alphaR    = alphaEwald * r;
384
385


Peter Eastman's avatar
Peter Eastman committed
386
387
       RealOpenMM dEdR      = (RealOpenMM) (ONE_4PI_EPS0 * atomParameters[ii][QIndex] * atomParameters[jj][QIndex] * inverseR * inverseR * inverseR);
                  dEdR      = (RealOpenMM) (dEdR * (erfc(alphaR) + 2 * alphaR * exp ( - alphaR * alphaR) / SQRT_PI ));
388

389
390
391
392
393
       RealOpenMM sig       = atomParameters[ii][SigIndex] +  atomParameters[jj][SigIndex];
       RealOpenMM sig2      = inverseR*sig;
                  sig2     *= sig2;
       RealOpenMM sig6      = sig2*sig2*sig2;
       RealOpenMM eps       = atomParameters[ii][EpsIndex]*atomParameters[jj][EpsIndex];
394
395
396
397
398
399
                  dEdR     += switchValue*eps*( twelve*sig6 - six )*sig6*inverseR*inverseR;
       vdwEnergy = eps*(sig6-one)*sig6;
       if (useSwitch) {
           dEdR -= vdwEnergy*switchDeriv*inverseR;
           vdwEnergy *= switchValue;
       }
400

401
       // accumulate forces
402

403
404
405
406
       for( int kk = 0; kk < 3; kk++ ){
          RealOpenMM force  = dEdR*deltaR[0][kk];
          forces[ii][kk]   += force;
          forces[jj][kk]   -= force;
407
408
       }

409
       // accumulate energies
410

411
       realSpaceEwaldEnergy        = (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*inverseR*erfc(alphaR));
412

413
414
       totalVdwEnergy             += vdwEnergy;
       totalRealSpaceEwaldEnergy  += realSpaceEwaldEnergy;
415

416
417
418
419
        if( energyByAtom ){
           energyByAtom[ii] += realSpaceEwaldEnergy + vdwEnergy;
           energyByAtom[jj] += realSpaceEwaldEnergy + vdwEnergy;
        }
420

421
    }
422

423
424
425
    if( totalEnergy )
        *totalEnergy += totalRealSpaceEwaldEnergy + totalVdwEnergy;

Peter Eastman's avatar
Peter Eastman committed
426
427
    // Now subtract off the exclusions, since they were implicitly included in the reciprocal space sum.

428
    RealOpenMM totalExclusionEnergy = 0.0f;
Peter Eastman's avatar
Peter Eastman committed
429
    for (int i = 0; i < numberOfAtoms; i++)
430
431
        for (set<int>::const_iterator iter = exclusions[i].begin(); iter != exclusions[i].end(); ++iter) {
            if (*iter > i) {
Peter Eastman's avatar
Peter Eastman committed
432
               int ii = i;
433
               int jj = *iter;
Peter Eastman's avatar
Peter Eastman committed
434
435

               RealOpenMM deltaR[2][ReferenceForce::LastDeltaRIndex];
436
               ReferenceForce::getDeltaR( atomCoordinates[jj], atomCoordinates[ii], deltaR[0] );
Peter Eastman's avatar
Peter Eastman committed
437
438
439
               RealOpenMM r         = deltaR[0][ReferenceForce::RIndex];
               RealOpenMM inverseR  = one/(deltaR[0][ReferenceForce::RIndex]);
               RealOpenMM alphaR    = alphaEwald * r;
440
441
442
               if (erf(alphaR) > 1e-6) {
                   RealOpenMM dEdR      = (RealOpenMM) (ONE_4PI_EPS0 * atomParameters[ii][QIndex] * atomParameters[jj][QIndex] * inverseR * inverseR * inverseR);
                              dEdR      = (RealOpenMM) (dEdR * (erf(alphaR) - 2 * alphaR * exp ( - alphaR * alphaR) / SQRT_PI ));
Peter Eastman's avatar
Peter Eastman committed
443

444
                   // accumulate forces
Peter Eastman's avatar
Peter Eastman committed
445

446
447
448
449
450
                   for( int kk = 0; kk < 3; kk++ ){
                      RealOpenMM force  = dEdR*deltaR[0][kk];
                      forces[ii][kk]   -= force;
                      forces[jj][kk]   += force;
                   }
Peter Eastman's avatar
Peter Eastman committed
451

452
                   // accumulate energies
Peter Eastman's avatar
Peter Eastman committed
453

454
                   realSpaceEwaldEnergy = (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*inverseR*erf(alphaR));
Peter Eastman's avatar
Peter Eastman committed
455

456
457
458
459
460
                   totalExclusionEnergy += realSpaceEwaldEnergy;
                   if( energyByAtom ){
                       energyByAtom[ii] -= realSpaceEwaldEnergy;
                       energyByAtom[jj] -= realSpaceEwaldEnergy;
                   }
461
               }
Peter Eastman's avatar
Peter Eastman committed
462
            }
463
        }
Peter Eastman's avatar
Peter Eastman committed
464

465
466
    if( totalEnergy )
        *totalEnergy -= totalExclusionEnergy;
467
468
469
}


470
471
472
473
474
475
476
/**---------------------------------------------------------------------------------------

   Calculate LJ Coulomb pair ixn

   @param numberOfAtoms    number of atoms
   @param atomCoordinates  atom coordinates
   @param atomParameters   atom parameters                             atomParameters[atomIndex][paramterIndex]
477
478
   @param exclusions       atom exclusion indices
                           exclusions[atomIndex] contains the list of exclusions for that atom
479
480
481
482
   @param fixedParameters  non atom parameters (not currently used)
   @param forces           force array (forces added)
   @param energyByAtom     atom energy
   @param totalEnergy      total energy
483
484
   @param includeDirect      true if direct space interactions should be included
   @param includeReciprocal  true if reciprocal space interactions should be included
485
486

   --------------------------------------------------------------------------------------- */
487

488
void ReferenceLJCoulombIxn::calculatePairIxn(int numberOfAtoms, vector<RealVec>& atomCoordinates,
489
                                             RealOpenMM** atomParameters, vector<set<int> >& exclusions,
490
                                             RealOpenMM* fixedParameters, vector<RealVec>& forces,
491
                                             RealOpenMM* energyByAtom, RealOpenMM* totalEnergy, bool includeDirect, bool includeReciprocal) const {
492

493
494
495
496
497
498
499
   if (ewald || pme) {
       calculateEwaldIxn(numberOfAtoms, atomCoordinates, atomParameters, exclusions, fixedParameters, forces, energyByAtom,
               totalEnergy, includeDirect, includeReciprocal);
       return;
   }
   if (!includeDirect)
       return;
500
   if (cutoff) {
501
       for (int i = 0; i < (int) neighborList->size(); i++) {
502
503
504
505
506
507
508
           OpenMM::AtomPair pair = (*neighborList)[i];
           calculateOneIxn(pair.first, pair.second, atomCoordinates, atomParameters, forces, energyByAtom, totalEnergy);
       }
   }
   else {
       for( int ii = 0; ii < numberOfAtoms; ii++ ){
          // loop over atom pairs
509

510
511
512
          for( int jj = ii+1; jj < numberOfAtoms; jj++ )
              if (exclusions[jj].find(ii) == exclusions[jj].end())
                  calculateOneIxn(ii, jj, atomCoordinates, atomParameters, forces, energyByAtom, totalEnergy);
513
514
515
       }
   }
}
516

517
  /**---------------------------------------------------------------------------------------
518

519
     Calculate LJ Coulomb pair ixn between two atoms
520

521
522
523
524
525
526
527
     @param ii               the index of the first atom
     @param jj               the index of the second atom
     @param atomCoordinates  atom coordinates
     @param atomParameters   atom parameters (charges, c6, c12, ...)     atomParameters[atomIndex][paramterIndex]
     @param forces           force array (forces added)
     @param energyByAtom     atom energy
     @param totalEnergy      total energy
528

529
     --------------------------------------------------------------------------------------- */
530

531
void ReferenceLJCoulombIxn::calculateOneIxn( int ii, int jj, vector<RealVec>& atomCoordinates,
532
                        RealOpenMM** atomParameters, vector<RealVec>& forces,
533
                        RealOpenMM* energyByAtom, RealOpenMM* totalEnergy ) const {
534

535
    // ---------------------------------------------------------------------------------------
536

537
    static const std::string methodName = "\nReferenceLJCoulombIxn::calculateOneIxn";
538

539
    // ---------------------------------------------------------------------------------------
540

541
    // constants -- reduce Visual Studio warnings regarding conversions between float & double
542

543
544
545
546
547
548
549
    static const RealOpenMM zero        =  0.0;
    static const RealOpenMM one         =  1.0;
    static const RealOpenMM two         =  2.0;
    static const RealOpenMM three       =  3.0;
    static const RealOpenMM six         =  6.0;
    static const RealOpenMM twelve      = 12.0;
    static const RealOpenMM oneM        = -1.0;
550

551
    static const int threeI             = 3;
552

553
554
555
556
557
558
559
    static const int LastAtomIndex      = 2;

    RealOpenMM deltaR[2][ReferenceForce::LastDeltaRIndex];

    // get deltaR, R2, and R between 2 atoms

    if (periodic)
560
        ReferenceForce::getDeltaRPeriodic( atomCoordinates[jj], atomCoordinates[ii], periodicBoxVectors, deltaR[0] );
561
    else
562
        ReferenceForce::getDeltaR( atomCoordinates[jj], atomCoordinates[ii], deltaR[0] );
563
564
565

    RealOpenMM r2        = deltaR[0][ReferenceForce::R2Index];
    RealOpenMM inverseR  = one/(deltaR[0][ReferenceForce::RIndex]);
566
567
568
569
570
571
572
573
574
    RealOpenMM switchValue = 1, switchDeriv = 0;
    if (useSwitch) {
        RealOpenMM r = deltaR[0][ReferenceForce::RIndex];
        if (r > switchingDistance) {
            RealOpenMM t = (r-switchingDistance)/(cutoffDistance-switchingDistance);
            switchValue = 1+t*t*t*(-10+t*(15-t*6));
            switchDeriv = t*t*(-30+t*(60-t*30))/(cutoffDistance-switchingDistance);
        }
    }
575
576
577
578
579
580
    RealOpenMM sig       = atomParameters[ii][SigIndex] +  atomParameters[jj][SigIndex];
    RealOpenMM sig2      = inverseR*sig;
               sig2     *= sig2;
    RealOpenMM sig6      = sig2*sig2*sig2;

    RealOpenMM eps       = atomParameters[ii][EpsIndex]*atomParameters[jj][EpsIndex];
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
    RealOpenMM dEdR      = switchValue*eps*( twelve*sig6 - six )*sig6;
    if (cutoff)
        dEdR += (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*(inverseR-2.0f*krf*r2));
    else
        dEdR += (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*inverseR);
    dEdR     *= inverseR*inverseR;
    RealOpenMM energy = eps*(sig6-one)*sig6;
    if (useSwitch) {
        dEdR -= energy*switchDeriv*inverseR;
        energy *= switchValue;
    }
    if (cutoff)
        energy += (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*(inverseR+krf*r2-crf));
    else
        energy += (RealOpenMM) (ONE_4PI_EPS0*atomParameters[ii][QIndex]*atomParameters[jj][QIndex]*inverseR);
596

597
598
599
600
601
602
603
604
605
606
    // accumulate forces

    for( int kk = 0; kk < 3; kk++ ){
       RealOpenMM force  = dEdR*deltaR[0][kk];
       forces[ii][kk]   += force;
       forces[jj][kk]   -= force;
    }

    // accumulate energies

607
608
609
610
611
    if( totalEnergy )
       *totalEnergy += energy;
    if( energyByAtom ){
       energyByAtom[ii] += energy;
       energyByAtom[jj] += energy;
612
613
    }
  }
614