1. 07 Dec, 2021 1 commit
  2. 18 Nov, 2021 2 commits
  3. 09 Oct, 2021 1 commit
  4. 25 Sep, 2021 1 commit
  5. 22 Jun, 2021 1 commit
  6. 08 Dec, 2020 1 commit
    • Alberto Ferreira's avatar
      Fix model locale issue and improve model R/W performance. (#3405) · 792c9303
      Alberto Ferreira authored
      * Fix LightGBM models locale sensitivity and improve R/W performance.
      
      When Java is used, the default C++ locale is broken. This is true for
      Java providers that use the C API or even Python models that require JEP.
      
      This patch solves that issue making the model reads/writes insensitive
      to such settings.
      To achieve it, within the model read/write codebase:
       - C++ streams are imbued with the classic locale
       - Calls to functions that are dependent on the locale are replaced
       - The default locale is not changed!
      
      This approach means:
       - The user's locale is never tampered with, avoiding issues such as
          https://github.com/microsoft/LightGBM/issues/2979 with the previous
          approach https://github.com/microsoft/LightGBM/pull/2891
       - Datasets can still be read according the user's locale
       - The model file has a single format independent of locale
      
      Changes:
       - Add CommonC namespace which provides faster locale-independent versions of Common's methods
       - Model code makes conversions through CommonC
       - Cleanup unused Common methods
       - Performance improvements. Use fast libraries for locale-agnostic conversion:
         - value->string: https://github.com/fmtlib/fmt
         - string->double: https://github.com/lemire/fast_double_parser (10x
            faster double parsing according to their benchmark)
      
      Bugfixes:
       - https://github.com/microsoft/LightGBM/issues/2500
       - https://github.com/microsoft/LightGBM/issues/2890
       - https://github.com/ninia/jep/issues/205
      
       (as it is related to LGBM as well)
      
      * Align CommonC namespace
      
      * Add new external_libs/ to python setup
      
      * Try fast_double_parser fix #1
      
      Testing commit e09e5aad828bcb16bea7ed0ed8322e019112fdbe
      
      If it works it should fix more LGBM builds
      
      * CMake: Attempt to link fmt without explicit PUBLIC tag
      
      * Exclude external_libs from linting
      
      * Add exernal_libs to MANIFEST.in
      
      * Set dynamic linking option for fmt.
      
      * linting issues
      
      * Try to fix lint includes
      
      * Try to pass fPIC with static fmt lib
      
      * Try CMake P_I_C option with fmt library
      
      * [R-package] Add CMake support for R and CRAN
      
      * Cleanup CMakeLists
      
      * Try fmt hack to remove stdout
      
      * Switch to header-only mode
      
      * Add PRIVATE argument to target_link_libraries
      
      * use fmt in header-only mode
      
      * Remove CMakeLists comment
      
      * Change OpenMP to PUBLIC linking in Mac
      
      * Update fmt submodule to 7.1.2
      
      * Use fmt in header-only-mode
      
      * Remove fmt from CMakeLists.txt
      
      * Upgrade fast_double_parser to v0.2.0
      
      * Revert "Add PRIVATE argument to target_link_libraries"
      
      This reverts commit 3dd45dde7b92531b2530ab54522bb843c56227a7.
      
      * Address James Lamb's comments
      
      * Update R-package/.Rbuildignore
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      
      * Upgrade to fast_double_parser v0.3.0 - Solaris support
      
      * Use legacy code only in Solaris
      
      * Fix lint issues
      
      * Fix comment
      
      * Address StrikerRUS's comments (solaris ifdef).
      
      * Change header guards
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      792c9303
  7. 08 Oct, 2020 1 commit
    • James Lamb's avatar
      [R-package] miscellaneous changes to comply with CRAN requirements (#3338) · 186711de
      James Lamb authored
      
      
      * [R-package] update DESCRIPTION per CRAN comments
      
      * newlines
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * more fixes
      
      * update Rbuildignore
      
      * more changes
      
      * more changes per CRAN response
      
      * add email
      
      * run examples in CI
      
      * add newest CRAN response
      
      * add Solaris patch
      
      * update patch
      
      * another attempt at ifaddrs patch
      
      * fix unnecessary comment
      
      * update configure
      
      * comments
      
      * bump version
      
      * tabs
      
      * fix address alignment, required by cran (#3415)
      
      * fix dataset binary file alignment
      
      * many fixes
      
      * fix warnings
      
      * fix bug
      
      * Update file_io.cpp
      
      * Update file_io.cpp
      
      * simplify code
      
      * Apply suggestions from code review
      
      * general
      
      * remove unneeded alignment
      
      * Update file_io.h
      
      * int32 to byte8 alignment
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * fixing conflicts
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * trying to fix conflicts
      
      * more fixes
      
      * this will work
      
      * update cran-comments
      
      * simplify solaris, add more testing docs
      
      * stuff
      
      * remove rchck docs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove extra use of cat()
      
      * change solaris check
      
      * update docs
      
      * remove testing code
      
      * fix warning about cleanup not having execute permissions
      
      * fix cmake builds
      
      * remove blank line
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      186711de
  8. 26 Sep, 2020 1 commit
  9. 25 Aug, 2020 1 commit
  10. 23 Aug, 2020 1 commit
  11. 13 Aug, 2020 1 commit
  12. 07 Aug, 2020 1 commit
    • Guolin Ke's avatar
      v3.0.0rc1 (#3071) · 63c82879
      Guolin Ke authored
      
      
      * Update VERSION.txt
      
      * Update VERSION.txt
      
      * Update setup.py
      
      * Update VERSION.txt
      
      * Update setup.py
      
      * Update VERSION.txt
      
      * Update .appveyor.yml
      
      * Update DESCRIPTION
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * Update DESCRIPTION
      
      * Apply suggestions from code review
      
      * Create VERSION.txt
      
      * Apply suggestions from code review
      
      * Update .gitignore
      
      * Update recreate-configure.sh
      
      * Update test_r_package.sh
      
      * Update build-cran-package.sh
      
      * Delete VERSION.txt
      
      * Create VERSION.txt
      
      * Update main.yml
      
      * Update test_r_package_windows.ps1
      
      * Update configure
      
      * Update test_r_package_windows.ps1
      
      * Update test_r_package.sh
      
      * Delete VERSION.txt
      
      * Apply suggestions from code review
      
      * update configure.ac
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      63c82879
  13. 22 Jul, 2020 1 commit
  14. 20 Jul, 2020 1 commit
  15. 12 Jul, 2020 1 commit
  16. 10 Jul, 2020 1 commit
  17. 14 May, 2020 1 commit
  18. 21 Apr, 2020 1 commit
  19. 15 Apr, 2020 1 commit
  20. 20 Jan, 2020 1 commit
  21. 15 Dec, 2019 1 commit
  22. 29 Nov, 2019 1 commit
  23. 28 Nov, 2019 1 commit
  24. 11 Nov, 2019 1 commit
  25. 29 Sep, 2019 3 commits
  26. 01 Sep, 2019 1 commit
    • Nikita Titov's avatar
      [docs][R] added R-package docs generation routines (#2176) · faba6caf
      Nikita Titov authored
      * added R-package docs generation routines
      
      * change theme to be more consistent with sphinx_rtd_theme on main site in terms of color scheme
      
      * placed man folder with old Rd files back
      
      * specify full path to conda and make script more readable by one line - one pkg
      
      * removed commented lines from build_r_site script
      
      * made one line - one argument in build_reference() call
      
      * pin R package versions
      
      * fixed conflict
      faba6caf
  27. 13 Aug, 2019 1 commit
  28. 05 Feb, 2019 2 commits
  29. 07 Nov, 2018 1 commit
  30. 06 Nov, 2018 1 commit
  31. 03 Oct, 2018 2 commits
  32. 20 Sep, 2018 1 commit
  33. 18 Sep, 2018 1 commit
    • Guolin Ke's avatar
      new release (#1649) · 7158a632
      Guolin Ke authored
      * Update VERSION.txt
      
      * Update DESCRIPTION
      
      * Update .appveyor.yml
      
      * Update .appveyor.yml
      
      * Update DESCRIPTION
      
      * Update VERSION.txt
      
      * Update .appveyor.yml
      
      * Update DESCRIPTION
      
      * Update VERSION.txt
      
      * Update DESCRIPTION
      7158a632
  34. 29 Aug, 2018 1 commit
    • James Lamb's avatar
      [R-package] CRAN fixes (#1499) · eded794e
      James Lamb authored
      * Fixed typos in docs
      
      * Fixed inconsistencies in documentation
      
      * Updated strategy for registering routines
      
      * Fixed issues caused by smashing multiple functions into one Rd
      
      * Fixed issues with documentation
      
      * Removed VignetteBuilder and updated Rbuildignore
      
      * Added R build artefacts to gitignore
      
      * Added namespacing on data.table set function. Updated handling of CMakeLists file to get around CRAN check.
      
      * Updated build instructions
      
      * Added R build script
      
      * Removed build_r.sh script and updated R-package install instructions
      eded794e
  35. 27 Aug, 2018 1 commit