1. 30 Sep, 2020 1 commit
    • Guolin Ke's avatar
      fix address alignment, required by cran (#3415) · f30dbe87
      Guolin Ke authored
      * fix dataset binary file alignment
      
      * many fixes
      
      * fix warnings
      
      * fix bug
      
      * Update file_io.cpp
      
      * Update file_io.cpp
      
      * simplify code
      
      * Apply suggestions from code review
      
      * general
      
      * remove unneeded alignment
      
      * Update file_io.h
      
      * int32 to byte8 alignment
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      f30dbe87
  2. 29 Jul, 2020 2 commits
    • James Lamb's avatar
      remove unnecessary semicolon (#3260) · 1cf13dba
      James Lamb authored
      1cf13dba
    • James Lamb's avatar
      [R-package] make package installable with CRAN toolchain (fixes #2960) (#3188) · aa933eb4
      James Lamb authored
      
      
      * [R-package] make package installable with CRAN toolchain (fixes #2960)
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove GPU stuff
      
      * use wildcard to find objects to build
      
      * use -lomp
      
      * build configure before moving files
      
      * using wildcard for objects
      
      * Update .github/workflows/main.yml
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * add explicit objects back
      
      * reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
      
      * fixing things
      
      * pin autoconf version
      
      * show diff
      
      * add automake back
      
      * run less checks
      
      * command was in the wrong place
      
      * fix autoconf version
      
      * change strategy for handling configure
      
      * fix Rbuildignore
      
      * fix NOTEs
      
      * fix notes about unrecognized files
      
      * fixing extra files
      
      * remove USE_R35
      
      * add OpenMP check for Mac CRAN build
      
      * run all checks
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * suggestions from code review
      
      * undo indenting
      
      * remove 03 from Makevars.win.in
      
      * update language about OpenMP in configure script
      
      * checking if configure.ac check works
      
      * add autoconf back
      
      * remove testing code in configure.ac
      
      * more fixes for CI on configure script
      
      * print git diff
      
      * add VERSION.txt when checking configure
      
      * fix relative paths
      
      * remove git diff
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      aa933eb4
  3. 19 Jul, 2020 1 commit
    • Joan Fontanals's avatar
      Change locking strategy of Booster, allow for share and unique locks (#2760) · 1c35c3b9
      Joan Fontanals authored
      
      
      * Add capability to get possible max and min values for a model
      
      * Change implementation to have return value in tree.cpp, change naming to upper and lower bound, move implementation to gdbt.cpp
      
      * Update include/LightGBM/c_api.h
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Change iteration to avoid potential overflow, add bindings to R and Python and a basic test
      
      * Adjust test values
      
      * Consider const correctness and multithreading protection
      
      * Put everything possible as const
      
      * Include shared_mutex, for now as unique_lock
      
      * Update test values
      
      * Put everything possible as const
      
      * Include shared_mutex, for now as unique_lock
      
      * Make PredictSingleRow const and share the lock with other reading threads
      
      * Update test values
      
      * Add test to check that model is exactly the same in all platforms
      
      * Try to parse the model to get the expected values
      
      * Try to parse the model to get the expected values
      
      * Fix implementation, num_leaves can be lower than the leaf_value_ size
      
      * Do not check for num_leaves to be smaller than actual size and get back to test with hardcoded value
      
      * Change test order
      
      * Add gpu_use_dp option in test
      
      * Remove helper test method
      
      * Remove TODO
      
      * Add preprocessing option to compile with c++17
      
      * Update python-package/setup.py
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Remove unwanted changes
      
      * Move option
      
      * Fix problems introduced by conflict fix
      
      * Avoid switching to c++17 and use yamc mutex library to access shared lock functionality
      
      * Add extra yamc include
      
      * Change header order
      
      * some lint fix
      
      * change include order and remove some extra blank lines
      
      * Further fix lint issues
      
      * Update c_api.cpp
      
      * Further fix lint issues
      
      * Move yamc include files to a new yamc folder
      
      * Use standard unique_lock
      
      * Update windows/LightGBM.vcxproj
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      
      * Update windows/LightGBM.vcxproj.filters
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      
      * Update windows/LightGBM.vcxproj.filters
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update windows/LightGBM.vcxproj.filters
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update windows/LightGBM.vcxproj.filters
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Fix problems coming from merge conflict resolution
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarjoanfontanals <jfontanals@ntent.com>
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      1c35c3b9
  4. 08 Jul, 2020 1 commit
  5. 23 Jun, 2020 1 commit
    • Belinda Trotta's avatar
      Interaction constraints (#3126) · bca2da97
      Belinda Trotta authored
      * Add interaction constraints functionality.
      
      * Minor fixes.
      
      * Minor fixes.
      
      * Change lambda to function.
      
      * Fix gpu bug, remove extra blank lines.
      
      * Fix gpu bug.
      
      * Fix style issues.
      
      * Try to fix segfault on MACOS.
      
      * Fix bug.
      
      * Fix bug.
      
      * Fix bugs.
      
      * Change parameter format for R.
      
      * Fix R style issues.
      
      * Change string formatting code.
      
      * Change docs to say R package not supported.
      
      * Remove R functionality, moving to separate PR.
      
      * Keep track of branch features in tree object.
      
      * Only track branch features when feature interactions are enabled.
      
      * Fix lint error.
      
      * Update docs and simplify tests.
      bca2da97
  6. 05 Jun, 2020 2 commits
  7. 01 Jun, 2020 1 commit
  8. 20 May, 2020 1 commit
  9. 13 Apr, 2020 1 commit
  10. 12 Apr, 2020 1 commit
  11. 10 Apr, 2020 1 commit
  12. 08 Apr, 2020 1 commit
  13. 04 Apr, 2020 1 commit
  14. 24 Mar, 2020 1 commit
    • James Lamb's avatar
      [R-package] Use Rprintf for logging in the R package (fixes #1440, fixes #1909) (#2901) · 0341906c
      James Lamb authored
      
      
      * [R-package] started cutting over from custom R-to-C interface to R.h
      
      * replaced LGBM_SE with SEXP
      
      * fixed error about ocnflicting definitions of length
      
      * got linking working
      
      * more stuff
      
      * eliminated R CMD CHECK note about printing
      
      * switched from hard-coded include dir to the one from FindLibR.cmake
      
      * cleaned up formatting in FindLibR.cmake
      
      * commented-out everything in CI that does not touch R
      
      * more changes
      
      * trying to get better logs
      
      * tried ignoring
      
      * added error message to confirm a suspicion
      
      * still trying to find R during R CMD CHECK
      
      * restore full CI
      
      * fixed comment
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * changed strategy for finding LIBR_HOME on Windows
      
      * Removed 32-bit Windows stuff in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed some duplication in cmake scripts
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * added LIBR_CORE_LIBRARY back
      
      * small fixes to CMakeLists
      
      * simplified FindLibR.cmake
      
      * some fixes for windows
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * allowed for directly passing LIBR_EXECUTABLE to FindLibR.cmake
      
      * reorganized FindLibR.cmake to catch more cases
      
      * clean up inconsistencies  in R calls in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed unnecessary log messages
      
      * removed unnecessary unset() call
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      0341906c
  15. 23 Mar, 2020 1 commit
  16. 17 Mar, 2020 1 commit
  17. 11 Mar, 2020 1 commit
  18. 06 Mar, 2020 1 commit
  19. 05 Mar, 2020 1 commit
    • Guolin Ke's avatar
      speed up `FindBestThresholdFromHistogram` (#2867) · 77d92b7c
      Guolin Ke authored
      * speed up for const hessian
      
      * rename template
      
      * some refactorings
      
      * refine
      
      * refine
      
      * simplify codes
      
      * fix random in feature histogram
      
      * code refine
      
      * refine
      
      * try fix
      
      * make gcc happy
      
      * remove timer
      
      * rollback some changes
      
      * more templates
      
      * fix a bug
      
      * reduce the cost of timer
      
      * fix gpu
      
      * fix bug
      
      * fix gpu
      77d92b7c
  20. 04 Mar, 2020 1 commit
  21. 02 Mar, 2020 2 commits
  22. 26 Feb, 2020 1 commit
  23. 25 Feb, 2020 1 commit
  24. 22 Feb, 2020 1 commit
    • Guolin Ke's avatar
      some code refactoring (#2769) · 3e80df7e
      Guolin Ke authored
      * some refines
      
      * more omp refactoring
      
      * format define
      
      * fix merge bug
      
      * some fixes
      
      * fix some warnings
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * remove dup codes
      3e80df7e
  25. 20 Feb, 2020 1 commit
    • Nikita Titov's avatar
      added feature infos to JSON dump (#2660) · c4a7ab81
      Nikita Titov authored
      
      
      * added feature infos to JSON dump
      
      * slight json schema refactor
      
      * simpified code
      
      * refactor feature_infos
      
      * refactoring
      
      * Update src/boosting/gbdt.cpp
      
      * Update dataset.h
      
      * Update include/LightGBM/dataset.h
      
      * simplify
      
      * Apply suggestions from code review
      
      * parse string and construct JSON objs
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      c4a7ab81
  26. 08 Feb, 2020 1 commit
  27. 04 Feb, 2020 1 commit
  28. 02 Feb, 2020 1 commit
    • Guolin Ke's avatar
      Support both row-wise and col-wise multi-threading (#2699) · 509c2e50
      Guolin Ke authored
      
      
      * commit
      
      * fix a bug
      
      * fix bug
      
      * reset to track changes
      
      * refine the auto choose logic
      
      * sort the time stats output
      
      * fix include
      
      * change  multi_val_bin_sparse_threshold
      
      * add cmake
      
      * add _mm_malloc and _mm_free for cross platform
      
      * fix cmake bug
      
      * timer for split
      
      * try to fix cmake
      
      * fix tests
      
      * refactor DataPartition::Split
      
      * fix test
      
      * typo
      
      * formating
      
      * Revert "formating"
      
      This reverts commit 5b8de4f7fb9d975ee23701d276a66d40ee6d4222.
      
      * add document
      
      * [R-package] Added tests on use of force_col_wise and force_row_wise in training (#2719)
      
      * naming
      
      * fix gpu code
      
      * Update include/LightGBM/bin.h
      Co-Authored-By: default avatarJames Lamb <jaylamb20@gmail.com>
      
      * Update src/treelearner/ocl/histogram16.cl
      
      * test: swap compilers for CI
      
      * fix omp
      
      * not avx2
      
      * no aligned for feature histogram
      
      * Revert "refactor DataPartition::Split"
      
      This reverts commit 256e6d9641ade966a1f54da1752e998a1149b6f8.
      
      * slightly refactor data partition
      
      * reduce the memory cost
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      509c2e50
  29. 15 Jan, 2020 1 commit
  30. 17 Dec, 2019 1 commit
  31. 29 Nov, 2019 1 commit
  32. 15 Nov, 2019 1 commit
  33. 11 Nov, 2019 1 commit
  34. 01 Nov, 2019 1 commit
  35. 07 Oct, 2019 1 commit
  36. 22 Sep, 2019 1 commit
  37. 08 Sep, 2019 1 commit
    • CharlesAuguste's avatar
      [python] Improved python tree plots (#2304) · f52be9be
      CharlesAuguste authored
      * Some basic changes to the plot of the trees to make them readable.
      
      * Squeezed the information in the nodes.
      
      * Added colouring when a dictionnary mapping the features to the constraints is passed.
      
      * Fix spaces.
      
      * Added data percentage as an option in the nodes.
      
      * Squeezed the information in the leaves.
      
      * Important information is now in bold.
      
      * Added a legend for the color of monotone splits.
      
      * Changed "split_gain" to "gain" and "internal_value" to "value".
      
      * Sqeezed leaves a bit more.
      
      * Changed description in the legend.
      
      * Revert "Sqeezed leaves a bit more."
      
      This reverts commit dd8bf14a3ba604b0dfae3b7bb1c64b6784d15e03.
      
      * Increased the readability for the gain.
      
      * Tidied up the legend.
      
      * Added the data percentage in the leaves.
      
      * Added the monotone constraints to the dumped model.
      
      * Monotone constraints are now specified automatically when plotting trees.
      
      * Raise an exception instead of the bug that was here before.
      
      * Removed operators on the branches for a clearer design.
      
      * Small cleaning of the code.
      
      * Setting a monotone constraint on a categorical feature now returns an exception instead of doing nothing.
      
      * Fix bug when monotone constraints are empty.
      
      * Fix another bug when monotone constraints are empty.
      
      * Variable name change.
      
      * Added is / isn't on every edge of the trees.
      
      * Fix test "tree_create_digraph".
      
      * Add new test for plotting trees with monotone constraints.
      
      * Typo.
      
      * Update documentation of categorical features.
      
      * Typo.
      
      * Information in nodes more explicit.
      
      * Used regular strings instead of raw strings.
      
      * Small refactoring.
      
      * Some cleaning.
      
      * Added future statement.
      
      * Changed output for consistency.
      
      * Updated documentation.
      
      * Added comments for colors.
      
      * Changed text on edges for more clarity.
      
      * Small refactoring.
      
      * Modified text in leaves for consistency with nodes.
      
      * Updated default values and documentaton for consistency.
      
      * Replaced CHECK with Log::Fatal for user-friendliness.
      
      * Updated tests.
      
      * Typo.
      
      * Simplify imports.
      
      * Swapped count and weight to improve readibility of the leaves in the plotted trees.
      
      * Thresholds in bold.
      
      * Made information in nodes written in a specific order.
      
      * Added information to clarify legend.
      
      * Code cleaning.
      f52be9be