Commits · e08cffba4096086b3787412db7e183ac4346958f · tianlh / LightGBM-DCU

19 Jun, 2022 3 commits

[R-package] Specify concrete linting rule that is being ignored via `nolint` mark (#5300) · e08cffba
Nikita Titov authored Jun 19, 2022
```
* Update make-r-def.R

* Update make-r-def.R

* Update build_r.R

* Update utils.R

* Update install.libs.R
```
e08cffba

[python-package] add type hints on `cv()` (#5271) · 2f5baa3d

James Lamb authored Jun 18, 2022



* [python-package] add type hints on cv()

* remove inadvertent changes

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

2f5baa3d

[python-package] Use scikit-learn interpretation of negative `n_jobs` and... · f3ea1ad7

david-cortes authored Jun 19, 2022


[python-package] Use scikit-learn interpretation of negative `n_jobs` and change default to number of cores (#5105)

* use joblib formula for negative n_jobs

* correction for n_jobs calculation

* use more robust cpu_count from joblib

* change default n_jobs to number of cores

* fix detection of num_threads under parameters

* better handling of n_jobs at prediction time

* fix incorrect usage of list.pop

* correct pop/remove yet again

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update tests/python_package_test/test_sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update tests/python_package_test/test_sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* add comments clarifying negative n_jobs

* fix CI (code taken from PR comment)

* change default to n_jobs=None in dask interface

* corrections for handling of n_jobs

* linter

* corrections for predict-time n_jobs

* linter

* add more comments about n_jobs values

* linter

* more corrections

* linter

* linter

* linter

* Update python-package/lightgbm/compat.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update python-package/lightgbm/sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* workaround for passing test about outputs with multiple threads

* Update tests/python_package_test/test_sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update tests/python_package_test/test_sklearn.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

f3ea1ad7

17 Jun, 2022 1 commit

[R-package] Add sparse feature contribution predictions (#5108) · 6f92d47a

david-cortes authored Jun 17, 2022



* add predcontrib for sparse inputs

* register newly-added function

* comments

* correct wrong types in test

* forcibly take transpose function from Matrix

* keep row names, test comparison to dense inputs

* workaround for passing test while PR for row names is not merged

* Update R-package/R/lgb.Predictor.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.Predictor.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update R-package/R/lgb.Predictor.R
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* proper handling of integer overflow

* add test for CSR contrib row names

* add more tests for predict(<sparse>, predcontrib=TRUE)

* make linter happy

* linter

* linter

* check error messages for bad input shapes

* fix regex

* hard-coded number of columns in regex for tests
Co-authored-by: James Lamb <jaylamb20@gmail.com>

6f92d47a

16 Jun, 2022 1 commit
- [ci] [R-package] upgrade to lintr v3.0 (fixes #5228) (#5294) · 688f73d1
  James Lamb authored Jun 16, 2022
  
  688f73d1
14 Jun, 2022 2 commits

[ci] Pin lintr to <3.0 (#5290) · f96c4ceb
Jonathan Giannuzzi authored Jun 14, 2022
```
Do not use r-lintr 3.0+
```
f96c4ceb

[R-package] [docs] document difference between lightgbm() and lgb.train() (fixes #5203) (#5273) · 9be084c6

James Lamb authored Jun 13, 2022



* [R-package] [docs] document difference between lightgbm() and lgb.train() (fixes #5203)

* clarify language

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

9be084c6

13 Jun, 2022 2 commits

[docs] Use https links in docs (#5284) · ab9236ba
Nikita Titov authored Jun 13, 2022
```
Use https links in docs
```
ab9236ba

[ci] Run Linux OpenCL tests against POCL instead of the AMD App SDK (#5282) · 6b89651d

Jonathan Giannuzzi authored Jun 13, 2022



* Run OpenCL tests against POCL instead of the AMD App SDK

* Update .ci/setup.sh
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Run Linux gpu source on default Python version

* [docs] Update GPU Targets Table
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

6b89651d

12 Jun, 2022 1 commit
- [python-package] remove `Booster.set_attr()` and `Booster.attr()` (#5272) · 11110c54
  James Lamb authored Jun 12, 2022
  
  11110c54
08 Jun, 2022 1 commit

Clear split info buffer in cost efficient gradient boosting before every... · f1328d5c

shiyu1994 authored Jun 08, 2022

Clear split info buffer in cost efficient gradient boosting before every iteration (fix partially #3679) (#5164)

* clear split info buffer in cegb_ before every iteration

* check nullable of cegb_ in serial_tree_learner.cpp

* add a test case for checking the split buffer in CEGB

* swith to Threading::For instead of raw OpenMP

* apply review suggestions

* apply review comments

* remove device cpu

f1328d5c

05 Jun, 2022 5 commits
- [tests][python] Make test that checks original pandas data isn't modified more strict (#5267) · 27d9ad2e
  Nikita Titov authored Jun 06, 2022
```
* Update test_basic.py

* Address review comment
```
  27d9ad2e
- [python] add more type hints in basic.py (#5255) · 1dc7a293
  James Lamb authored Jun 05, 2022
```
* [python] add more type hints in basic.py

* Update python-package/lightgbm/basic.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
```
  1dc7a293
- [R-package] [docs] upgrade docs to roxygen2==7.2.0 (#5251) · 1cc9f9dc
  James Lamb authored Jun 04, 2022
```
[R-package] upgrade docs to roxygen2==7.2.0
```
  1cc9f9dc
- [python-package] make a shallow copy on dataframe rename (fixes #4596) (#5254) · 65b3db1c
  José Morales authored Jun 04, 2022
```
* dont copy dataframe on rename

* test with feature_name and 'auto'
```
  65b3db1c
- [docs] Update broken links in docs (#5265) · f7156457
  Nikita Titov authored Jun 05, 2022
```
Update GPU-Windows.rst
```
  f7156457
04 Jun, 2022 1 commit
- [docs] add Microsoft security policy (fixes #5235) (#5264) · 695fe8ba
  James Lamb authored Jun 04, 2022
  
  695fe8ba
02 Jun, 2022 1 commit
- [c++][fix] check nullable of bin mappers in dataset_loader.cpp (fix #5221) (#5258) · fa9e4527
  shiyu1994 authored Jun 02, 2022
```
check nullable of bin mappers
```
  fa9e4527
31 May, 2022 3 commits
- [python] add more type hints on LGBMModel methods (#5239) · 4971a066
  James Lamb authored May 30, 2022
  
  4971a066
- [R-package] address linter warnings about portable paths (#5249) · 9893867c
  James Lamb authored May 30, 2022
  
  9893867c
- [R-package] [ci] silence more logs in tests (fixes #4862) (#5250) · 59f59c9f
  James Lamb authored May 30, 2022
  
  59f59c9f
29 May, 2022 1 commit
- Remove leftovers after the drop of Solaris support (#5248) · fb37e507
  Nikita Titov authored May 29, 2022
```
* Update tree.cpp

* Update common.h

* Update common.h
```
  fb37e507
25 May, 2022 2 commits
- [python] add type hints on sklearn metric and eval wrappers (#5238) · 23da5fc5
  James Lamb authored May 25, 2022
  
  23da5fc5
- [R-package] silence logs in print(), show(), summary() tests (#5237) · 1a3afd2d
  James Lamb authored May 25, 2022
  
  1a3afd2d
24 May, 2022 2 commits
- [R-package] standardize style for placement of braces (#5240) · f2e1ad6f
  James Lamb authored May 24, 2022
  
  f2e1ad6f
- [python] Fix training on subset constructed without params (#5213) · a4478f7e
  Nikita Titov authored May 24, 2022
```
* Update basic.py

* Update test_engine.py

* Add return type annotation
```
  a4478f7e
23 May, 2022 5 commits

Check existence of inet_pton for win32 in CMakeLists.txt (fixes #5019) (#5159) · 17bfe1a1

shiyu1994 authored May 24, 2022



* check existence of inet_pton for win32 in CMakeLists.txt (fix #5019)

* remove extra spaces

* add check for inet_pton in configure.win

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/network/socket_wrapper.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/network/socket_wrapper.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/configure.win
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* fix comments in CMakeLists.txt

* include check for WIN64

* remove WIN64 flag checks

* fix #ifdef

* Update R-package/configure.win
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

17bfe1a1

[R-package] remove semicolon in R code (#5232) · 7b51ee1c
James Lamb authored May 23, 2022

7b51ee1c
[R-package] remove Solaris reference in test message (#5231) · d3832368
James Lamb authored May 23, 2022

d3832368
[R-package] silence more logs in unit tests (#5227) · dd3294d7
James Lamb authored May 22, 2022

dd3294d7
[ci] switch CRAN mirror to RStudio (#5230) · 0ebbf1e4
James Lamb authored May 22, 2022

0ebbf1e4

22 May, 2022 2 commits
- [python-package] make a shallow copy when replacing categorical features with... · c000b8cc
  José Morales authored May 21, 2022
```
[python-package] make a shallow copy when replacing categorical features with codes (fixes #4596) (#5225)
```
  c000b8cc
- remove support for Solaris (fixes #5216) (#5226) · b0774151
  James Lamb authored May 21, 2022
  
  b0774151
18 May, 2022 2 commits

[R-package] stop automatically calculating eval metrics on training data in lightgbm() (#5209) · 1617a63e

James Lamb authored May 18, 2022

* [R-package] stop automatically calculating eval metrics on training data in lightgbm()

* update docs

* update docs

* roxygen cares about line breaks

1617a63e

Cleanup codeowners (#5215) · 7d89ab40

Nikita Titov authored May 19, 2022

* Update CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS

7d89ab40

17 May, 2022 2 commits

[python-package][R-package] allow using feature names when retrieving number of bins (#5116) · 5b664b67

José Morales authored May 16, 2022

* allow using feature names when retrieving number of bins

* unname vector

* use default feature names when not defined

* lint

* apply suggestions

* remove extra comma

* add test with categorical feature

* make feature names sync more transparent

5b664b67

[R-package] minor improvements on weight demo (#5212) · 53218c11
José Morales authored May 16, 2022
```
minor improvements on weight demo
```
53218c11

14 May, 2022 1 commit
- [ci] fix R Hub token (#5210) · 2871b53e
  James Lamb authored May 14, 2022
  
  2871b53e
11 May, 2022 1 commit
- [R-package] silence more logs in tests (#5208) · 00182067
  James Lamb authored May 11, 2022
  
  00182067
10 May, 2022 1 commit
- [R-package] remove lgb.unloader() (#5204) · eababef8
  James Lamb authored May 10, 2022
```
* [R-package] remove lgb.unloader()

* update version reference
```
  eababef8