- 22 Dec, 2020 1 commit
-
-
Jan Stiborek authored
* migrated implementation from dask/dask-lightgbm * relaxed tests * tests skipped in case that MPI is used * fixed python 2.7 import + tests disabled on windows * python < 3.6 is not supported in tests * tests enabled only for linux * tests disabled for mpi interface * dask version pinned to >= 2.0 * added @jameslamb as code owner * added missing pandas dependency * code refactoring, removed code duplication - lightgbm.dask.LGBMClassifier.fit is the same as lightgbm.dask.LGBMRegressor.fit * fixed refactoring * code deduplication - fit method moved into mixin class * fixed CODEOWNERS * removed unnecessary import * skip the module execution on python < 3.6 and on platform different than linux. * removed skip for python < 3.6 * review comments * removed noqa, renamed API classes, renamed local variables
-
- 15 Dec, 2020 1 commit
-
-
penolove authored
-
- 09 Dec, 2020 1 commit
-
-
Nikita Titov authored
* Update setup.py * Update .appveyor.yml * Update .travis.yml * Update .vsts-ci.yml * Update __init__.py * Update test.sh * Update test_windows.ps1 * Update advanced_example.py * Update requirements_base.txt * Update conf.py * Update conf.py * Update test_engine.py * Update utils.py * Update dockerfile-r * Update README.md * Update dockerfile.gpu * Update test_consistency.py * Update basic.py * Update compat.py * Update engine.py * Update sklearn.py * Update sklearn.py * Update callback.py * Update setup.py * Update __init__.py * Update plotting.py * Update sklearn.py * Update engine.py * Update compat.py * Update callback.py * Update basic.py * Update compat.py * Update basic.py * Update basic.py * Update compat.py * Update compat.py * Update plotting.py * Update engine.py * Update basic.py * Update sklearn.py * Update compat.py * Update engine.py * Update engine.py * Update callback.py * Update basic.py * Update basic.py * Update basic.py * Update basic.py * Update basic.py * Update sklearn.py * Update sklearn.py * Update plotting.py * Update sklearn.py * Update compat.py * Update compat.py * Update engine.py * Update plotting.py * Update sklearn.py * Update basic.py * Update basic.py * Update basic.py * Update basic.py * Update compat.py * Update compat.py * Update compat.py * Update engine.py * Update basic.py * Update compat.py * Update basic.py * Update basic.py * Update basic.py * Update compat.py * Update compat.py * Update basic.py * Update basic.py * Update .vsts-ci.yml * Update .vsts-ci.yml * Update conf.py * Revert "Update dockerfile-r" This reverts commit 4ff6ffc7e3eeda24cc6a59a3bb0c973f02d9d71c.
-
- 07 Dec, 2020 1 commit
-
-
James Lamb authored
[python][docs] more detailed docs for trees_to_dataframe(), create_tree_digraph(), plot_tree() (#3618) * [python] more detailed docs for trees_to_dataframe(), create_tree_digraph(), plot_tree() * fixing warnings * fix warnings * undo unnecessary space * Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * single line, better weight descriptions * Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * column names * Update python-package/lightgbm/plotting.py Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 15 Nov, 2020 1 commit
-
-
Nikita Titov authored
-
- 10 Nov, 2020 1 commit
-
-
Guillaume Lemaitre authored
* TST make sklearn integration test compatible with 0.24 * remove useless import * remove outdated comment * order import * use parametrize_with_checks * change the reason * skip constructible if != 0.23 * make tests behave the same across sklearn version * linter * address suggestions
-
- 26 Oct, 2020 1 commit
-
-
Guolin Ke authored
* fix subset bug * typo * add fixme tag * bin mapper * fix test * fix add_features_from * Update dataset.cpp * fix merge bug * added Python merge code * added test for add_features * Update dataset.cpp * Update src/io/dataset.cpp * continue implementing * warn users about categorical features Co-authored-by:
StrikerRUS <nekit94-12@hotmail.com> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 30 Sep, 2020 2 commits
-
-
Nikita Titov authored
-
Belinda Trotta authored
-
- 29 Sep, 2020 1 commit
-
-
James Lamb authored
* [python] fix dangerous default for eval_at in LGBMRanker * use a tuple * five * Update python-package/lightgbm/sklearn.py Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 11 Sep, 2020 1 commit
-
-
James Lamb authored
-
- 06 Sep, 2020 1 commit
-
-
Germán Ramírez-Espinoza authored
* Refactors sklearn API to allow a list of evaluation metrics in the parameter eval_metric of the class (and subclasses of) LGBMModel. Also adds unit tests for this functionality * Simplify expression to check whether the user passed one or multiple metrics to eval_metric parameter * Simplify new tests by using custom metrics already defined in the test file * Update docstring to reflect the fact that the parameter "feval" from the "train" and "cv" functions can also receive a list of callables * Remove oxford comma from docstrings Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * Use named-parameters to make sure code is compatible with future versions of scikit-learn Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * Remove throwaway return value to make code more succinct Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * Move statement to group together the code related to feval * Avoid modifying original args as it causes errors in scikit-learn tools For details see: https://github.com/microsoft/LightGBM/pull/2619 * Consolidate multiple eval-metrics unit-tests into one test Co-authored-by:
German I Ramirez-Espinoza <gire@home> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 02 Sep, 2020 1 commit
-
-
Nikita Titov authored
-
- 24 Aug, 2020 1 commit
-
-
Nikita Titov authored
-
- 11 Aug, 2020 1 commit
-
-
Nikita Titov authored
simplify start_iteration param for predict in Python and some code cleanup for start_iteration (#3288) * simplify start_iteration param for predict in Python and some code cleanup for start_iteration * revert docs changes about the prediction result shape
-
- 06 Aug, 2020 2 commits
-
-
shiyu1994 authored
* [python] add start_iteration to python predict interface (#3058) * Apply suggestions from code review * Update lightgbm_R.h * Apply suggestions from code review * Apply suggestions from code review * fix R interface * update R documentation Co-authored-by:Guolin Ke <guolin.ke@outlook.com>
-
Guolin Ke authored
* [doc] better doc for `keep_training_booster` * Update python-package/lightgbm/engine.py Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 02 Aug, 2020 1 commit
-
-
momijiame authored
* [python] add return_cvbooster flag to cv function and rename _CVBooster to make public (#283,#2105) * [python] Reduce expected metric of unit testing * [docs] add the CVBooster to the documentation * [python] reflect the review comments - Add some clarifications to the documentation - Rename CVBooster.append to make private - Decrease iteration rounds of testing to save CI time - Use CVBooster as root member of lgb * [python] add more checks in testing for cv Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * [python] add docstring for instance attributes of CVBooster Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * [python] fix docstring Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 15 Jul, 2020 1 commit
-
-
Guolin Ke authored
* feature importance type in saved model file * fix nullptr * fixed formatting * fix python/R * Update src/c_api.cpp * Apply suggestions from code review Co-authored-by:
James Lamb <jaylamb20@gmail.com> * fix c_api test * fix swig * minor docs improvements and added defines for importance types Co-authored-by:
StrikerRUS <nekit94-12@hotmail.com> Co-authored-by:
James Lamb <jaylamb20@gmail.com>
-
- 14 Jul, 2020 1 commit
-
-
Germán Ramírez-Espinoza authored
[python][scikit-learn] Fixes a bug that prevented using multiple eval_metrics in LGBMClassifier (#3222) * Fixes a bug that prevented using multiple eval_metrics in LGBMClassifier * Move bug-fix test to the test_metrics unit-test * Fix test to avoid issues with existing tests * Fix coding-style error Co-authored-by:German I Ramirez-Espinoza <gire@home>
-
- 07 Jul, 2020 1 commit
-
-
Guolin Ke authored
* Update engine.py * Update sklearn.py
-
- 28 Jun, 2020 1 commit
-
-
Ilya Matiach authored
* adding sparse support to TreeSHAP in lightgbm * updating based on comments * updated based on comments, used fromiter instead of frombuffer * updated based on comments * fixed limits import order * fix sparse feature contribs to work with more than int32 max rows * really fixed int64 max error and build warnings * added sparse test with >int32 max rows * fixed python side reshape check on sparse data * updated based on latest comments * fixed comments * added CSC INT32_MAX validation to test, fixed comments
-
- 27 Jun, 2020 1 commit
-
-
Alex authored
* modify attribute and include stacking tests * backwards compatibility * check sklearn version * move stacking import * Number of input features (#3173) * Number of input features (#3173) * Number of input features (#3173) * Number of input features (#3173) Split number of features and stacking tests. * Number of input features (#3173) Modify test name. * Number of input features (#3173) Update stacking tests for review comments. * Number of input features (#3173) * Number of input features (#3173) * Number of input features (#3173) * Number of input features (#3173) Modify classifier test. * Number of input features (#3173) * Number of input features (#3173) Check score.
-
- 23 Jun, 2020 1 commit
-
-
Belinda Trotta authored
* Add interaction constraints functionality. * Minor fixes. * Minor fixes. * Change lambda to function. * Fix gpu bug, remove extra blank lines. * Fix gpu bug. * Fix style issues. * Try to fix segfault on MACOS. * Fix bug. * Fix bug. * Fix bugs. * Change parameter format for R. * Fix R style issues. * Change string formatting code. * Change docs to say R package not supported. * Remove R functionality, moving to separate PR. * Keep track of branch features in tree object. * Only track branch features when feature interactions are enabled. * Fix lint error. * Update docs and simplify tests.
-
- 22 Jun, 2020 1 commit
-
-
Nikita Titov authored
* Revert "[ci][docs] temporarily pin Sphinx version (#3157)" This reverts commit b3a84df5. * removed duplicated docstrings
-
- 11 Jun, 2020 1 commit
-
-
Nikita Titov authored
-
- 02 Jun, 2020 1 commit
-
-
Alex authored
* update number of features attribute Fixes issue related to https://github.com/scikit-learn/scikit-learn/issues/17353 (see SLEP010 https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html ). * Update sklearn.py * set public attribute in fit method Reverted ```n_features``` property, and inserted the public attribute ```n_features_in_```. * Update documentation * Update python-package/lightgbm/sklearn.py Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 20 May, 2020 1 commit
-
-
Guolin Ke authored
* redir log to python console * fix pylint * Apply suggestions from code review * Update basic.py * Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * Update c_api.h * Apply suggestions from code review * Apply suggestions from code review * super-minor: better wording Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
StrikerRUS <nekit94-12@hotmail.com>
-
- 12 May, 2020 1 commit
-
-
Nikita Titov authored
-
- 05 May, 2020 1 commit
-
-
Nikita Titov authored
-
- 10 Apr, 2020 2 commits
-
-
OMOTO Tsukasa authored
* Support UTF-8 characters in feature name again This commit reverts 0d59859c. Also see: - https://github.com/microsoft/LightGBM/issues/2226 - https://github.com/microsoft/LightGBM/issues/2478 - https://github.com/microsoft/LightGBM/pull/2229 I reproduced the issue and as @kidotaka gave us a great survey in #2226, I don't conclude that the cause is UTF-8, but "an empty string (character)". Therefore, I revert "throw error when meet non ascii (#2229)" whose commit hash is 0d59859c, and add support feture names as UTF-8 again. * add tests * fix check-docs tests * update * fix tests * update .travis.yml * fix tests * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * add a test for R-package * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * fix test for R-package * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * update * updte * update * remove unneeded comments
-
Nikita Titov authored
* Revert "specify the last supported version of scikit-learn (#2637)" This reverts commit d1002776. * ban scikit-learn 0.22.0 and skip broken test * fix updated test * fix lint test * Revert "fix lint test" This reverts commit 8b4db0805fe7a9e7f7eb0be3eac231f85026d196.
-
- 20 Mar, 2020 2 commits
-
-
Alberto Ferreira authored
* [swig] Fix SWIG methods that return char** with StringArray. + [new] Add StringArray class to manage and manipulate arrays of fixed-length strings: This class is now used to wrap any char** parameters, manage memory and manipulate the strings. Such class is defined at swig/StringArray.hpp and wrapped in StringArray.i. + [API+fix] Wrap LGBM_BoosterGetFeatureNames it resulted in segfault before: Added wrapper LGBM_BoosterGetFeatureNamesSWIG(BoosterHandle) that only receives the booster handle and figures how much memory to allocate for strings and returns a StringArray which can be easily converted to String[]. + [API+safety] For consistency, LGBM_BoosterGetEvalNamesSWIG was wrapped as well: * Refactor to detect any kind of errors and removed all the parameters besides the BoosterHandle (much simpler API to use in Java). * No assumptions are made about the required string space necessary (128 before). * The amount of required string memory is computed internally + [safety] No possibility of undefined behaviour The two methods wrapped above now compute the necessary string storage space prior to allocation, as the low-level C API calls would crash the process irreversibly if they write more memory than which is passed to them. * Changes to C API and wrappers support char** To support the latest SWIG changes that enable proper char** return support that is safe, the C API was changed. The respecive wrappers in R and Python were changed too. * Cleanup indentation in new lightgbm_R.cpp code * Adress review code-style comments. * Update swig/StringArray.hpp Co-Authored-By:Nikita Titov <nekit94-08@mail.ru> * Update python-package/lightgbm/basic.py Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Update src/lightgbm_R.cpp Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
alberto.ferreira <alberto.ferreira@feedzai.com> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
Lukas Pfannschmidt authored
* Add handling of RandomState object, which is standard for sklearn methods. LightGBM expects an integer seed instead of an object. If passed object is RandomState, we choose random integer based on its state to seed the underlying low level code. While chosen random integer is only in the range between 1 and 1e10 I expect it to have enough entropy (?) to not matter in practice. * Add RandomState object to random_state docstring. * remove blank line * Use property to handle setting random_state. This enables setting cloned estimators with the set_params method in sklearn. * Add docstring to attribute. * Fix and simplify docstring. * Add test case. * Use maximal int for datatype in seed derivation. * Replace random_state property with interfacing in fit method. Derives int seed for C code only when fitting and keeps RandomState object as param. * Adapt unit test to property change. * Extended test case and docstring Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Add more equality checks (feature importance, best iteration/score). * Add equality comparison of boosters represented by strings. Remove useless best_iteration_ comparison (we do not use early_stopping). * fix whitespace * Test if two subsequent fits produce different models * Apply suggestions from code review Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 16 Mar, 2020 2 commits
-
-
Guolin Ke authored
* fix * fix return * fix test * fix test * fix predictor is none * Apply suggestions from code review * Update basic.py * Update basic.py * Apply suggestions from code review Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
Guolin Ke authored
* fix the bug when use different params with reference * fix * Update basic.py * Apply suggestions from code review Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Update basic.py * add test * Apply suggestions from code review * added asserts in test Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
StrikerRUS <nekit94-12@hotmail.com>
-
- 06 Mar, 2020 1 commit
-
-
Nikita Titov authored
* save all param values into model file * revert storing predict params * do not save params for predict and convert tasks * fixed test: 10 is found successfully for default 100 * specify more params as no-save
-
- 20 Feb, 2020 1 commit
-
-
Joan Fontanals authored
* Add capability to get possible max and min values for a model * Change implementation to have return value in tree.cpp, change naming to upper and lower bound, move implementation to gdbt.cpp * Update include/LightGBM/c_api.h Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Change iteration to avoid potential overflow, add bindings to R and Python and a basic test * Adjust test values * Consider const correctness and multithreading protection * Update test values * Update test values * Add test to check that model is exactly the same in all platforms * Try to parse the model to get the expected values * Try to parse the model to get the expected values * Fix implementation, num_leaves can be lower than the leaf_value_ size * Do not check for num_leaves to be smaller than actual size and get back to test with hardcoded value * Change test order * Add gpu_use_dp option in test * Remove helper test method * Update src/c_api.cpp Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Update src/io/tree.cpp Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Update src/io/tree.cpp Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Update tests/python_package_test/test_basic.py Co-Authored-By:
Nikita Titov <nekit94-08@mail.ru> * Remoove imports Co-authored-by:
Nikita Titov <nekit94-08@mail.ru>
-
- 19 Feb, 2020 1 commit
-
-
Guolin Ke authored
* reset * fix a bug * fix test * Update c_api.h * support to no filter features by min_data * add warning in reset config * refine warnings for override dataset's parameter * some cleans * clean code * clean code * refine C API function doxygen comments * refined new param description * refined doxygen comments for R API function * removed stuff related to int8 * break long line in warning message * removed tests which results cannot be validated anymore * added test for warnings about unchangeable params * write parameter from dataset to booster * consider free_raw_data. * fix params * fix bug * implementing R * fix typo * filter params in R * fix R * not min_data * refined tests * fixed linting * refine * pilint * add docstring * fix docstring * R lint * updated description for C API function * use param aliases in Python * fixed typo * fixed typo * added more params to test * removed debug print * fix dataset construct place * fix merge bug * Update feature_histogram.hpp * add is_sparse back * remove unused parameters * fix lint * add data random seed * update * [R-package] centrallized Dataset parameter aliases and added tests on Dataset parameter updating (#2767) Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> Co-authored-by:
James Lamb <jaylamb20@gmail.com>
-
- 15 Feb, 2020 1 commit
-
-
Nikita Titov authored
-