- 23 Jun, 2020 1 commit
-
-
Belinda Trotta authored
* Add interaction constraints functionality. * Minor fixes. * Minor fixes. * Change lambda to function. * Fix gpu bug, remove extra blank lines. * Fix gpu bug. * Fix style issues. * Try to fix segfault on MACOS. * Fix bug. * Fix bug. * Fix bugs. * Change parameter format for R. * Fix R style issues. * Change string formatting code. * Change docs to say R package not supported. * Remove R functionality, moving to separate PR. * Keep track of branch features in tree object. * Only track branch features when feature interactions are enabled. * Fix lint error. * Update docs and simplify tests.
-
- 11 Jun, 2020 1 commit
-
-
Nikita Titov authored
-
- 05 Jun, 2020 2 commits
-
-
Nikita Titov authored
-
Nikita Titov authored
This reverts commit 656d2676.
-
- 01 Jun, 2020 1 commit
-
-
James Lamb authored
-
- 25 May, 2020 1 commit
-
-
James Lamb authored
* [R-package] move R source files into R-package * fix linting warning * stuff
-
- 20 May, 2020 1 commit
-
-
Guolin Ke authored
* redir log to python console * fix pylint * Apply suggestions from code review * Update basic.py * Apply suggestions from code review Co-authored-by:
Nikita Titov <nekit94-08@mail.ru> * Update c_api.h * Apply suggestions from code review * Apply suggestions from code review * super-minor: better wording Co-authored-by:
StrikerRUS <nekit94-12@hotmail.com>
-
- 03 May, 2020 1 commit
-
-
Belinda Trotta authored
* Path smoothing * Try to fix issue with gpu version. * Fix failing CI for R package. * Minor fixes. * Minor refactor. * Restore old code to get CI working. * Fix style issues. * Fix ci for R package. * Minor fixes for docs and code style. * Update docs.
-
- 16 Apr, 2020 1 commit
-
-
James Lamb authored
* [ci] Changed use of strcpy to snprintf * fix * fully enable cpplint
-
- 15 Apr, 2020 1 commit
-
-
James Lamb authored
-
- 13 Apr, 2020 1 commit
-
-
Guolin Ke authored
* fix * Apply suggestions from code review Co-authored-by:
-
- 12 Apr, 2020 1 commit
-
-
OMOTO Tsukasa authored
This reverts commit 6b68967d (#2891) and fixes #2979.
-
- 10 Apr, 2020 1 commit
-
-
OMOTO Tsukasa authored
* Support UTF-8 characters in feature name again This commit reverts 0d59859c. Also see: - https://github.com/microsoft/LightGBM/issues/2226 - https://github.com/microsoft/LightGBM/issues/2478 - https://github.com/microsoft/LightGBM/pull/2229 I reproduced the issue and as @kidotaka gave us a great survey in #2226, I don't conclude that the cause is UTF-8, but "an empty string (character)". Therefore, I revert "throw error when meet non ascii (#2229)" whose commit hash is 0d59859c, and add support feture names as UTF-8 again. * add tests * fix check-docs tests * update * fix tests * update .travis.yml * fix tests * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * add a test for R-package * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * fix test for R-package * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * update test_r_package.sh * update * updte * update * remove unneeded comments
-
- 09 Apr, 2020 1 commit
-
-
CharlesAuguste authored
* Add the monotone penalty parameter to the config. * Pass tree in the necessary functions so it can be used in ComputeBestSplitForFeature. * Add monotone penalty. * Added link to the original report. * Add tests. * Fix GPU. * Revert "Pass tree in the necessary functions so it can be used in ComputeBestSplitForFeature." This reverts commit 37757e8e8f3a2c82a604f4af9a926da616660d2e. * Revert "Fix GPU." This reverts commit e49eeee41c883f3c97fd5cdbd53c9288094bffb6. * Added a shared pointer to the tree so the constraints can use it too. * Moved check on monotone penalty to config.cpp. * Python linting. * Use AssertTrue instead of assert_. * Fix penalization in test. * Make GPU deterministic in tests. * Rename tree to tree_ in monotone constraints. * Replaced epsilon by kEplison. * Typo. * Make tree pointer const. * Update src/treelearner/monotone_constraints.hpp Co-Authored-By:
Guolin Ke <guolin.ke@outlook.com> * Update src/treelearner/monotone_constraints.hpp Co-Authored-By:
Charles Auguste <auguste@dubquantdev801.ire.susq.com> Co-authored-by:
-
- 08 Apr, 2020 1 commit
-
-
Guolin Ke authored
* indent and constructor * fix more * fix long Co-authored-by:
-
- 04 Apr, 2020 1 commit
-
-
Nikita Titov authored
-
- 02 Apr, 2020 1 commit
-
-
Alberto Ferreira authored
* [refactor] Cleanup MissingType enum constants * Update tree.cpp Co-authored-by:Alberto Ferreira <alberto.ferreira@feedzai.com>
-
- 24 Mar, 2020 1 commit
-
-
James Lamb authored
* [R-package] started cutting over from custom R-to-C interface to R.h * replaced LGBM_SE with SEXP * fixed error about ocnflicting definitions of length * got linking working * more stuff * eliminated R CMD CHECK note about printing * switched from hard-coded include dir to the one from FindLibR.cmake * cleaned up formatting in FindLibR.cmake * commented-out everything in CI that does not touch R * more changes * trying to get better logs * tried ignoring * added error message to confirm a suspicion * still trying to find R during R CMD CHECK * restore full CI * fixed comment * Update R-package/src/cmake/modules/FindLibR.cmake * changed strategy for finding LIBR_HOME on Windows * Removed 32-bit Windows stuff in FindLibR.cmake * Update R-package/src/cmake/modules/FindLibR.cmake * Update CMakeLists.txt Co-Authored-By:
-
- 23 Mar, 2020 2 commits
-
-
CharlesAuguste authored
* Add util functions. * Added monotone_constraints_method as a parameter. * Add the intermediate constraining method. * Updated tests. * Minor fixes. * Typo. * Linting. * Ran the parameter generator for the doc. * Removed usage of the FeatureMonotone function. * more fixes * Fix. * Remove duplicated code. * Add debug checks. * Typo. * Bug fix. * Disable the use of intermediate monotone constraints and feature sampling at the same time. * Added an alias for monotone constraining method. * Use the right variable to get the number of threads. * Fix DEBUG checks. * Add back check to determine if histogram is splittable. * Added forgotten override keywords. * Perform monotone constraint update only when necessary. * Small refactor of FastLeafConstraints. * Post rebase commit. * Small refactor. * Typo. * Added comment and slightly improved logic of monotone constraints. * Forgot a const. * Vectors that are to be modified need to be pointers. * Rename FastLeafConstraints to IntermediateLeafConstraints to match documentation. * Remove overload of GoUpToFindLeavesToUpdate. * Stop memory leaking. * Fix cpplint issues. * Fix checks. * Fix more cpplint issues. * Refactor config monotone constraints method. * Typos. * Remove useless empty lines. * Add new line to separate includes. * Replace unsigned ind by size_t. * Reduce number of trials in tests to decrease CI time. * Specify monotone constraints better in tests. * Removed outer loop in test of monotone constraints. * Added categorical features to the monotone constraints tests. * Add blank line. * Regenerate parameters automatically. * Speed up ShouldKeepGoingLeftRight. Co-authored-by:
-
James Lamb authored
* [ci] changed sprintf uses to snprintf * checked for encoding issues with snprintf
-
- 22 Mar, 2020 1 commit
-
-
Alberto Ferreira authored
Co-authored-by:
-
- 20 Mar, 2020 1 commit
-
-
Alberto Ferreira authored
* [swig] Fix SWIG methods that return char** with StringArray. + [new] Add StringArray class to manage and manipulate arrays of fixed-length strings: This class is now used to wrap any char** parameters, manage memory and manipulate the strings. Such class is defined at swig/StringArray.hpp and wrapped in StringArray.i. + [API+fix] Wrap LGBM_BoosterGetFeatureNames it resulted in segfault before: Added wrapper LGBM_BoosterGetFeatureNamesSWIG(BoosterHandle) that only receives the booster handle and figures how much memory to allocate for strings and returns a StringArray which can be easily converted to String[]. + [API+safety] For consistency, LGBM_BoosterGetEvalNamesSWIG was wrapped as well: * Refactor to detect any kind of errors and removed all the parameters besides the BoosterHandle (much simpler API to use in Java). * No assumptions are made about the required string space necessary (128 before). * The amount of required string memory is computed internally + [safety] No possibility of undefined behaviour The two methods wrapped above now compute the necessary string storage space prior to allocation, as the low-level C API calls would crash the process irreversibly if they write more memory than which is passed to them. * Changes to C API and wrappers support char** To support the latest SWIG changes that enable proper char** return support that is safe, the C API was changed. The respecive wrappers in R and Python were changed too. * Cleanup indentation in new lightgbm_R.cpp code * Adress review code-style comments. * Update swig/StringArray.hpp Co-Authored-By:
-
- 17 Mar, 2020 1 commit
-
-
Alberto Ferreira authored
* Fix Booster read/write locale dependency * Address review comments * Move LocaleContext.h->locale_context.h Co-authored-by:
-
- 11 Mar, 2020 1 commit
-
-
Nikita Titov authored
* fixed cpplint errors and disable warning only for VS * wrap more pragma warning
-
- 10 Mar, 2020 1 commit
-
-
James Lamb authored
* [R-package] cleaned up formatting in R C/C++ files * reverted some indentation changes * fixed spacing for comments * lightgbm to LightGBM
-
- 08 Mar, 2020 1 commit
-
-
Guolin Ke authored
* commit * fix msvc * fix format
-
- 06 Mar, 2020 3 commits
-
-
Nikita Titov authored
-
Guolin Ke authored
* only one fix * add more * add more
-
Nikita Titov authored
* save all param values into model file * revert storing predict params * do not save params for predict and convert tasks * fixed test: 10 is found successfully for default 100 * specify more params as no-save
-
- 05 Mar, 2020 2 commits
-
-
Guolin Ke authored
* speed up for const hessian * rename template * some refactorings * refine * refine * simplify codes * fix random in feature histogram * code refine * refine * try fix * make gcc happy * remove timer * rollback some changes * more templates * fix a bug * reduce the cost of timer * fix gpu * fix bug * fix gpu
-
James Lamb authored
* [ci] fixed cpplint warnings about braces * removed excess line
-
- 04 Mar, 2020 2 commits
-
-
Guolin Ke authored
-
Nikita Titov authored
* fixed cpplint errors * fixed more cpplint errors
-
- 03 Mar, 2020 2 commits
-
-
James Lamb authored
-
Guolin Ke authored
* speed up for const hessian * rename template * fix clang build * template init * add comment
-
- 02 Mar, 2020 5 commits
-
-
Guolin Ke authored
* refix * fix config * avoid to rely on config
-
Guolin Ke authored
* reduce overhead of get num_threads * add warning * Apply suggestions from code review * Apply suggestions from code review
-
Guolin Ke authored
* speed up multi-val bin subset for bagging * remove the duplicated codes * code refine * some codes refactoring * move `is_constant_hessian` into `TrainingShareStates` * refine * fix bug * fix bug when num_groups_ < 0 * fix gpu * fix gpu bagging * fix gpu bug * typo * Update src/treelearner/serial_tree_learner.h
-
Guolin Ke authored
* don't cache `num_thread`, to avoid change outside * rename * update document * Update docs/Parameters.rst * Update include/LightGBM/config.h * Apply suggestions from code review Co-Authored-By:
-
Nikita Titov authored
-
