1. 30 Apr, 2021 1 commit
  2. 21 Mar, 2021 1 commit
  3. 22 Jan, 2021 1 commit
    • Nikita Titov's avatar
      Move compute and eigen libraries to external_libs folder (#3809) · 6bb6164e
      Nikita Titov authored
      * move all submodules to external_libs folder
      
      * Update .Rbuildignore
      
      * Update MANIFEST.in
      
      * Update .appveyor.yml
      
      * Update CMakeLists.txt
      
      * Update build_r.R
      
      * Update test.sh
      
      * Update setup.py
      
      * Update CMakeLists.txt
      
      * Update test.sh
      
      * Update setup.py
      
      * Update conf.py
      
      * Update MANIFEST.in
      
      * Update LightGBM.vcxproj
      
      * continue
      
      * test
      
      * test
      
      * Update setup.py
      
      * hotfix
      
      * revert CI tests
      6bb6164e
  4. 19 Jan, 2021 1 commit
  5. 18 Jan, 2021 1 commit
    • James Lamb's avatar
      [R-package] enable use of trees with linear models at leaves (fixes #3319) (#3699) · ed651e86
      James Lamb authored
      * [R-package] enable use of trees with linear models at leaves (fixes #3319)
      
      * remove problematic pragmas
      
      * fix tests
      
      * try to fix build scripts
      
      * try fixing pragma check
      
      * more pragma checks
      
      * ok fix pragma stuff for real
      
      * empty commit
      
      * regenerate documentation
      
      * try skipping test
      
      * uncomment CI
      
      * add note on missing value types for R
      
      * add tests on saving and re-loading booster
      ed651e86
  6. 05 Jan, 2021 1 commit
    • Guangyu Zeng's avatar
      [R-package] Add explicit return statement to R functions. (#3703) · 3fd48864
      Guangyu Zeng authored
      * add explicit return statement to functions in callback.R
      
      * add explicit return statement to functions in lgb.Booster.R
      
      * add explicit return statement to functions in lgb.Dataset.R
      
      * add explicit return statement to functions in lgb.Predictor.R
      
      * add explicit return statement to functions in lgb.cv.R
      
      * add explicit return statement to functions in lgb.interprete.R
      
      * add explicit return statement to functions in lgb.plot.importance.R
      
      * add explicit return statement to functions in saveRDS.lgb.Booster.R
      
      * add explicit return statement to functions in utils.R
      
      * add explicit return statement to functions in lgb.plot.interpretation.R
      
      * add explicit return statement to functions in build_r.R
      
      * fix typo
      
      * return(self) -> return(invisible(self))
      
      * fix some inconsistent indention
      
      * fix test failure
      
      * add another return() statement
      
      * fix linting errors
      3fd48864
  7. 08 Dec, 2020 1 commit
    • Alberto Ferreira's avatar
      Fix model locale issue and improve model R/W performance. (#3405) · 792c9303
      Alberto Ferreira authored
      * Fix LightGBM models locale sensitivity and improve R/W performance.
      
      When Java is used, the default C++ locale is broken. This is true for
      Java providers that use the C API or even Python models that require JEP.
      
      This patch solves that issue making the model reads/writes insensitive
      to such settings.
      To achieve it, within the model read/write codebase:
       - C++ streams are imbued with the classic locale
       - Calls to functions that are dependent on the locale are replaced
       - The default locale is not changed!
      
      This approach means:
       - The user's locale is never tampered with, avoiding issues such as
          https://github.com/microsoft/LightGBM/issues/2979 with the previous
          approach https://github.com/microsoft/LightGBM/pull/2891
       - Datasets can still be read according the user's locale
       - The model file has a single format independent of locale
      
      Changes:
       - Add CommonC namespace which provides faster locale-independent versions of Common's methods
       - Model code makes conversions through CommonC
       - Cleanup unused Common methods
       - Performance improvements. Use fast libraries for locale-agnostic conversion:
         - value->string: https://github.com/fmtlib/fmt
         - string->double: https://github.com/lemire/fast_double_parser (10x
            faster double parsing according to their benchmark)
      
      Bugfixes:
       - https://github.com/microsoft/LightGBM/issues/2500
       - https://github.com/microsoft/LightGBM/issues/2890
       - https://github.com/ninia/jep/issues/205
      
       (as it is related to LGBM as well)
      
      * Align CommonC namespace
      
      * Add new external_libs/ to python setup
      
      * Try fast_double_parser fix #1
      
      Testing commit e09e5aad828bcb16bea7ed0ed8322e019112fdbe
      
      If it works it should fix more LGBM builds
      
      * CMake: Attempt to link fmt without explicit PUBLIC tag
      
      * Exclude external_libs from linting
      
      * Add exernal_libs to MANIFEST.in
      
      * Set dynamic linking option for fmt.
      
      * linting issues
      
      * Try to fix lint includes
      
      * Try to pass fPIC with static fmt lib
      
      * Try CMake P_I_C option with fmt library
      
      * [R-package] Add CMake support for R and CRAN
      
      * Cleanup CMakeLists
      
      * Try fmt hack to remove stdout
      
      * Switch to header-only mode
      
      * Add PRIVATE argument to target_link_libraries
      
      * use fmt in header-only mode
      
      * Remove CMakeLists comment
      
      * Change OpenMP to PUBLIC linking in Mac
      
      * Update fmt submodule to 7.1.2
      
      * Use fmt in header-only-mode
      
      * Remove fmt from CMakeLists.txt
      
      * Upgrade fast_double_parser to v0.2.0
      
      * Revert "Add PRIVATE argument to target_link_libraries"
      
      This reverts commit 3dd45dde7b92531b2530ab54522bb843c56227a7.
      
      * Address James Lamb's comments
      
      * Update R-package/.Rbuildignore
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      
      * Upgrade to fast_double_parser v0.3.0 - Solaris support
      
      * Use legacy code only in Solaris
      
      * Fix lint issues
      
      * Fix comment
      
      * Address StrikerRUS's comments (solaris ifdef).
      
      * Change header guards
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      792c9303
  8. 29 Nov, 2020 1 commit
  9. 10 Nov, 2020 1 commit
  10. 25 Aug, 2020 1 commit
  11. 09 Aug, 2020 1 commit
    • James Lamb's avatar
      [ci][R-package][python] suppress warning about empty 'compute' director, fix... · 7be57d77
      James Lamb authored
      
      [ci][R-package][python] suppress warning about empty 'compute' director, fix Rtools installation and temporary pin Sphinx version (#3277)
      
      * [R-package] suppress warning about empty 'compute' directory
      
      * get more logs from Rtools install
      
      * empty commit
      
      * add a timeout
      
      * trying Invoke-WebRequest instead
      
      * switch to CRAN link
      
      * do not use Start-Process
      
      * relative paths
      
      * trying suppressmessageboxes
      
      * switch strategy for running Rtools
      
      * Update requirements_rtd.txt
      
      * Update requirements_base.txt
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      7be57d77
  12. 29 Jul, 2020 1 commit
    • James Lamb's avatar
      [R-package] make package installable with CRAN toolchain (fixes #2960) (#3188) · aa933eb4
      James Lamb authored
      
      
      * [R-package] make package installable with CRAN toolchain (fixes #2960)
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove GPU stuff
      
      * use wildcard to find objects to build
      
      * use -lomp
      
      * build configure before moving files
      
      * using wildcard for objects
      
      * Update .github/workflows/main.yml
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * add explicit objects back
      
      * reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
      
      * fixing things
      
      * pin autoconf version
      
      * show diff
      
      * add automake back
      
      * run less checks
      
      * command was in the wrong place
      
      * fix autoconf version
      
      * change strategy for handling configure
      
      * fix Rbuildignore
      
      * fix NOTEs
      
      * fix notes about unrecognized files
      
      * fixing extra files
      
      * remove USE_R35
      
      * add OpenMP check for Mac CRAN build
      
      * run all checks
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * suggestions from code review
      
      * undo indenting
      
      * remove 03 from Makevars.win.in
      
      * update language about OpenMP in configure script
      
      * checking if configure.ac check works
      
      * add autoconf back
      
      * remove testing code in configure.ac
      
      * more fixes for CI on configure script
      
      * print git diff
      
      * add VERSION.txt when checking configure
      
      * fix relative paths
      
      * remove git diff
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      aa933eb4
  13. 14 Jun, 2020 1 commit
    • James Lamb's avatar
      [R-package] Add support for R 4.0 (fixes #3064, fixes #3024) (#3065) · e83042f2
      James Lamb authored
      
      
      * [R-package] replaced gendef.exe with R code to create R.def (fixes #3064)
      
      * fix broken things
      
      * trying to add R4.0 docs
      
      * changed make
      
      * fixing make paths
      
      * update notes on environment variables
      
      * fix linting
      
      * fixes to CI
      
      * fixing build_cmd and other stuff
      
      * fix bad substitution
      
      * fix Azure Linux builds
      
      * I am bad at bash
      
      * simplifying
      
      * only testing R
      
      * getting better logs
      
      * mingw32
      
      * docs
      
      * toolchain
      
      * using msys
      
      * fix visual studio condition
      
      * toolchain test
      
      * full CI
      
      * fix if-elses
      
      * bump allowed NOTEs
      
      * search for Rscript
      
      * updates to docs
      
      * use processx
      
      * fix mismatched arguments
      
      * move CI to GitHub Actions
      
      * minor changes
      
      * fix workflow file
      
      * fix templating
      
      * fix Azure DevOps
      
      * debugging windows builds
      
      * dont shQuote file name
      
      * all GitHub Actions jobs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * minor cleanup
      
      * remove objdump printing
      
      * make file.remove() invisible
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * reduce duplicated paths in docs
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      e83042f2
  14. 25 May, 2020 1 commit
  15. 14 May, 2020 2 commits
  16. 31 Mar, 2020 1 commit
  17. 15 Dec, 2019 1 commit
  18. 16 Nov, 2019 1 commit
    • James Lamb's avatar
      [R-package][ci] Added more R linters (fixes #2477) (#2533) · 1f7b06b9
      James Lamb authored
      
      
      * Added more linters on R code
      
      * started working on implicit integers
      
      * finished style changes to handle implicit integers
      
      * regenned documentation and added concatenation linter
      
      * changed channel for r-lintr
      
      * try building stringi before lintr
      
      * trying to get libicui18n
      
      * trying another thing
      
      * trying conda-forge again
      
      * added re-install of stringi
      
      * uncommented other stages
      
      * Update .ci/test.sh
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed apt update and changed lintr version floor
      
      * get lintr from CRAN
      
      * R needs to come before C++ linting
      
      * testing lintr install from CRAN
      
      * trying one more thing
      
      * more verbose
      
      * order might matter
      
      * removed commented code
      
      * cleaned up linting block in test.sh
      
      * grouped conda install calls and fixed a few integer array things
      1f7b06b9
  19. 01 Sep, 2019 1 commit
    • Nikita Titov's avatar
      [docs][R] added R-package docs generation routines (#2176) · faba6caf
      Nikita Titov authored
      * added R-package docs generation routines
      
      * change theme to be more consistent with sphinx_rtd_theme on main site in terms of color scheme
      
      * placed man folder with old Rd files back
      
      * specify full path to conda and make script more readable by one line - one pkg
      
      * removed commented lines from build_r_site script
      
      * made one line - one argument in build_reference() call
      
      * pin R package versions
      
      * fixed conflict
      faba6caf
  20. 19 Aug, 2019 1 commit
  21. 08 May, 2019 1 commit
  22. 24 Dec, 2018 1 commit
  23. 23 Nov, 2018 1 commit
  24. 30 Sep, 2018 1 commit
  25. 23 Sep, 2018 2 commits
  26. 02 Sep, 2018 1 commit
  27. 29 Aug, 2018 1 commit
    • James Lamb's avatar
      [R-package] CRAN fixes (#1499) · eded794e
      James Lamb authored
      * Fixed typos in docs
      
      * Fixed inconsistencies in documentation
      
      * Updated strategy for registering routines
      
      * Fixed issues caused by smashing multiple functions into one Rd
      
      * Fixed issues with documentation
      
      * Removed VignetteBuilder and updated Rbuildignore
      
      * Added R build artefacts to gitignore
      
      * Added namespacing on data.table set function. Updated handling of CMakeLists file to get around CRAN check.
      
      * Updated build instructions
      
      * Added R build script
      
      * Removed build_r.sh script and updated R-package install instructions
      eded794e