- 21 Mar, 2021 1 commit
-
-
Nikita Titov authored
-
- 22 Jan, 2021 1 commit
-
-
Nikita Titov authored
* move all submodules to external_libs folder * Update .Rbuildignore * Update MANIFEST.in * Update .appveyor.yml * Update CMakeLists.txt * Update build_r.R * Update test.sh * Update setup.py * Update CMakeLists.txt * Update test.sh * Update setup.py * Update conf.py * Update MANIFEST.in * Update LightGBM.vcxproj * continue * test * test * Update setup.py * hotfix * revert CI tests
-
- 18 Jan, 2021 1 commit
-
-
James Lamb authored
* [R-package] enable use of trees with linear models at leaves (fixes #3319) * remove problematic pragmas * fix tests * try to fix build scripts * try fixing pragma check * more pragma checks * ok fix pragma stuff for real * empty commit * regenerate documentation * try skipping test * uncomment CI * add note on missing value types for R * add tests on saving and re-loading booster
-
- 08 Dec, 2020 1 commit
-
-
Alberto Ferreira authored
* Fix LightGBM models locale sensitivity and improve R/W performance. When Java is used, the default C++ locale is broken. This is true for Java providers that use the C API or even Python models that require JEP. This patch solves that issue making the model reads/writes insensitive to such settings. To achieve it, within the model read/write codebase: - C++ streams are imbued with the classic locale - Calls to functions that are dependent on the locale are replaced - The default locale is not changed! This approach means: - The user's locale is never tampered with, avoiding issues such as https://github.com/microsoft/LightGBM/issues/2979 with the previous approach https://github.com/microsoft/LightGBM/pull/2891 - Datasets can still be read according the user's locale - The model file has a single format independent of locale Changes: - Add CommonC namespace which provides faster locale-independent versions of Common's methods - Model code makes conversions through CommonC - Cleanup unused Common methods - Performance improvements. Use fast libraries for locale-agnostic conversion: - value->string: https://github.com/fmtlib/fmt - string->double: https://github.com/lemire/fast_double_parser (10x faster double parsing according to their benchmark) Bugfixes: - https://github.com/microsoft/LightGBM/issues/2500 - https://github.com/microsoft/LightGBM/issues/2890 - https://github.com/ninia/jep/issues/205 (as it is related to LGBM as well) * Align CommonC namespace * Add new external_libs/ to python setup * Try fast_double_parser fix #1 Testing commit e09e5aad828bcb16bea7ed0ed8322e019112fdbe If it works it should fix more LGBM builds * CMake: Attempt to link fmt without explicit PUBLIC tag * Exclude external_libs from linting * Add exernal_libs to MANIFEST.in * Set dynamic linking option for fmt. * linting issues * Try to fix lint includes * Try to pass fPIC with static fmt lib * Try CMake P_I_C option with fmt library * [R-package] Add CMake support for R and CRAN * Cleanup CMakeLists * Try fmt hack to remove stdout * Switch to header-only mode * Add PRIVATE argument to target_link_libraries * use fmt in header-only mode * Remove CMakeLists comment * Change OpenMP to PUBLIC linking in Mac * Update fmt submodule to 7.1.2 * Use fmt in header-only-mode * Remove fmt from CMakeLists.txt * Upgrade fast_double_parser to v0.2.0 * Revert "Add PRIVATE argument to target_link_libraries" This reverts commit 3dd45dde7b92531b2530ab54522bb843c56227a7. * Address James Lamb's comments * Update R-package/.Rbuildignore Co-authored-by:James Lamb <jaylamb20@gmail.com> * Upgrade to fast_double_parser v0.3.0 - Solaris support * Use legacy code only in Solaris * Fix lint issues * Fix comment * Address StrikerRUS's comments (solaris ifdef). * Change header guards Co-authored-by:
-
- 21 Nov, 2020 1 commit
-
-
James Lamb authored
* [R-package] Remove CLI-only objects * more guards * more guards * variable not string * simplify fix * revert build_r.R changes * move define of global_timer Co-authored-by:Nikita Titov <nekit94-08@mail.ru>
-
- 16 Oct, 2020 1 commit
-
-
Josh Maxwell authored
* Modified script to also remove pragma warnings. This also includes modifying the scope of the pragma removal. Previously this script only searched inside the ./src/include/LightGMB directory. This was not inclusive enough to remove the warnings in files shown in the ticket. * Adds CI test that exits if unknown pragma warnings are present. * Expanding pragma removal to cpp and hpp files. * Update .ci/test_r_package.sh Removing unneeded conditions since this script will only run on Linux and Mac builds anyway. Co-authored-by:
-
- 25 Aug, 2020 1 commit
-
-
James Lamb authored
* [R-package] [ci] Reduce manual effort for version updates * fix configure * remove useless comment * Update build_r.R Co-authored-by:
Guolin Ke <guolin.ke@outlook.com> * fix recreate-configure check in CI Co-authored-by:
-
- 13 Aug, 2020 1 commit
-
-
James Lamb authored
* [R-package] DESCRIPTION changes to address CRAN feedback * CRAN likes single quotes * the regex rules for Rbuildignore are weird * ugh Rbuildignore * how does this wooork * just remove cran-comments.md in script * adding Biarch back * Update R-package/cran-comments.md Co-authored-by:
-
- 07 Aug, 2020 1 commit
-
-
Guolin Ke authored
* Update VERSION.txt * Update VERSION.txt * Update setup.py * Update VERSION.txt * Update setup.py * Update VERSION.txt * Update .appveyor.yml * Update DESCRIPTION * Apply suggestions from code review * Apply suggestions from code review * Update DESCRIPTION * Apply suggestions from code review * Create VERSION.txt * Apply suggestions from code review * Update .gitignore * Update recreate-configure.sh * Update test_r_package.sh * Update build-cran-package.sh * Delete VERSION.txt * Create VERSION.txt * Update main.yml * Update test_r_package_windows.ps1 * Update configure * Update test_r_package_windows.ps1 * Update test_r_package.sh * Delete VERSION.txt * Apply suggestions from code review * update configure.ac Co-authored-by:
-
- 29 Jul, 2020 1 commit
-
-
James Lamb authored
* [R-package] make package installable with CRAN toolchain (fixes #2960) * Apply suggestions from code review Co-authored-by:
-
