Commits · a592316a00001bc07e4f085cff8d522c0df15150 · tianlh / LightGBM-DCU

15 Jun, 2021 1 commit

[ci] [R-package] add unit tests on monotone constraints (#4352) · a592316a

James Lamb authored Jun 15, 2021

* [R-package] add unit tests on monotone constraints

* testing without skip()

* put skip() back

* make tests consistent with Python

* Update R-package/tests/testthat/test_basic.R

* more changes for consistency with Python tests

a592316a

13 Jun, 2021 1 commit

[R-package] move more finalizer logic into C++ side to address memory leaks (#4353) · 53ffba7c

James Lamb authored Jun 13, 2021



* [R-package] move more finalizer logic intoo C++ side

* add C finalizers

* use gc()

* put skip() back

* Update R-package/tests/testthat/test_lgb.Booster.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

53ffba7c

12 Jun, 2021 1 commit
- [R-package] avoid unnecessary computation of std deviations in `lgb.cv()` (#4360) · f0bca1a2
  James Lamb authored Jun 12, 2021
```
* [R-package] avoid unnecessary computation of std deviations in lgb.cv()

* use expect_equal()
```
  f0bca1a2
09 Jun, 2021 1 commit
- [R-package] remove defaults in internal functions (#4361) · a8fae81f
  James Lamb authored Jun 09, 2021
  
  a8fae81f
08 Jun, 2021 1 commit
- [R-package] remove unnecessary library() calls in tests (#4354) · 063e7317
  James Lamb authored Jun 08, 2021
  
  063e7317
06 Jun, 2021 1 commit
- [R-package] resolve test warning about is.na() and handles (#4341) · 20e63387
  James Lamb authored Jun 06, 2021
  
  20e63387
05 Jun, 2021 3 commits
- [R-package] factor out lgb.check.r6.class() (#4343) · 4ccf92be
  James Lamb authored Jun 05, 2021
```
* [R-package] factor out lgb.check.r6.class()

* Predictor
```
  4ccf92be
- [R-package] remove lgb.last_error() and LGBM_GetLastError_R() (#4344) · 441f38bb
  James Lamb authored Jun 05, 2021
  
  441f38bb
- [R-package] remove unused argument in early stopping callback (#4342) · 3837e60d
  James Lamb authored Jun 05, 2021
  
  3837e60d
04 Jun, 2021 2 commits
- [R-package] remove uses of ... in Predictor constructor (#4338) · c45a82f0
  James Lamb authored Jun 04, 2021
  
  c45a82f0
- [R-package] remove unused code in lgb.params2str() (#4337) · 2b485ce5
  James Lamb authored Jun 04, 2021
  
  2b485ce5
21 May, 2021 1 commit

fix calculation of weighted gamma loss (fixes #4174) (#4283) · 4b1b4124

Michael Mayer authored May 21, 2021

* fixed weighted gamma obj

* added unit tests

* fixing linter errors

* another linter

* set seed

* fix linter (integer seed)

4b1b4124

15 May, 2021 1 commit

[R-package] Handle integer types more accurate in R-to-C interface (#4291) · 90677e43

Nikita Titov authored May 15, 2021

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* fix typos

90677e43

12 May, 2021 1 commit

[R-package] manage Dataset and Booster handles as R external pointers (fixes #3016) (#4265) · 676c95fb

James Lamb authored May 12, 2021



* started converting handles

* more changes

* sort of working for Dataset

* yay all the tests are passing for Dataset handle changes

* working for other handle types

* remove debugging logging

* remove unnecessary spaces

* fix null logic

* more NULL

* updates

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* consolidate steps
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

676c95fb

10 May, 2021 1 commit
- [docs] remove extra spaces in comments and docs (#4269) · a8ee487a
  James Lamb authored May 10, 2021
  
  a8ee487a
09 May, 2021 1 commit

[R-package] move creation of character vectors in some methods to C++ side (#4256) · c1d2dbe2

James Lamb authored May 09, 2021



* [R-package] move creation of character vectors in some methods to C++ side

* convert LGBM_BoosterGetEvalNames_R

* convert LGBM_BoosterDumpModel_R and LGBM_BoosterSaveModelToString_R

* remove debugging code

* update docs

* remove comment

* add handling for larger model strings

* handle large strings in feature and eval names

* got long feature names working

* more fixes

* linting

* resize

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* stricter test
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

c1d2dbe2

06 May, 2021 1 commit

[docs][R-package] update docs on C++ interface (#4257) · 02467213

James Lamb authored May 06, 2021



* [R-package] update docs on C++ interface

* Update R-package/src/lightgbm_R.h
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/src/lightgbm_R.h
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* add missing start_iteration doc
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

02467213

04 May, 2021 1 commit
- [R-package] Use R standard routines to access character data in C++ (#4252) · ec874325
  James Lamb authored May 04, 2021
```
* converted LGBM_BoosterSaveModel_R

* switch all other non-params cases

* handle params
```
  ec874325
03 May, 2021 2 commits

[R-package] Use R standard routines to access numeric and integer array data in C++ (#4247) · bb88d92e
James Lamb authored May 03, 2021
```
* real pointer for matrix

* remove R_REAL_PTR

* remove R_INT_PTR

* add test
```
bb88d92e

[R-package] use R standard routine to access read-only ints passed to C++ (#4246) · aedfdd0d

James Lamb authored May 03, 2021



* [R-package] replace R_AS_INT with R built-in

* update header

* more changes

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

aedfdd0d

02 May, 2021 2 commits
- [R-package] move Rinternals.h closer to where it is used (#4248) · d29f2c2a
  James Lamb authored May 02, 2021
  
  d29f2c2a
- [R-package] Convert LGBM_GetLastError_R to use R built-in types (#4242) · 66ee2919
  James Lamb authored May 02, 2021
```
* [R-package] move some functions over to SEXP objects

* clarify comment

* remove paste0()

* fix registration table

* fix cmake builds
```
  66ee2919
01 May, 2021 1 commit
- [R-package] remove pre-allocated call_state in C++ calls (#4244) · 26cde5f5
  James Lamb authored May 01, 2021
  
  26cde5f5
30 Apr, 2021 1 commit

[R-package] prevent symbol lookup conflicts (fixes #4045) (#4155) · b27dcfa4

James Lamb authored Apr 30, 2021

* [R-package] prevent symbol lookup conflicts

* add unit tests

* only run test on Windows

* move to .Call() calls

* fix references

* testing registration for CMake builds

* revert NAMESPACE changes

* revert testing changes

b27dcfa4

28 Apr, 2021 1 commit
- [R-package] avoid misleading warnings when using interaction constraints (fixes #4108) (#4232) · fa6d3565
  James Lamb authored Apr 28, 2021
  
  fa6d3565
26 Apr, 2021 1 commit
- [R-package] fix warnings in unit tests (#4225) · 5014f19f
  James Lamb authored Apr 26, 2021
  
  5014f19f
22 Apr, 2021 2 commits
- [R-package] Move error handling into C++ side (#4163) · 1e95cb09
  James Lamb authored Apr 21, 2021
```
* [R-package] raise errors from C++ side

* working but a lot of warnings

* more changes

* simplify

* cleanup

* linting

* fix valgrind issues

* revert unnecessary change
```
  1e95cb09
- [R-package] fix grammar in comments · 13d0ceee
  david-cortes authored Apr 22, 2021
  
  13d0ceee
20 Apr, 2021 1 commit
- [ci] parallelize R package installs in CI jobs (#4198) · 72d7010b
  James Lamb authored Apr 20, 2021
```
* [ci] parallelize R package installs in CI jobs

* build 2

* build 3

* add ncpus in static_analysis
```
  72d7010b
19 Apr, 2021 3 commits

[R-package] clarify parameter documentation (fixes #4193) (#4202) · 53602afa
James Lamb authored Apr 19, 2021
```
* [R-package] clarify parameter documentation

* fixes to braces

* linting
```
53602afa

[R-package] change default nrounds to 100 to match LightGBM core library default (#4197) · c109a595

david-cortes authored Apr 19, 2021



* use same default arguments as python

* Update R-package/R/lgb.cv.R

Changed.
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* revert change in docs
Co-authored-by: James Lamb <jaylamb20@gmail.com>

c109a595

[docs][R-package] Update the explanation of num_threads (fixes #4192) (#4199) · e12409fd

Issac Lee authored Apr 19, 2021

* update the explanation of num_threads in lightgbm.R

* adjusted sentences for linting.

* remove white space for lintr pass

* add note about num_thread param in files

e12409fd

18 Apr, 2021 2 commits

[R-package] Make returned feature importances from lgb.importance() visible by default (#4194) · 69d02e38

david-cortes authored Apr 19, 2021



* Return feature importances as visible

Feature importances are returned as invisible. I don't get why would anyone want them invisible. This PR fixes it.

* Update R-package/R/lgb.importance.R

Thanks, didn't realize that, changed now.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

69d02e38

[docs] add working dir to R package docker run examples (#4190) · 7ea2bc4d
James Lamb authored Apr 17, 2021

7ea2bc4d

12 Apr, 2021 3 commits

[ci] Bump version for development (#4171) · b8a6f809

Nikita Titov authored Apr 13, 2021



* Bump version for development

* Auto-update configure
Co-authored-by: GitHub Actions Bot <githubactionsbot@users.noreply.github.com>

b8a6f809

v3.2.1 release (#4169) · b8e38ec1

James Lamb authored Apr 12, 2021



* v3.2.1 release

* Auto-update configure
Co-authored-by: GitHub Actions Bot <githubactionsbot@users.noreply.github.com>

b8e38ec1

[ci] Add debian-clang-devel CI job for the R package (#4164) · 5a678f6a

James Lamb authored Apr 11, 2021



* [ci] Add debian-clang-devel CI job for the R package

* [ci] Add debian-clang-devel CI job for the R package

* fixes

* fix test

* update cran-comments

* re-trigger CI

* catch warnings and notes

* fail with only a NOTE

* uncomment CI code

* remove env vars in windows tests

* Update R-package/cran-comments.md
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

5a678f6a

31 Mar, 2021 1 commit

[ci] use GitHub Actions to re-generate R configure (#4140) · 9388b2ec

Nikita Titov authored Mar 31, 2021



* use GitHub Actions to re-generate R configure

* Update R-package/README.md
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

9388b2ec

27 Mar, 2021 1 commit
- [ci] build CRAN R-package on Azure with every commit and attach it to releases (#4117) · 69779e6a
  Nikita Titov authored Mar 27, 2021
```
* build CRAN R-package on Azure with every commit and attach to releases

* test CI

* fix path

* revert CI test
```
  69779e6a
25 Mar, 2021 1 commit
- [R-package] fix typo in linear learner test (#4109) · 65349b41
  James Lamb authored Mar 25, 2021
  
  65349b41