Skip to content

GitLab

Switch branch/tag
  1. 16 Feb, 2021 4 commits
  3. 15 Feb, 2021 17 commits
  5. 14 Feb, 2021 4 commits
  7. 13 Feb, 2021 3 commits
    • Belinda Trotta's avatar
      [docs] Update docs about linear tree and monotone constraints (#3945) · 50e061f3
      Belinda Trotta authored 
      * Update docs about linear tree and monotone constraints

* Fix punctuation
      50e061f3
    • Benjamin Sergeant's avatar
      openmp_wrapper.h stubs signature use __GOMP_NOTHROW (#3923) · 89da9902
      Benjamin Sergeant authored 
      

* openmp_wrapper.h stubs signature use __GOMP_NOTHROW

Fix #3915. OpenMP stubs do not use the noexcept attibute which is present in the gcc version of openmp, and which trigger compilation errors as seen below. dmlc-core uses the same technique and macro.

/usr/lib/gcc/x86_64-linux-gnu/9/include/omp.h:114:12: error: declaration of ‘int omp_get_thread_num() noexcept’ has a different exception specifier
  114 | extern int omp_get_thread_num (void) __GOMP_NOTHROW;
      |            ^~~~~~~~~~~~~~~~~~
...
xxx/include/LightGBM/utils/openmp_wrapper.h:81:14: note: from previous declaration ‘int omp_get_thread_num()’
   81 |   inline int omp_get_thread_num() {return 0;}
      |              ^~~~~~~~~~~~~~~~~~

* move __GOMP_NOTHROW definition in the no open mp stub conditional branch

* Update include/LightGBM/utils/openmp_wrapper.h

Yes make sense, just changed it
Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>

* add NOLINT macro to disable cpplint on a safe line of code
Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      89da9902
    • mjmckp's avatar
      Fix access violation exception that can occur during invocation of loop lambda... · 5abf8bb9
      mjmckp authored 
      
Fix access violation exception that can occur during invocation of loop lambda function when inner_start >= inner_end in 'For' template (#3936)

* Fix index out-of-range exception generated by BaggingHelper on small datasets.

Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero.

* Update goss.hpp

* Update goss.hpp

* Add API method LGBM_BoosterPredictForMats which runs prediction on a data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array)

* Fix incorrect upstream merge

* Add link to LightGBM.NET

* Fix indenting to 2 spaces

* Dummy edit to trigger CI

* Dummy edit to trigger CI

* remove duplicate functions from merge

* Fix access violation exception that can occur during invocation of loop lambda function when inner_start >= inner_end in 'For' template.

In particular, this can occur in Tree::AddPredictionToScore on line 291 where the loop lambda function body (created by the PredictionFun macro) dereferences used_data_indices[start].

For reference, the particular case which triggered this exception in my case was:
  * start = 0
  * end = 93,203
  * n_block = 56
  * min_block_size = 512
for which the BlockInfo method gave:
  * n_block = 56
  * num_inner = 1,696
and so, for the case i=55 (i.e., the last case in the loop), we get
  * inner_start = start + num_inner * i
                = 93,280
which is greater than 'end' and hence triggers the exception.

* Change formatting of proposed modification
Co-authored-by: default avatarmatthew-peacock <matthew.peacock@whiteoakam.com>
Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      5abf8bb9
  9. 10 Feb, 2021 2 commits
  11. 09 Feb, 2021 5 commits
  13. 08 Feb, 2021 2 commits
  15. 07 Feb, 2021 3 commits