1. 08 Apr, 2020 2 commits
  2. 07 Apr, 2020 2 commits
  3. 05 Apr, 2020 1 commit
  4. 04 Apr, 2020 2 commits
  5. 03 Apr, 2020 1 commit
  6. 02 Apr, 2020 1 commit
  7. 01 Apr, 2020 3 commits
  8. 31 Mar, 2020 1 commit
  9. 30 Mar, 2020 2 commits
  10. 28 Mar, 2020 1 commit
  11. 25 Mar, 2020 1 commit
  12. 24 Mar, 2020 1 commit
    • James Lamb's avatar
      [R-package] Use Rprintf for logging in the R package (fixes #1440, fixes #1909) (#2901) · 0341906c
      James Lamb authored
      
      
      * [R-package] started cutting over from custom R-to-C interface to R.h
      
      * replaced LGBM_SE with SEXP
      
      * fixed error about ocnflicting definitions of length
      
      * got linking working
      
      * more stuff
      
      * eliminated R CMD CHECK note about printing
      
      * switched from hard-coded include dir to the one from FindLibR.cmake
      
      * cleaned up formatting in FindLibR.cmake
      
      * commented-out everything in CI that does not touch R
      
      * more changes
      
      * trying to get better logs
      
      * tried ignoring
      
      * added error message to confirm a suspicion
      
      * still trying to find R during R CMD CHECK
      
      * restore full CI
      
      * fixed comment
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * changed strategy for finding LIBR_HOME on Windows
      
      * Removed 32-bit Windows stuff in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed some duplication in cmake scripts
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * added LIBR_CORE_LIBRARY back
      
      * small fixes to CMakeLists
      
      * simplified FindLibR.cmake
      
      * some fixes for windows
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * allowed for directly passing LIBR_EXECUTABLE to FindLibR.cmake
      
      * reorganized FindLibR.cmake to catch more cases
      
      * clean up inconsistencies  in R calls in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed unnecessary log messages
      
      * removed unnecessary unset() call
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      0341906c
  13. 23 Mar, 2020 2 commits
    • CharlesAuguste's avatar
      Improving monotone constraints ("Fast" method; linked to #2305, #2717) (#2770) · a8c1e0a1
      CharlesAuguste authored
      
      
      * Add util functions.
      
      * Added monotone_constraints_method as a parameter.
      
      * Add the intermediate constraining method.
      
      * Updated tests.
      
      * Minor fixes.
      
      * Typo.
      
      * Linting.
      
      * Ran the parameter generator for the doc.
      
      * Removed usage of the FeatureMonotone function.
      
      * more fixes
      
      * Fix.
      
      * Remove duplicated code.
      
      * Add debug checks.
      
      * Typo.
      
      * Bug fix.
      
      * Disable the use of intermediate monotone constraints and feature sampling at the same time.
      
      * Added an alias for monotone constraining method.
      
      * Use the right variable to get the number of threads.
      
      * Fix DEBUG checks.
      
      * Add back check to determine if histogram is splittable.
      
      * Added forgotten override keywords.
      
      * Perform monotone constraint update only when necessary.
      
      * Small refactor of FastLeafConstraints.
      
      * Post rebase commit.
      
      * Small refactor.
      
      * Typo.
      
      * Added comment and slightly improved logic of monotone constraints.
      
      * Forgot a const.
      
      * Vectors that are to be modified need to be pointers.
      
      * Rename FastLeafConstraints to IntermediateLeafConstraints to match documentation.
      
      * Remove overload of GoUpToFindLeavesToUpdate.
      
      * Stop memory leaking.
      
      * Fix cpplint issues.
      
      * Fix checks.
      
      * Fix more cpplint issues.
      
      * Refactor config monotone constraints method.
      
      * Typos.
      
      * Remove useless empty lines.
      
      * Add new line to separate includes.
      
      * Replace unsigned ind by size_t.
      
      * Reduce number of trials in tests to decrease CI time.
      
      * Specify monotone constraints better in tests.
      
      * Removed outer loop in test of monotone constraints.
      
      * Added categorical features to the monotone constraints tests.
      
      * Add blank line.
      
      * Regenerate parameters automatically.
      
      * Speed up ShouldKeepGoingLeftRight.
      Co-authored-by: default avatarCharles Auguste <auguste@dubquantdev801.ire.susq.com>
      Co-authored-by: default avatarguolinke <guolin.ke@outlook.com>
      a8c1e0a1
    • James Lamb's avatar
      changed sprintf uses to snprintf (#2920) · 3a335e9d
      James Lamb authored
      * [ci] changed sprintf uses to snprintf
      
      * checked for encoding issues with snprintf
      3a335e9d
  14. 22 Mar, 2020 3 commits
  15. 21 Mar, 2020 3 commits
  16. 20 Mar, 2020 3 commits
    • James Lamb's avatar
    • Alberto Ferreira's avatar
      Fix SWIG methods that return char** (#2850) · 91185c3a
      Alberto Ferreira authored
      
      
      * [swig] Fix SWIG methods that return char** with StringArray.
      
      + [new] Add StringArray class to manage and manipulate arrays of fixed-length strings:
      
        This class is now used to wrap any char** parameters, manage memory and
        manipulate the strings.
      
        Such class is defined at swig/StringArray.hpp and wrapped in StringArray.i.
      
      + [API+fix] Wrap LGBM_BoosterGetFeatureNames it resulted in segfault before:
      
        Added wrapper LGBM_BoosterGetFeatureNamesSWIG(BoosterHandle) that
        only receives the booster handle and figures how much memory to allocate
        for strings and returns a StringArray which can be easily converted to String[].
      
      + [API+safety] For consistency, LGBM_BoosterGetEvalNamesSWIG was wrapped as well:
      
        * Refactor to detect any kind of errors and removed all the parameters
          besides the BoosterHandle (much simpler API to use in Java).
        * No assumptions are made about the required string space necessary (128 before).
        * The amount of required string memory is computed internally
      
      + [safety] No possibility of undefined behaviour
      
        The two methods wrapped above now compute the necessary string storage space
        prior to allocation, as the low-level C API calls would crash the process
        irreversibly if they write more memory than which is passed to them.
      
      * Changes to C API and wrappers support char**
      
      To support the latest SWIG changes that enable proper char**
      return support that is safe, the C API was changed.
      
      The respecive wrappers in R and Python were changed too.
      
      * Cleanup indentation in new lightgbm_R.cpp code
      
      * Adress review code-style comments.
      
      * Update swig/StringArray.hpp
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update python-package/lightgbm/basic.py
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update src/lightgbm_R.cpp
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avataralberto.ferreira <alberto.ferreira@feedzai.com>
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      91185c3a
    • Lukas Pfannschmidt's avatar
      [python] handle RandomState object in Scikit-learn Api (#2904) · cf0a992e
      Lukas Pfannschmidt authored
      
      
      * Add handling of RandomState object, which is standard for sklearn methods.
      
      LightGBM expects an integer seed instead of an object.
      If passed object is RandomState, we choose random integer based on its state to seed the underlying low level code.
      While chosen random integer is only in the range between 1 and 1e10 I expect it to have enough entropy (?) to not matter in practice.
      
      * Add RandomState object to random_state docstring.
      
      * remove blank line
      
      * Use property to handle setting random_state.
      This enables setting cloned estimators with the set_params method in sklearn.
      
      * Add docstring to attribute.
      
      * Fix and simplify docstring.
      
      * Add test case.
      
      * Use maximal int for datatype in seed derivation.
      
      * Replace random_state property with interfacing in fit method.
      Derives int seed for C code only when fitting and keeps RandomState object as param.
      
      * Adapt unit test to property change.
      
      * Extended test case and docstring
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Add more equality checks (feature importance, best iteration/score).
      
      * Add equality comparison of boosters represented by strings.
      Remove useless best_iteration_ comparison (we do not use early_stopping).
      
      * fix whitespace
      
      * Test if two subsequent fits produce different models
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      cf0a992e
  17. 19 Mar, 2020 1 commit
  18. 17 Mar, 2020 2 commits
  19. 16 Mar, 2020 4 commits
  20. 15 Mar, 2020 1 commit
  21. 14 Mar, 2020 2 commits
  22. 12 Mar, 2020 1 commit