1. 18 Apr, 2021 1 commit
  2. 31 Mar, 2021 1 commit
  3. 27 Mar, 2021 1 commit
  4. 19 Mar, 2021 1 commit
  5. 08 Feb, 2021 1 commit
  6. 07 Feb, 2021 1 commit
    • Nikita Titov's avatar
      [ci][R-package] run R CRAN checks on Solaris by optional workflow (#3913) · ffebc43f
      Nikita Titov authored
      * run R CRAN checks on Solaris by optional workflow
      
      * Update triggering_comments.yml
      
      * Update r_solaris.yml
      
      * Update optional_checks.yml
      
      * Update triggering_comments.yml
      
      * Update run_rhub_solaris_checks.R
      
      * Update r_solaris.yml
      
      * Update run_rhub_solaris_checks.R
      
      * Update r_solaris.yml
      
      * simplify code
      
      * fix lint and address review comments
      ffebc43f
  7. 19 Jan, 2021 1 commit
  8. 13 Jan, 2021 1 commit
    • Nikita Titov's avatar
      [ci] improve experience with optional GitHub workflows (#3740) · f997a069
      Nikita Titov authored
      * improve experience with optional GitHub workflows
      
      * Update README.md
      
      * Update r_artifacts.yml
      
      * Update optional_checks.yml
      
      * continue
      
      * Update triggering_comments.yml
      
      * Update README.md
      
      * Update r_artifacts.yml
      
      * Update r_artifacts.yml
      
      * Update r_artifacts.yml
      
      * Update r_valgrind.yml
      
      * Update r_artifacts.yml
      
      * Update r_valgrind.yml
      
      * Update r_valgrind.yml
      
      * Update r_valgrind.yml
      
      * add docstrings to fix lint
      
      * better formatting for multi-line commands
      f997a069
  9. 04 Jan, 2021 2 commits
  10. 08 Dec, 2020 1 commit
    • Alberto Ferreira's avatar
      Fix model locale issue and improve model R/W performance. (#3405) · 792c9303
      Alberto Ferreira authored
      * Fix LightGBM models locale sensitivity and improve R/W performance.
      
      When Java is used, the default C++ locale is broken. This is true for
      Java providers that use the C API or even Python models that require JEP.
      
      This patch solves that issue making the model reads/writes insensitive
      to such settings.
      To achieve it, within the model read/write codebase:
       - C++ streams are imbued with the classic locale
       - Calls to functions that are dependent on the locale are replaced
       - The default locale is not changed!
      
      This approach means:
       - The user's locale is never tampered with, avoiding issues such as
          https://github.com/microsoft/LightGBM/issues/2979 with the previous
          approach https://github.com/microsoft/LightGBM/pull/2891
       - Datasets can still be read according the user's locale
       - The model file has a single format independent of locale
      
      Changes:
       - Add CommonC namespace which provides faster locale-independent versions of Common's methods
       - Model code makes conversions through CommonC
       - Cleanup unused Common methods
       - Performance improvements. Use fast libraries for locale-agnostic conversion:
         - value->string: https://github.com/fmtlib/fmt
         - string->double: https://github.com/lemire/fast_double_parser (10x
            faster double parsing according to their benchmark)
      
      Bugfixes:
       - https://github.com/microsoft/LightGBM/issues/2500
       - https://github.com/microsoft/LightGBM/issues/2890
       - https://github.com/ninia/jep/issues/205
      
       (as it is related to LGBM as well)
      
      * Align CommonC namespace
      
      * Add new external_libs/ to python setup
      
      * Try fast_double_parser fix #1
      
      Testing commit e09e5aad828bcb16bea7ed0ed8322e019112fdbe
      
      If it works it should fix more LGBM builds
      
      * CMake: Attempt to link fmt without explicit PUBLIC tag
      
      * Exclude external_libs from linting
      
      * Add exernal_libs to MANIFEST.in
      
      * Set dynamic linking option for fmt.
      
      * linting issues
      
      * Try to fix lint includes
      
      * Try to pass fPIC with static fmt lib
      
      * Try CMake P_I_C option with fmt library
      
      * [R-package] Add CMake support for R and CRAN
      
      * Cleanup CMakeLists
      
      * Try fmt hack to remove stdout
      
      * Switch to header-only mode
      
      * Add PRIVATE argument to target_link_libraries
      
      * use fmt in header-only mode
      
      * Remove CMakeLists comment
      
      * Change OpenMP to PUBLIC linking in Mac
      
      * Update fmt submodule to 7.1.2
      
      * Use fmt in header-only-mode
      
      * Remove fmt from CMakeLists.txt
      
      * Upgrade fast_double_parser to v0.2.0
      
      * Revert "Add PRIVATE argument to target_link_libraries"
      
      This reverts commit 3dd45dde7b92531b2530ab54522bb843c56227a7.
      
      * Address James Lamb's comments
      
      * Update R-package/.Rbuildignore
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      
      * Upgrade to fast_double_parser v0.3.0 - Solaris support
      
      * Use legacy code only in Solaris
      
      * Fix lint issues
      
      * Fix comment
      
      * Address StrikerRUS's comments (solaris ifdef).
      
      * Change header guards
      Co-authored-by: default avatarJames Lamb <jaylamb20@gmail.com>
      792c9303
  11. 30 Nov, 2020 2 commits
  12. 29 Nov, 2020 2 commits
  13. 30 Oct, 2020 1 commit
  14. 18 Oct, 2020 1 commit
    • James Lamb's avatar
      [ci] [R-package] Fix memory leaks found by valgrind (#3443) · 81d76113
      James Lamb authored
      
      
      * fix int64 write error
      
      * attempt
      
      * [WIP] [ci] [R-package] Add CI job that runs valgrind tests
      
      * update all-successful
      
      * install
      
      * executable
      
      * fix redirect stuff
      
      * Apply suggestions from code review
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      
      * more flags
      
      * add mc to msvc proj
      
      * fix memory leak in mc
      
      * Update monotone_constraints.hpp
      
      * Update r_package.yml
      
      * remove R_INT64_PTR
      
      * disable openmp
      
      * Update gbdt_model_text.cpp
      
      * Update gbdt_model_text.cpp
      
      * Apply suggestions from code review
      
      * try to free vector
      
      * free more memories.
      
      * Update src/boosting/gbdt_model_text.cpp
      
      * fix using
      
      * try the UNPROTECT(1);
      
      * fix a const pointer
      
      * fix Common
      
      * reduce UNPROTECT
      
      * remove UNPROTECT(1);
      
      * fix null handle
      
      * fix predictor
      
      * use NULL after free
      
      * fix a leaking in test
      
      * try more fixes
      
      * test the effect of tests
      
      * throw exception in Fatal
      
      * add test back
      
      * Apply suggestions from code review
      
      * commet some tests
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * trying to comment out tests
      
      * Update openmp_wrapper.h
      
      * Apply suggestions from code review
      
      * Update configure
      
      * Update configure.ac
      
      * trying to uncomment
      
      * more comments
      
      * more uncommenting
      
      * more uncommenting
      
      * fix comment
      
      * more uncommenting
      
      * uncomment fully-commented out stuff
      
      * try uncommenting more dataset tests
      
      * uncommenting more tests
      
      * ok getting closer
      
      * more uncommenting
      
      * free dataset
      
      * skipping a test, more uncommenting
      
      * more skipping
      
      * re-enable OpenMP
      
      * allow on OpenMP thing
      
      * move valgrind to comment-only job
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * changes from code review
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * linting
      
      * issue comments too
      
      * remove issue_comment
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      81d76113
  15. 10 Oct, 2020 1 commit
  16. 08 Oct, 2020 1 commit
    • James Lamb's avatar
      [R-package] miscellaneous changes to comply with CRAN requirements (#3338) · 186711de
      James Lamb authored
      
      
      * [R-package] update DESCRIPTION per CRAN comments
      
      * newlines
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * more fixes
      
      * update Rbuildignore
      
      * more changes
      
      * more changes per CRAN response
      
      * add email
      
      * run examples in CI
      
      * add newest CRAN response
      
      * add Solaris patch
      
      * update patch
      
      * another attempt at ifaddrs patch
      
      * fix unnecessary comment
      
      * update configure
      
      * comments
      
      * bump version
      
      * tabs
      
      * fix address alignment, required by cran (#3415)
      
      * fix dataset binary file alignment
      
      * many fixes
      
      * fix warnings
      
      * fix bug
      
      * Update file_io.cpp
      
      * Update file_io.cpp
      
      * simplify code
      
      * Apply suggestions from code review
      
      * general
      
      * remove unneeded alignment
      
      * Update file_io.h
      
      * int32 to byte8 alignment
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * fixing conflicts
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * trying to fix conflicts
      
      * more fixes
      
      * this will work
      
      * update cran-comments
      
      * simplify solaris, add more testing docs
      
      * stuff
      
      * remove rchck docs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove extra use of cat()
      
      * change solaris check
      
      * update docs
      
      * remove testing code
      
      * fix warning about cleanup not having execute permissions
      
      * fix cmake builds
      
      * remove blank line
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      186711de
  17. 04 Sep, 2020 1 commit
  18. 30 Aug, 2020 1 commit
  19. 25 Aug, 2020 1 commit
  20. 18 Aug, 2020 1 commit
  21. 12 Aug, 2020 1 commit
  22. 29 Jul, 2020 1 commit
    • James Lamb's avatar
      [R-package] make package installable with CRAN toolchain (fixes #2960) (#3188) · aa933eb4
      James Lamb authored
      
      
      * [R-package] make package installable with CRAN toolchain (fixes #2960)
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove GPU stuff
      
      * use wildcard to find objects to build
      
      * use -lomp
      
      * build configure before moving files
      
      * using wildcard for objects
      
      * Update .github/workflows/main.yml
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * add explicit objects back
      
      * reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
      
      * fixing things
      
      * pin autoconf version
      
      * show diff
      
      * add automake back
      
      * run less checks
      
      * command was in the wrong place
      
      * fix autoconf version
      
      * change strategy for handling configure
      
      * fix Rbuildignore
      
      * fix NOTEs
      
      * fix notes about unrecognized files
      
      * fixing extra files
      
      * remove USE_R35
      
      * add OpenMP check for Mac CRAN build
      
      * run all checks
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * suggestions from code review
      
      * undo indenting
      
      * remove 03 from Makevars.win.in
      
      * update language about OpenMP in configure script
      
      * checking if configure.ac check works
      
      * add autoconf back
      
      * remove testing code in configure.ac
      
      * more fixes for CI on configure script
      
      * print git diff
      
      * add VERSION.txt when checking configure
      
      * fix relative paths
      
      * remove git diff
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      aa933eb4
  23. 12 Jul, 2020 1 commit
  24. 14 Jun, 2020 1 commit
    • James Lamb's avatar
      [R-package] Add support for R 4.0 (fixes #3064, fixes #3024) (#3065) · e83042f2
      James Lamb authored
      
      
      * [R-package] replaced gendef.exe with R code to create R.def (fixes #3064)
      
      * fix broken things
      
      * trying to add R4.0 docs
      
      * changed make
      
      * fixing make paths
      
      * update notes on environment variables
      
      * fix linting
      
      * fixes to CI
      
      * fixing build_cmd and other stuff
      
      * fix bad substitution
      
      * fix Azure Linux builds
      
      * I am bad at bash
      
      * simplifying
      
      * only testing R
      
      * getting better logs
      
      * mingw32
      
      * docs
      
      * toolchain
      
      * using msys
      
      * fix visual studio condition
      
      * toolchain test
      
      * full CI
      
      * fix if-elses
      
      * bump allowed NOTEs
      
      * search for Rscript
      
      * updates to docs
      
      * use processx
      
      * fix mismatched arguments
      
      * move CI to GitHub Actions
      
      * minor changes
      
      * fix workflow file
      
      * fix templating
      
      * fix Azure DevOps
      
      * debugging windows builds
      
      * dont shQuote file name
      
      * all GitHub Actions jobs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * minor cleanup
      
      * remove objdump printing
      
      * make file.remove() invisible
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * reduce duplicated paths in docs
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      e83042f2
  25. 30 Apr, 2020 1 commit
  26. 25 Apr, 2020 1 commit
  27. 08 Apr, 2020 1 commit
  28. 04 Mar, 2020 1 commit
  29. 12 Jan, 2020 2 commits
  30. 06 Jan, 2020 1 commit
  31. 01 Sep, 2019 1 commit
    • Nikita Titov's avatar
      [docs][R] added R-package docs generation routines (#2176) · faba6caf
      Nikita Titov authored
      * added R-package docs generation routines
      
      * change theme to be more consistent with sphinx_rtd_theme on main site in terms of color scheme
      
      * placed man folder with old Rd files back
      
      * specify full path to conda and make script more readable by one line - one pkg
      
      * removed commented lines from build_r_site script
      
      * made one line - one argument in build_reference() call
      
      * pin R package versions
      
      * fixed conflict
      faba6caf
  32. 08 May, 2019 1 commit
  33. 29 Apr, 2019 1 commit
  34. 05 Sep, 2018 1 commit
  35. 29 Aug, 2018 2 commits
    • Nikita Titov's avatar
      removed duplicated info in R README (#1624) · 3dd72191
      Nikita Titov authored
      3dd72191
    • James Lamb's avatar
      [R-package] CRAN fixes (#1499) · eded794e
      James Lamb authored
      * Fixed typos in docs
      
      * Fixed inconsistencies in documentation
      
      * Updated strategy for registering routines
      
      * Fixed issues caused by smashing multiple functions into one Rd
      
      * Fixed issues with documentation
      
      * Removed VignetteBuilder and updated Rbuildignore
      
      * Added R build artefacts to gitignore
      
      * Added namespacing on data.table set function. Updated handling of CMakeLists file to get around CRAN check.
      
      * Updated build instructions
      
      * Added R build script
      
      * Removed build_r.sh script and updated R-package install instructions
      eded794e