Commits · 429148309a7912754b89dfda78f01f39df17be3f · tianlh / LightGBM-DCU

28 Oct, 2021 1 commit
- Reset OpenMP thread number if num_threads <= 0 (#4704) · 42914830
  Zhiyuan He authored Oct 29, 2021
```
* mock func for no openmp

* use omp_get_max_threads
Co-authored-by: hzy46 <email@example.com>
```
  42914830
07 May, 2021 1 commit

Precise text file parsing (#4081) · f8318088

Chen Yufei authored May 07, 2021



* New build option: USE_PRECISE_TEXT_PARSER.

Use fast_double_parser for text file parsing. For each number, fallback
to strtod in case of parse failure.

* Add benchmark for CSVParser with Atof and AtofPrecise.

* Fix lint complaint.

* Fix typo in open result error message.

* Revert "Fix lint complaint."

This reverts commit 92ab0b6bce9f17d7be9eaeb20f19d4a0a36f0387.

* Revert "Add benchmark for CSVParser with Atof and AtofPrecise."

This reverts commit 4f8639abd06c679d4382eb715a1793afd94df3d2.

* Use AtofPrecise in Common::__StringToTHelper.

* [option] precise_float_parser: precise float number parsing for text input.

* Remove USE_PRECISE_TEXT_PARSER compile option.

* test: add test for Common::AtofPrecise.

* test: remove ChunkedArrayTest with 0 length.

This triggers Log::Fatal which aborts the test program.

* fix lint, add copyright.

* Revert "test: remove ChunkedArrayTest with 0 length."

This reverts commit 346c76affe9e78b6ca2738c4a56dbb9c00f31102.

* Use LightGBM::Common::Sign

* save precise_float_parser in model file.

* Fix error checking in AtofPrecise. Add more test cases.

* Remove test case that can't pass under macOS.

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

f8318088

23 Feb, 2021 1 commit
- [DOCS] Update docs to note that pred_contrib is not available for linear trees (#4006) · b09c1ff7
  Belinda Trotta authored Feb 24, 2021
```
* Update docs to note that pred_contrib is not available for linear trees

* Add warning in code

* Change warning to error
```
  b09c1ff7
19 Feb, 2021 1 commit
- [docs] Change some 'parallel learning' references to 'distributed learning' (#4000) · 7880b79f
  James Lamb authored Feb 19, 2021
```
* [docs] Change some 'parallel learning' references to 'distributed learning'

* found a few more

* one more reference
```
  7880b79f
03 Feb, 2021 1 commit
- Add new task type: "save_binary" (#3651) · 111d0c80
  Chen Yufei authored Feb 03, 2021
```
* Add new task type: "save_binary".

* Document for task "save_binary".
```
  111d0c80
18 Jan, 2021 1 commit

Minor C API cleanup in predictor & SingleRowPredictor (#3777) · 35612633

Alberto Ferreira authored Jan 18, 2021



* Cleanup predictor

* Cleanup SingleRowPredictor

* Update src/application/predictor.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/application/predictor.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update src/application/predictor.hpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

35612633

21 Nov, 2020 1 commit

[R-package] Remove CLI-only objects (#3566) · 1c5930bf

James Lamb authored Nov 21, 2020



* [R-package] Remove CLI-only objects

* more guards

* more guards

* variable not string

* simplify fix

* revert build_r.R changes

* move define of global_timer
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

1c5930bf

20 Sep, 2020 1 commit

[GPU] Add support for CUDA-based GPU build (#3160) · f7ad9457

Chip Kerchner authored Sep 20, 2020

* Initial CUDA work

* redirect log to python console (#3090)

* redir log to python console

* fix pylint

* Apply suggestions from code review

* Update basic.py

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update c_api.h

* Apply suggestions from code review

* super-minor: better wording
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

* re-order includes (fixes #3132) (#3133)

* Revert "re-order includes (fixes #3132) (#3133)" (#3153)

This reverts commit 656d2676

* Missing change from previous rebase

* Minor cleanup and removal of development scripts.

* Only set gpu_use_dp on by default for CUDA. Other minor change.

* Fix python lint indentation problem.

* More python lint issues.

* Big lint cleanup - more to come.

* Another large lint cleanup - more to come.

* Even more lint cleanup.

* Minor cleanup so less differences in code.

* Revert is_use_subset changes

* Another rebase from master to fix recent conflicts.

* More lint.

* Simple code cleanup - add & remove blank lines, revert unneccessary format changes, remove added dead code.

* Removed parameters added for CUDA and various bug fix.

* Yet more lint and unneccessary changes.

* Revert another change.

* Removal of unneccessary code.

* temporary appveyor.yml for building and testing

* Remove return value in ReSize

* Removal of unused variables.

* Code cleanup from reviewers suggestions.

* Removal of FIXME comments and unused defines.

* More reviewers comments cleanup.

* Fix config variables.

* Attempt to fix check-docs failure

* Update Paramster.rst for num_gpu

* Removing test appveyor.yml

* Add CUDA_RESOLVE_DEVICE_SYMBOLS to libraries to fix linking issue.

* Fixed handling of data elements less than 2K.

* More reviewers comments cleanup.

* Removal of TODO and fix printing of int64_t

* Add cuda change for CI testing and remove cuda from device_type in python.

* Missed one change form previous check-in

* Removal AdditionConfig and fix settings.

* Limit number of GPUs to one for now in CUDA.

* Update Parameters.rst for previous check-in

* Whitespace removal.

* Cleanup unused code.

* Changed uint/ushort/ulong to unsigned int/short/long to help Windows based CUDA compiler work.

* Lint change from previous check-in.

* Changes based on reviewers comments.

* More reviewer comment changes.

* Adding warning for is_sparse. Revert tmp_subset code. Only return FeatureGroupData if not is_multi_val_

* Fix so that CUDA code will compile even if you enable the SCORE_T_USE_DOUBLE define.

* Reviewer comment cleanup.

* Replace warning with Log message. Removal of some of the USE_CUDA. Fix typo and removal of pragma once.

* Remove PRINT debug for CUDA code.

* Allow to use of multiple GPUs for CUDA.

* More multi-GPUs enablement for CUDA.

* More code cleanup based on reviews comments.

* Update docs with latest config changes.
Co-authored-by: Gordon Fossum <fossum@us.ibm.com>
Co-authored-by: ChipKerchner <ckerchne@linux.vnet.ibm.com>
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

f7ad9457

11 Aug, 2020 1 commit

simplify start_iteration param for predict in Python and some code cleanup for... · 877d58fa

Nikita Titov authored Aug 11, 2020

simplify start_iteration param for predict in Python and some code cleanup for start_iteration (#3288)

* simplify start_iteration param for predict in Python and some code cleanup for start_iteration

* revert docs changes about the prediction result shape

877d58fa

06 Aug, 2020 1 commit

[Python] / [R] add start_iteration to python predict interface (fix #3058) (#3272) · 82e2ff7a

shiyu1994 authored Aug 06, 2020



* [python] add start_iteration to python predict interface (#3058)

* Apply suggestions from code review

* Update lightgbm_R.h

* Apply suggestions from code review

* Apply suggestions from code review

* fix R interface

* update R documentation
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

82e2ff7a

15 Jul, 2020 1 commit

feature importance type in saved model file (#3220) · 87d46489

Guolin Ke authored Jul 16, 2020



* feature importance type in saved model file

* fix nullptr

* fixed formatting

* fix python/R

* Update src/c_api.cpp

* Apply suggestions from code review
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* fix c_api test

* fix swig

* minor docs improvements and added defines for importance types
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

87d46489

28 Jun, 2020 1 commit

adding sparse support to TreeSHAP in lightgbm (#3000) · 9f367d11

Ilya Matiach authored Jun 28, 2020

* adding sparse support to TreeSHAP in lightgbm

* updating based on comments

* updated based on comments, used fromiter instead of frombuffer

* updated based on comments

* fixed limits import order

* fix sparse feature contribs to work with more than int32 max rows

* really fixed int64 max error and build warnings

* added sparse test with >int32 max rows

* fixed python side reshape check on sparse data

* updated based on latest comments

* fixed comments

* added CSC INT32_MAX validation to test, fixed comments

9f367d11

05 Jun, 2020 1 commit
- Revert "re-order includes (fixes #3132) (#3133)" (#3153) · ac5f5e56
  Nikita Titov authored Jun 05, 2020
```
This reverts commit 656d2676.
```
  ac5f5e56
01 Jun, 2020 1 commit
- re-order includes (fixes #3132) (#3133) · 656d2676
  James Lamb authored Jun 01, 2020
  
  656d2676
02 Mar, 2020 3 commits

fix bug in parallel learning (#2851) · da91c613
Guolin Ke authored Mar 02, 2020
```
* refix

* fix config

* avoid to rely on config
```
da91c613

don't save num_thread as possible (#2839) · 0aa7bfee

Guolin Ke authored Mar 02, 2020



* don't cache `num_thread`, to avoid change outside

* rename

* update document

* Update docs/Parameters.rst

* Update include/LightGBM/config.h

* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>

* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

0aa7bfee

introduced specific CHECKs (#2849) · 5a80b788
Nikita Titov authored Mar 02, 2020

5a80b788

22 Feb, 2020 1 commit

some code refactoring (#2769) · 3e80df7e

Guolin Ke authored Feb 22, 2020

* some refines

* more omp refactoring

* format define

* fix merge bug

* some fixes

* fix some warnings

* Apply suggestions from code review

* Apply suggestions from code review

* remove dup codes

3e80df7e

20 Feb, 2020 1 commit

remove init-score parameter (#2776) · 3c394c8d

Guolin Ke authored Feb 20, 2020



* remove related cpp codes

* removed more mentiones of init_score_filename params
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

3c394c8d

04 Feb, 2020 1 commit
- no omp_set_nested (#2734) · 3e9a6140
  Guolin Ke authored Feb 04, 2020
```
* no omp_set_nested

* Update openmp_wrapper.h
```
  3e9a6140
02 Feb, 2020 1 commit

Support both row-wise and col-wise multi-threading (#2699) · 509c2e50

Guolin Ke authored Feb 02, 2020



* commit

* fix a bug

* fix bug

* reset to track changes

* refine the auto choose logic

* sort the time stats output

* fix include

* change  multi_val_bin_sparse_threshold

* add cmake

* add _mm_malloc and _mm_free for cross platform

* fix cmake bug

* timer for split

* try to fix cmake

* fix tests

* refactor DataPartition::Split

* fix test

* typo

* formating

* Revert "formating"

This reverts commit 5b8de4f7fb9d975ee23701d276a66d40ee6d4222.

* add document

* [R-package] Added tests on use of force_col_wise and force_row_wise in training (#2719)

* naming

* fix gpu code

* Update include/LightGBM/bin.h
Co-Authored-By: James Lamb <jaylamb20@gmail.com>

* Update src/treelearner/ocl/histogram16.cl

* test: swap compilers for CI

* fix omp

* not avx2

* no aligned for feature histogram

* Revert "refactor DataPartition::Split"

This reverts commit 256e6d9641ade966a1f54da1752e998a1149b6f8.

* slightly refactor data partition

* reduce the memory cost
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

509c2e50

07 Jan, 2020 1 commit

option to disable the shape checking in prediction (#2669) · f6b8ecf6

Guolin Ke authored Jan 08, 2020



* implement

* better documentation

* Update include/LightGBM/config.h
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>

* Apply suggestions from code review
Co-Authored-By: Nikita Titov <nekit94-08@mail.ru>

* fix document

* regenerate docs
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

f6b8ecf6

20 Dec, 2019 1 commit
- fix predict with header (#2643) · ae320e59
  Guolin Ke authored Dec 20, 2019
```
* fix predict with header

* avoid duplicated feature names
```
  ae320e59
29 Nov, 2019 1 commit
- Add more debug logging to show data load progress. (#2587) · b3975555
  ashok-ponnuswami-msft authored Nov 28, 2019
  
  b3975555
03 Oct, 2019 1 commit

check the shape for mat, csr and csc in prediction (#2464) · dee72159

Guolin Ke authored Oct 03, 2019

* check the shape for mat, csr and csc

* guess from csr

* support file checking

* better error msg

* grammar

* clean code

* code clean

* check range for CSR

* Update test_.py

* Update test_.py

* added tests

dee72159

22 Sep, 2019 1 commit

fix many cpp lint errors (#2426) · f1a14869

Guolin Ke authored Sep 22, 2019

* fix many cpp lint errors

* indent

* fix bug

* fix more

* fix gpu

* more fixes

f1a14869

01 Aug, 2019 1 commit
- delete the variable which is never used (#2294) · 55656f27
  奇安信CodeSafe authored Aug 01, 2019
  
  55656f27
13 Apr, 2019 1 commit
- added copyright message in files (#2101) · 32ef7603
  Nikita Titov authored Apr 13, 2019
  
  32ef7603
11 Apr, 2019 1 commit

reworked includes in source files (#2066) · 50ce01b5

Nikita Titov authored Apr 12, 2019

* added all necessary includes - fixed build/include_what_you_use error

* fixed the order of includes (build/include_order)

50ce01b5

06 Feb, 2019 1 commit
- fixed modifiers indent (#1997) · 462612b4
  Nikita Titov authored Feb 06, 2019
  
  462612b4
02 Feb, 2019 1 commit
- cpplint whitespaces and new lines (#1986) · 90127b52
  Nikita Titov authored Feb 02, 2019
  
  90127b52
25 Aug, 2018 1 commit
- Small optimizations and fixes (#1607) · 9bf2de1e
  dmitryikh authored Aug 25, 2018
```
* fix optimization rule

* preallocate vector in RowFunctionFromCSR
```
  9bf2de1e
22 Aug, 2018 1 commit

add start_iteration in model saving (#1565) · 941068ee

Guolin Ke authored Aug 22, 2018

* add start_iteration in model saving

* fix test

* shuffle models ability

* fix bug

* update document

* refine

* Update engine.py

* Update basic.py

* fix comments

* fix comment

941068ee

21 Aug, 2018 1 commit

remove unnecessary std::move & unused capture (#1596) · 3400e389

Qiwei Ye authored Aug 21, 2018

* remove unnecessary  std::move

* remove unused-lambda-capture

* remove unused-lambda-capture

* fix unused parameter

* minor fix

*  invalid capture of lambda function

3400e389

20 May, 2018 1 commit

Refine config object (#1381) · dc699574

Guolin Ke authored May 20, 2018

* [WIP] refine config

* [wip] ready for the auto code generate

* auto generate config codes

* use with to open file

* fix bug

* fix pylint

* fix bug

* fix pylint

* fix bugs.

* tmp for failed test.

* fix tests.

* added nthreads alias

* added new aliases from new config.h

* fixed duplicated alias

* refactored parameter_generator.py

* added new aliases from config.h and removed remaining old names

* fix bugs & some miss alias

* added aliases

* add more descriptions.

* add comment.

dc699574

11 May, 2018 1 commit
- [python] decode error description (#1362) · 899151fc
  Nikita Titov authored May 11, 2018
```
* decode error description

* added break line char in log massages
```
  899151fc
04 May, 2018 1 commit
- increase the threshold of using predict_by_map · 0f3d90e7
  Guolin Ke authored May 04, 2018
  
  0f3d90e7
27 Feb, 2018 1 commit

Experimental support for HDFS (#1243) · 7e186a57

ebernhardson authored Feb 26, 2018

* Read and write datsets from hdfs.
* Only enabled when cmake is run with -DUSE_HDFS:BOOL=TRUE
* Introduces VirtualFile(Reader|Writer) to asbtract VFS differences

7e186a57

24 Jan, 2018 1 commit
- fix a multi-thread bug in pred_contrib · 61fb5ea2
  Guolin Ke authored Jan 24, 2018
  
  61fb5ea2
12 Jan, 2018 1 commit
- refine output message of loading model. · e2835654
  Guolin Ke authored Jan 12, 2018
  
  e2835654