Commits · 4278f22293e71ad7ff80f2133ff41abe4cced02b · tianlh / LightGBM-DCU

21 Sep, 2020 3 commits

Pr4 advanced method monotone constraints (#3264) · 4278f222

CharlesAuguste authored Sep 21, 2020



* No need to pass the tree to all fuctions related to monotone constraints because the pointer is shared.

* Fix OppositeChildShouldBeUpdated numerical split optimisation.

* No need to use constraints when computing the output of the root.

* Refactor existing constraints.

* Add advanced constraints method.

* Update tests.

* Add override.

* linting.

* Add override.

* Simplify condition in LeftRightContainsRelevantInformation.

* Add virtual destructor to FeatureConstraint.

* Remove redundant blank line.

* linting of else.

* Indentation.

* Lint else.

* Replaced non-const reference by pointers.

* Forgotten reference.

* Leverage USE_MC for efficiency.

* Make constraints const again in feature_histogram.hpp.

* Update docs.

* Add "advanced" to the monotone constraints options.

* Update monotone constraints restrictions.

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Remove superfluous parenthesis.

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Fix loop iterator.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Remove std namespace qualifier.

* Fix unsigned_int size_t comparison.

* Set num_features as int for consistency with the rest of the codebase.

* Make sure constraints exist before recomputing them.

* Initialize previous constraints in UpdateConstraints.

* Update monotone constraints restrictions.

* Refactor UpdateConstraints loop.

* Update src/io/config.cpp
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Delete white spaces.
Co-authored-by: Charles Auguste <charles.auguste@sig.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

4278f222

Add option to build with integrated OpenCL (#3144) · 3454698e

TP Boudreau authored Sep 21, 2020



* Add specialized OpenCL/Python package build path

* Refer to upstream OpenCL repository

* Reset build job count in setup.py

* TEMPORARY: refer to OpenCL fork to ensure Linux CI builds succeed

* Remove intermediate cmake target

* Restrict OpenCL headers to documented API version

* Use command line definition to activate integrated build

* Flag reference to unofficial repo with FIXME

* TEMPORARY: update private repo tag for dependency

* Remove integrated build for non-Win32 and related cleanup

* Remove commented code

* Rename integrated OpenCL build option and other cleanups

* Small cleanups

* Update CMakeIntegratedOpenCL.cmake
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeIntegratedOpenCL.cmake
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeIntegratedOpenCL.cmake
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeIntegratedOpenCL.cmake
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeIntegratedOpenCL.cmake

Targeted download of Boost submodules.
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update CMakeLists.txt
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

3454698e

fix sparse multiclass local feature contributions and add test (#3382) · eff287e9
Ilya Matiach authored Sep 21, 2020

eff287e9

20 Sep, 2020 3 commits

Auc mu weights (#3349) · 1782fcb1

Belinda Trotta authored Sep 20, 2020

* Update auc_mu metric to use data weights if provided

* Calculate class sizes and total weights in Init so we only do it once

* Fix lint error

* Empty commit to trigger CI jobs

1782fcb1

[GPU] Add support for CUDA-based GPU build (#3160) · f7ad9457

Chip Kerchner authored Sep 20, 2020

* Initial CUDA work

* redirect log to python console (#3090)

* redir log to python console

* fix pylint

* Apply suggestions from code review

* Update basic.py

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update c_api.h

* Apply suggestions from code review

* super-minor: better wording
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

* re-order includes (fixes #3132) (#3133)

* Revert "re-order includes (fixes #3132) (#3133)" (#3153)

This reverts commit 656d2676

* Missing change from previous rebase

* Minor cleanup and removal of development scripts.

* Only set gpu_use_dp on by default for CUDA. Other minor change.

* Fix python lint indentation problem.

* More python lint issues.

* Big lint cleanup - more to come.

* Another large lint cleanup - more to come.

* Even more lint cleanup.

* Minor cleanup so less differences in code.

* Revert is_use_subset changes

* Another rebase from master to fix recent conflicts.

* More lint.

* Simple code cleanup - add & remove blank lines, revert unneccessary format changes, remove added dead code.

* Removed parameters added for CUDA and various bug fix.

* Yet more lint and unneccessary changes.

* Revert another change.

* Removal of unneccessary code.

* temporary appveyor.yml for building and testing

* Remove return value in ReSize

* Removal of unused variables.

* Code cleanup from reviewers suggestions.

* Removal of FIXME comments and unused defines.

* More reviewers comments cleanup.

* Fix config variables.

* Attempt to fix check-docs failure

* Update Paramster.rst for num_gpu

* Removing test appveyor.yml

* Add CUDA_RESOLVE_DEVICE_SYMBOLS to libraries to fix linking issue.

* Fixed handling of data elements less than 2K.

* More reviewers comments cleanup.

* Removal of TODO and fix printing of int64_t

* Add cuda change for CI testing and remove cuda from device_type in python.

* Missed one change form previous check-in

* Removal AdditionConfig and fix settings.

* Limit number of GPUs to one for now in CUDA.

* Update Parameters.rst for previous check-in

* Whitespace removal.

* Cleanup unused code.

* Changed uint/ushort/ulong to unsigned int/short/long to help Windows based CUDA compiler work.

* Lint change from previous check-in.

* Changes based on reviewers comments.

* More reviewer comment changes.

* Adding warning for is_sparse. Revert tmp_subset code. Only return FeatureGroupData if not is_multi_val_

* Fix so that CUDA code will compile even if you enable the SCORE_T_USE_DOUBLE define.

* Reviewer comment cleanup.

* Replace warning with Log message. Removal of some of the USE_CUDA. Fix typo and removal of pragma once.

* Remove PRINT debug for CUDA code.

* Allow to use of multiple GPUs for CUDA.

* More multi-GPUs enablement for CUDA.

* More code cleanup based on reviews comments.

* Update docs with latest config changes.
Co-authored-by: Gordon Fossum <fossum@us.ibm.com>
Co-authored-by: ChipKerchner <ckerchne@linux.vnet.ibm.com>
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

f7ad9457

improve subfeature_bynode (#3384) · 1fddabb5

Guolin Ke authored Sep 20, 2020

* Update serial_tree_learner.cpp

* Update src/treelearner/serial_tree_learner.cpp

* Update src/treelearner/serial_tree_learner.cpp

1fddabb5

15 Sep, 2020 1 commit

[python] Drop Python 3.5 support (#3395) · a3b9dae7

Nikita Titov authored Sep 15, 2020

* Update .appveyor.yml

* Update .travis.yml

* Update .vsts-ci.yml

* Update main.yml

* Update setup.py

a3b9dae7

14 Sep, 2020 2 commits

[R-package] mark CMake option for building R package as private (#3397) · 571cad7e
Nikita Titov authored Sep 14, 2020
```
* Update install.libs.R

* Update CMakeLists.txt
```
571cad7e

[ci] Use Ubuntu Focal image at Travis (#3393) · 164818b0

Nikita Titov authored Sep 14, 2020

* Use Ubuntu Focal image at Travis

* test gcc

* test Bionic and gcc

* test Focal with another Python version for GPU test

* revert testing changes

* install linkchecker via pip

* simplify linkchecker config

164818b0

13 Sep, 2020 3 commits
- Fix typo in ResetConfig (#3392) · dc963d9f
  Belinda Trotta authored Sep 13, 2020
  
  dc963d9f
- [ci] update Boost version (#3389) · 4f0f822b
  Nikita Titov authored Sep 13, 2020
  
  4f0f822b
- [R-package] ignore temp files created by R on Mac (#3388) · 3a2686db
  James Lamb authored Sep 13, 2020
  
  3a2686db
11 Sep, 2020 4 commits
- [docs] Simplify the python installation instruction (#3378) · 0d45ebd6
  Guolin Ke authored Sep 12, 2020
```
* Update Python-Intro.rst

* Update README.rst
```
  0d45ebd6
- [python] remove unused variable (#3376) · 0c708d37
  James Lamb authored Sep 11, 2020
  
  0c708d37
- [R-package] remove unnecessary comments (#3356) · 788f3a1a
  James Lamb authored Sep 11, 2020
```
* [R-package] remove unused code and comments

* put check back

* other typos
```
  788f3a1a
- avoid segment fault in ResetConfig for GBDT in prediction (fix #3317) (#3373) · fee6f4a2
  shiyu1994 authored Sep 11, 2020
  
  fee6f4a2
09 Sep, 2020 1 commit

[ci] host some artifacts needed by R Windows CI jobs (#3359) · f7f4e602

James Lamb authored Sep 09, 2020



* [ci] host some artifacts needed by R Windows CI jobs

* remove link

* host SWIG
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

f7f4e602

08 Sep, 2020 3 commits
- [docs] remove unrelated entry from winning solutions list (#3370) · adfc9f5c
  Nikita Titov authored Sep 08, 2020
  
  adfc9f5c
- [python][examples] updated examples with multiple custom metrics (#3367) · 116abc67
  Nikita Titov authored Sep 08, 2020
  
  116abc67
- [docs] update list of winning solutions in data science competitions (#3358) · d3fb6c9f
  Juniper-23 authored Sep 08, 2020
```
* 'examples/README.md'

* 'examples\README.md'
Co-authored-by: Tripathi, Aishwarya <aishwarya_tripathi@dell.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
```
  d3fb6c9f
06 Sep, 2020 4 commits

[Python] Refactor scikit-learn API to allow a list of evaluation metrics (#3254) · afc76d2c

Germán Ramírez-Espinoza authored Sep 07, 2020



* Refactors sklearn API to allow a list of evaluation metrics in the parameter eval_metric of the class (and subclasses of) LGBMModel. Also adds unit tests for this functionality

* Simplify expression to check whether the user passed one or multiple metrics to eval_metric parameter

* Simplify new tests by using custom metrics already defined in the test file

* Update docstring to reflect the fact that the parameter "feval" from the "train" and "cv" functions can also receive a list of callables

* Remove oxford comma from docstrings

Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Use named-parameters to make sure code is compatible with future versions of scikit-learn

Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Remove throwaway return value to make code more succinct
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Move statement to group together the code related to feval

* Avoid modifying original args as it causes errors in scikit-learn tools

For details see: https://github.com/microsoft/LightGBM/pull/2619



* Consolidate multiple eval-metrics unit-tests into one test
Co-authored-by: German I Ramirez-Espinoza <gire@home>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

afc76d2c

[ci] remove Azure checks from R CI (#3355) · 0faf8741

James Lamb authored Sep 06, 2020

* [ci] remove texlive-fonts-extra and Azure checks R from CI

* put texlive-fonts-extra back

0faf8741

[R-package] added support for first_metric_only (fixes #2368) (#2912) · d4325c5a

James Lamb authored Sep 06, 2020

* [R-package] started implementing first_metric_only

* trying stuff

* more changes

* fixed handling of multiple metrics

* fixed tests

* remove duplicate tests

* get training tests

* fixes for lgb.cv()

* fixes for lgb.cv()

* fix linting

d4325c5a

[ci] add an allgood job for easy [required] builds (#3351) · 636e4eee

Thomas Grainger authored Sep 06, 2020

* add an allgood job for easy [required] builds

see https://github.community/t/is-it-possible-to-require-all-github-actions-tasks-to-pass-without-enumerating-them/117957/4?u=graingert



* Update .github/workflows/main.yml

* Update .github/workflows/main.yml
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

636e4eee

04 Sep, 2020 1 commit
- [R-package] fix typo in R installation instructions (#3350) · aa18f844
  David Dalpiaz authored Sep 04, 2020
```
* fix typo in R installation instructions

* move r installation instructions to correct version
```
  aa18f844
02 Sep, 2020 2 commits

be compatible with check_is_fitted sklearn function (#3329) · ca066d49
Nikita Titov authored Sep 02, 2020

ca066d49

bump version (#3344) · 8fc80bb4

Guolin Ke authored Sep 02, 2020



* Update VERSION.txt

* Update .appveyor.yml

* remove 3.0-RC installation guide

* Apply suggestions from code review

* [R-package] bump version (#3345)
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

8fc80bb4

30 Aug, 2020 1 commit

[R-package] Add R logo (fixes #3331, #3332) (#3336) · 7e11d4ae

James Lamb authored Aug 30, 2020



* [R-package] add R package logo

* more changes

* add logo in the place CRAN expects

* revert unnecessary Rbuildignore stuff

* uploaded hex logo for R-package in SVG format (#3340)

* remove duplicate logo and fix CI

* use SVG instead of PNG
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

7e11d4ae

29 Aug, 2020 1 commit
- [ci] fix R CMD check issue 'unable to verify current time' (#3341) · 0038a662
  James Lamb authored Aug 29, 2020
  
  0038a662
25 Aug, 2020 1 commit

[R-package] [ci] Reduce manual effort for version updates (#3335) · 5538eb8d

James Lamb authored Aug 25, 2020



* [R-package] [ci] Reduce manual effort for version updates

* fix configure

* remove useless comment

* Update build_r.R
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

* fix recreate-configure check in CI
Co-authored-by: Guolin Ke <guolin.ke@outlook.com>

5538eb8d

24 Aug, 2020 1 commit
- [doc] remove excess fit arguments from docstrings (#3330) · 9503d3f9
  Nikita Titov authored Aug 24, 2020
  
  9503d3f9
23 Aug, 2020 2 commits
- [R-package] update roles in DESCRIPTION (#3333) · 8ab35255
  James Lamb authored Aug 23, 2020
  
  8ab35255
- [doc] added logo to docs (#3327) · 672d0e52
  Nikita Titov authored Aug 23, 2020
  
  672d0e52
19 Aug, 2020 7 commits
- Add Logo to readme (#3322) · 4d8d289d
  Guolin Ke authored Aug 20, 2020
```
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
```
  4d8d289d
- [ci] bump Xcode version at Travis (#3323) · 0aa48690
  Nikita Titov authored Aug 19, 2020
```
* bump Xcode version at Travis

* remove temp fix for gcc at Travis
```
  0aa48690
- [ci][docs] update Doxygen link in docs (#3324) · 01c9ad5a
  Nikita Titov authored Aug 19, 2020
  
  01c9ad5a
- [R-package] remove blank lines and not-really-comments from .Rbuildignore (#3318) · 7d6f742d
  James Lamb authored Aug 19, 2020
  
  7d6f742d
- Update logo with white font · 74ed4826
  Guolin Ke authored Aug 19, 2020
  
  74ed4826
- remove margins in logo · 2771959b
  Guolin Ke authored Aug 19, 2020
  
  2771959b
- upload logo files · 86e938db
  Guolin Ke authored Aug 19, 2020
  
  86e938db