1. 08 Oct, 2020 1 commit
    • James Lamb's avatar
      [R-package] miscellaneous changes to comply with CRAN requirements (#3338) · 186711de
      James Lamb authored
      
      
      * [R-package] update DESCRIPTION per CRAN comments
      
      * newlines
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * more fixes
      
      * update Rbuildignore
      
      * more changes
      
      * more changes per CRAN response
      
      * add email
      
      * run examples in CI
      
      * add newest CRAN response
      
      * add Solaris patch
      
      * update patch
      
      * another attempt at ifaddrs patch
      
      * fix unnecessary comment
      
      * update configure
      
      * comments
      
      * bump version
      
      * tabs
      
      * fix address alignment, required by cran (#3415)
      
      * fix dataset binary file alignment
      
      * many fixes
      
      * fix warnings
      
      * fix bug
      
      * Update file_io.cpp
      
      * Update file_io.cpp
      
      * simplify code
      
      * Apply suggestions from code review
      
      * general
      
      * remove unneeded alignment
      
      * Update file_io.h
      
      * int32 to byte8 alignment
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * fixing conflicts
      
      * [R-package] add new copyright holder in DESCRIPTION (#3409)
      
      * [R-package] add new copyright holder in DESCRIPTION
      
      * fix role
      
      * trying to fix conflicts
      
      * more fixes
      
      * this will work
      
      * update cran-comments
      
      * simplify solaris, add more testing docs
      
      * stuff
      
      * remove rchck docs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove extra use of cat()
      
      * change solaris check
      
      * update docs
      
      * remove testing code
      
      * fix warning about cleanup not having execute permissions
      
      * fix cmake builds
      
      * remove blank line
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarGuolin Ke <guolin.ke@outlook.com>
      186711de
  2. 14 Sep, 2020 1 commit
  3. 06 Aug, 2020 1 commit
  4. 29 Jul, 2020 2 commits
    • James Lamb's avatar
    • James Lamb's avatar
      [R-package] make package installable with CRAN toolchain (fixes #2960) (#3188) · aa933eb4
      James Lamb authored
      
      
      * [R-package] make package installable with CRAN toolchain (fixes #2960)
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * remove GPU stuff
      
      * use wildcard to find objects to build
      
      * use -lomp
      
      * build configure before moving files
      
      * using wildcard for objects
      
      * Update .github/workflows/main.yml
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * add explicit objects back
      
      * reduce allowed R CMD check NOTEs and catch stderr from build-cran-package on Windows
      
      * fixing things
      
      * pin autoconf version
      
      * show diff
      
      * add automake back
      
      * run less checks
      
      * command was in the wrong place
      
      * fix autoconf version
      
      * change strategy for handling configure
      
      * fix Rbuildignore
      
      * fix NOTEs
      
      * fix notes about unrecognized files
      
      * fixing extra files
      
      * remove USE_R35
      
      * add OpenMP check for Mac CRAN build
      
      * run all checks
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * suggestions from code review
      
      * undo indenting
      
      * remove 03 from Makevars.win.in
      
      * update language about OpenMP in configure script
      
      * checking if configure.ac check works
      
      * add autoconf back
      
      * remove testing code in configure.ac
      
      * more fixes for CI on configure script
      
      * print git diff
      
      * add VERSION.txt when checking configure
      
      * fix relative paths
      
      * remove git diff
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      aa933eb4
  5. 15 Jul, 2020 1 commit
  6. 13 Jul, 2020 1 commit
  7. 12 Jul, 2020 1 commit
  8. 14 Jun, 2020 1 commit
    • James Lamb's avatar
      [R-package] Add support for R 4.0 (fixes #3064, fixes #3024) (#3065) · e83042f2
      James Lamb authored
      
      
      * [R-package] replaced gendef.exe with R code to create R.def (fixes #3064)
      
      * fix broken things
      
      * trying to add R4.0 docs
      
      * changed make
      
      * fixing make paths
      
      * update notes on environment variables
      
      * fix linting
      
      * fixes to CI
      
      * fixing build_cmd and other stuff
      
      * fix bad substitution
      
      * fix Azure Linux builds
      
      * I am bad at bash
      
      * simplifying
      
      * only testing R
      
      * getting better logs
      
      * mingw32
      
      * docs
      
      * toolchain
      
      * using msys
      
      * fix visual studio condition
      
      * toolchain test
      
      * full CI
      
      * fix if-elses
      
      * bump allowed NOTEs
      
      * search for Rscript
      
      * updates to docs
      
      * use processx
      
      * fix mismatched arguments
      
      * move CI to GitHub Actions
      
      * minor changes
      
      * fix workflow file
      
      * fix templating
      
      * fix Azure DevOps
      
      * debugging windows builds
      
      * dont shQuote file name
      
      * all GitHub Actions jobs
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * minor cleanup
      
      * remove objdump printing
      
      * make file.remove() invisible
      
      * Apply suggestions from code review
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * reduce duplicated paths in docs
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      e83042f2
  9. 11 Jun, 2020 1 commit
  10. 05 Jun, 2020 1 commit
  11. 01 Jun, 2020 1 commit
  12. 25 May, 2020 1 commit
  13. 20 May, 2020 1 commit
  14. 14 May, 2020 1 commit
  15. 04 May, 2020 1 commit
  16. 02 May, 2020 1 commit
  17. 26 Apr, 2020 1 commit
    • James Lamb's avatar
      [R-package] [ci] Add Windows CI for R package (fixes #2335) (#2936) · 2c18a0f3
      James Lamb authored
      
      
      * first test of appveyor
      
      * strings are strings
      
      * lil bit of build script
      
      * fixing paths
      
      * removed unnecessary file
      
      * updated CRAN URL
      
      * added a lot more printing
      
      * fixing paths
      
      * more stuff
      
      * fixed paths
      
      * more stuff
      
      * more path guessing
      
      * even more paths
      
      * more stuff
      
      * moar logz
      
      * and now for something totally different
      
      * please work
      
      * ok could be a thing
      
      * changing directories
      
      * we might be in business
      
      * fixed install syntax
      
      * tryinv mingw
      
      * more mingw
      
      * ignore Suggests check
      
      * trying Azure DevOps
      
      * just run bare minimum for Azure DevOps
      
      * fixed  build dir thing
      
      * trying to set libPaths
      
      * more testing
      
      * trying R 3.6.3
      
      * R 3.6.3
      
      * this feels right
      
      * still messing around with libraries
      
      * more paths
      
      * removed duplication in Windows testing code
      
      * simpler
      
      * fixed conda stuff
      
      * more conda stuff
      
      * more fixes
      
      * fixed testing script
      
      * moved AppVeyor setup to the top
      
      * commenting
      
      * ch-ch-ch-ch-chaaaanges
      
      * paths
      
      * plz work
      
      * fixed conda stuff in Windows CI
      
      * uncommented stuff to test a full build
      
      * fixed quotes and removed some unnecessary stuff
      
      * added install.libs.R change
      
      * quotes are impoortant
      
      * added commented-out stuff back in
      
      * added Windows script, download retries, and MSVC linking
      
      * minor fixes
      
      * cleaned up debugging code in FindLibR
      
      * cleaned up debugging code and moved R first in CI
      
      * fixed vsts-ci indentation
      
      * cut documentation stuff out of MSVC build
      
      * fix R CMD check for Azure
      
      * misc whitespace changes
      
      * Added echoing of build logs from R CMD check
      
      * cut out more documentation tests
      
      * fixed NOTE about imports from Matrix
      
      * moved some changes out of this PR and into #2963
      
      * fixed whitespace stuff
      
      * added check on number of NOTES
      
      * adding better checks
      
      * fixing check on NOTEs
      
      * removing unnecessary variable
      
      * Update .ci/test_r_package_windows.ps1
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * some changes
      
      * fix quoting
      
      * trying MINGW on Azure DevOps
      
      * fixing paths
      
      * more paths
      
      * fixing paths
      
      * testing paths
      
      * fixing slashes
      
      * pinned CTAN mirror
      
      * get better logs
      
      * made sure Azure finds MinGW, fixed search for LIBR_CORE_LIBRARY, stopped building R docs on Azure
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * added CXX, CC for Windows builds and changed back to building docs on all MINGW builds
      
      * stored LIBR_CORE_LIBRARY hints in one variable
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * changes from code review
      
      * increased parallel builds for Azure CI
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      2c18a0f3
  18. 01 Apr, 2020 1 commit
  19. 24 Mar, 2020 1 commit
    • James Lamb's avatar
      [R-package] Use Rprintf for logging in the R package (fixes #1440, fixes #1909) (#2901) · 0341906c
      James Lamb authored
      
      
      * [R-package] started cutting over from custom R-to-C interface to R.h
      
      * replaced LGBM_SE with SEXP
      
      * fixed error about ocnflicting definitions of length
      
      * got linking working
      
      * more stuff
      
      * eliminated R CMD CHECK note about printing
      
      * switched from hard-coded include dir to the one from FindLibR.cmake
      
      * cleaned up formatting in FindLibR.cmake
      
      * commented-out everything in CI that does not touch R
      
      * more changes
      
      * trying to get better logs
      
      * tried ignoring
      
      * added error message to confirm a suspicion
      
      * still trying to find R during R CMD CHECK
      
      * restore full CI
      
      * fixed comment
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * changed strategy for finding LIBR_HOME on Windows
      
      * Removed 32-bit Windows stuff in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update CMakeLists.txt
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed some duplication in cmake scripts
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * added LIBR_CORE_LIBRARY back
      
      * small fixes to CMakeLists
      
      * simplified FindLibR.cmake
      
      * some fixes for windows
      
      * Apply suggestions from code review
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * allowed for directly passing LIBR_EXECUTABLE to FindLibR.cmake
      
      * reorganized FindLibR.cmake to catch more cases
      
      * clean up inconsistencies  in R calls in FindLibR.cmake
      
      * Update R-package/src/cmake/modules/FindLibR.cmake
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed unnecessary log messages
      
      * removed unnecessary unset() call
      Co-authored-by: default avatarNikita Titov <nekit94-08@mail.ru>
      0341906c
  20. 22 Mar, 2020 1 commit
  21. 16 Mar, 2020 1 commit
  22. 15 Mar, 2020 1 commit
  23. 10 Mar, 2020 1 commit
  24. 12 Jan, 2020 1 commit
  25. 15 Dec, 2019 1 commit
  26. 16 Nov, 2019 1 commit
    • James Lamb's avatar
      [R-package][ci] Added more R linters (fixes #2477) (#2533) · 1f7b06b9
      James Lamb authored
      
      
      * Added more linters on R code
      
      * started working on implicit integers
      
      * finished style changes to handle implicit integers
      
      * regenned documentation and added concatenation linter
      
      * changed channel for r-lintr
      
      * try building stringi before lintr
      
      * trying to get libicui18n
      
      * trying another thing
      
      * trying conda-forge again
      
      * added re-install of stringi
      
      * uncommented other stages
      
      * Update .ci/test.sh
      Co-Authored-By: default avatarNikita Titov <nekit94-08@mail.ru>
      
      * removed apt update and changed lintr version floor
      
      * get lintr from CRAN
      
      * R needs to come before C++ linting
      
      * testing lintr install from CRAN
      
      * trying one more thing
      
      * more verbose
      
      * order might matter
      
      * removed commented code
      
      * cleaned up linting block in test.sh
      
      * grouped conda install calls and fixed a few integer array things
      1f7b06b9
  27. 24 Oct, 2019 1 commit
  28. 21 Aug, 2019 2 commits
  29. 13 Jun, 2019 1 commit
  30. 12 May, 2019 1 commit
  31. 29 Apr, 2019 1 commit
  32. 27 Jan, 2019 1 commit
  33. 09 Sep, 2018 1 commit
  34. 29 Aug, 2018 1 commit
    • James Lamb's avatar
      [R-package] CRAN fixes (#1499) · eded794e
      James Lamb authored
      * Fixed typos in docs
      
      * Fixed inconsistencies in documentation
      
      * Updated strategy for registering routines
      
      * Fixed issues caused by smashing multiple functions into one Rd
      
      * Fixed issues with documentation
      
      * Removed VignetteBuilder and updated Rbuildignore
      
      * Added R build artefacts to gitignore
      
      * Added namespacing on data.table set function. Updated handling of CMakeLists file to get around CRAN check.
      
      * Updated build instructions
      
      * Added R build script
      
      * Removed build_r.sh script and updated R-package install instructions
      eded794e
  35. 28 Apr, 2018 1 commit
  36. 16 Mar, 2018 1 commit
  37. 27 Dec, 2017 1 commit
  38. 01 Nov, 2017 1 commit