Commits · 2f5baa3d39efb518cd13a7932fe4d8602c36762f · tianlh / LightGBM-DCU

19 Jun, 2022 1 commit

[python-package] add type hints on `cv()` (#5271) · 2f5baa3d

James Lamb authored Jun 18, 2022



* [python-package] add type hints on cv()

* remove inadvertent changes

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

2f5baa3d

22 Apr, 2022 1 commit

[python-package] remove 'fobj' in favor of passing custom objective function... · 416ecd5a

Miguel Trejo Marrufo authored Apr 21, 2022


[python-package] remove 'fobj' in favor of passing custom objective function in params (fixes #3244) (#5052)

* feat: support custom metrics in params

* feat: support objective in params

* test: custom objective and metric

* fix: imports are incorrectly sorted

* feat: convert eval metrics str and set to list

* feat: convert single callable eval_metric to list

* test: single callable objective in params
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* feat: callable fobj in basic cv function
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: cv support objective callable
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* fix: assert in cv_res
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* docs: objective callable in params
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* recover test_boost_from_average_with_single_leaf_trees
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* linters fail
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* remove metrics helper functions
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* feat: choose objective through _choose_param_values
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: test objective through _choose_param_values
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: test objective is callabe in train
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: parametrize choose_param_value with objective aliases
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: cv booster metric is none
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* fix: if string and callable choose callable
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test train uses custom objective metrics
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: cv uses custom objective metrics
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* refactor: remove fobj parameter in train and cv
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* refactor: objective through params in sklearn API
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* custom objective function in advanced_example
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* fix whitespackes lint

* objective is none not a particular case for predict method
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* replace scipy.expit with custom implementation
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* test: set num_boost_round value to 20
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* fix: custom objective default_value is none
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* refactor: remove self._fobj
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* custom_objective default value is None
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* refactor: variables name reference dummy_obj
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* linter errors

* fix: process objective parameter when calling predict
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

* linter errors

* fix: objective is None during predict call
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>

416ecd5a

12 Mar, 2022 1 commit
- [python-package] [R-package] propagate the best iteration of cvbooster into... · 9a4e7068
  José Morales authored Mar 12, 2022
```
[python-package] [R-package] propagate the best iteration of cvbooster into the individual boosters (#5066)
```
  9a4e7068
26 Feb, 2022 1 commit

[python] fixes for supporting 2d numpy arrays for predictions, grads and hess... · 56313661

Nikita Titov authored Feb 27, 2022


[python] fixes for supporting 2d numpy arrays for predictions, grads and hess in multiclass custom objective and eval (#5030)

* fixes for supporting 2d numpy arrays for predictions, grads and hess in multiclass custom objective

* Apply suggestions from code review
Co-authored-by: José Morales <jmoralz92@gmail.com>
Co-authored-by: José Morales <jmoralz92@gmail.com>

56313661

20 Feb, 2022 1 commit

[docs] clarify that categorical features will be converted to integers internally (#4959) · 820ae7e6

José Morales authored Feb 20, 2022

* clarify that categoricals will be converted to ints and not that they should be ints in the input data

* update remaining sections

* update config.h

* add suggestions

820ae7e6

17 Feb, 2022 1 commit
- [docs] clarify that custom eval functions are not only used on training data (#5011) · 717631af
  James Lamb authored Feb 17, 2022
  
  717631af
16 Feb, 2022 2 commits
- [docs] document rounding behavior of floating point numbers in categorical features (#5009) · 057ba078
  Nikita Titov authored Feb 17, 2022
  
  057ba078
- Change docs for feval (#5002) · d31346f6
  Akshita Dixit authored Feb 16, 2022
  
  d31346f6
15 Feb, 2022 1 commit

[python-package] make record_evaluation compatible with cv (fixes #4943) (#4947) · 9fc348af

José Morales authored Feb 15, 2022

* make record_evaluation compatible with cv

* test multiple metrics in cv

* lint

* fix cv with train metric. save stdv as well

* always add dataset prefix to cv_agg

* remove unused function

9fc348af

26 Dec, 2021 1 commit
- [python] remove `early_stopping_rounds` argument of `train()` and `cv()` functions (#4908) · ce486e5b
  Nikita Titov authored Dec 26, 2021
  
  ce486e5b
23 Dec, 2021 1 commit
- [python] remove `evals_result` argument of `train()` function (#4882) · e4c0ca5f
  Nikita Titov authored Dec 23, 2021
  
  e4c0ca5f
12 Dec, 2021 1 commit
- [python] remove `verbose_eval` argument of `train()` and `cv()` functions (#4878) · 9f13a9c8
  Nikita Titov authored Dec 12, 2021
```
* remove `verbose_eval` argument

* update example Notebook
```
  9f13a9c8
11 Dec, 2021 1 commit
- [python] remove `verbose` argument of `model_from_string()` method of Booster class (#4877) · 80662618
  Nikita Titov authored Dec 11, 2021
  
  80662618
02 Dec, 2021 1 commit

[python-package] fix mypy errors in engine.py (#4839) · 946817a5

James Lamb authored Dec 02, 2021



* [python-package] fix mypy errors in engine.py

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* allow for stdv

* whitespace
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

946817a5

29 Nov, 2021 1 commit
- [python] remove `learning_rates` argument of `train()` function(#4831) · b81f7dd6
  Nikita Titov authored Nov 29, 2021
  
  b81f7dd6
26 Nov, 2021 1 commit
- [python][docs] fix type hints for custom functions and remove vague `array-like` wording (#4816) · 5e9b0209
  Nikita Titov authored Nov 27, 2021
```
* Update sklearn.py

* Update engine.py

* Update sklearn.py

* Update engine.py

* Update basic.py

* Update engine.py
```
  5e9b0209
05 Nov, 2021 1 commit
- [python] improve warning message about aliases in `cv()` function (#4766) · 55e9446a
  Nikita Titov authored Nov 05, 2021
  
  55e9446a
15 Oct, 2021 1 commit
- fix mypy error in engine.py (#4675) · 18a300aa
  Rakshit P authored Oct 15, 2021
  
  18a300aa
15 Sep, 2021 1 commit

[python] rename `print_evaluation()` into `log_evaluation()` (#4604) · 54facc4d

Nikita Titov authored Sep 16, 2021

* Update __init__.py

* Update Python-API.rst

* Update engine.py

* Update test_utilities.py

* Update sklearn.py

* Update callback.py

* Update callback.py

* Update callback.py

54facc4d

12 Sep, 2021 1 commit
- [RFC][python] deprecate advanced args of `train()` and `cv()` functions and sklearn wrapper (#4574) · 86bda6f0
  Nikita Titov authored Sep 12, 2021
```
* deprecate advanced args of `train()` and `cv()`

* update Dask test

* improve deducing

* address review comments
```
  86bda6f0
04 Sep, 2021 1 commit
- [python] deprecate `silent` and standalone `verbose` args. Prefer global `verbose` param (#4577) · 64f15005
  Nikita Titov authored Sep 04, 2021
```
* deprecate `silent` and standalone `verbose` args. Prefer global `verbose` param

* simplify code

* Rephrase warning messages
```
  64f15005
30 Aug, 2021 1 commit
- [docs][python] Refer to functions as callable in docstrings (#4575) · 32445aba
  Nikita Titov authored Aug 30, 2021
  
  32445aba
27 Aug, 2021 2 commits
- [python][docs] Refer to string type as `str` and add commas in `list of ...` types (#4557) · c6199311
  Nikita Titov authored Aug 27, 2021
```
* Reffer to string type as `str` and and commas in `list of ...` types

* update `libpath.py` too
```
  c6199311
- [docs][python] Improve description of `eval_result` argument in `record_evaluation()` (#4559) · 2067bdc5
  Nikita Titov authored Aug 27, 2021
```
* Update callback.py

* Update engine.py
```
  2067bdc5
25 Aug, 2021 1 commit

[python] add type hints on train() in engine.py (#4544) · 13fa6d95

James Lamb authored Aug 26, 2021



* [python] add type hints on train() in engine.py

* revert dask.py and sklearn.py changes

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* update docs on evals_result contents

* Update python-package/lightgbm/engine.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

13fa6d95

07 Jul, 2021 1 commit
- [python] allow to pass some params as pathlib.Path objects (#4440) · 90342e92
  Nikita Titov authored Jul 07, 2021
```
* allow to pass some params as pathlib.Path objects

* fix lint

* improve indentation
```
  90342e92
27 Jun, 2021 1 commit
- [python] replace numpy.zeros with numpy.empty for the speedup (#4410) · 45ac271b
  Nikita Titov authored Jun 27, 2021
  
  45ac271b
12 Jun, 2021 1 commit
- [docs][python] enhance `keep_training_booster` param description (#4364) · 4af4698b
  Nikita Titov authored Jun 12, 2021
  
  4af4698b
05 May, 2021 1 commit
- [python] added f-strings to python-package/lightgbm/engine.py (#4258) · 11b77471
  Kantajit Shaw authored May 06, 2021
  
  11b77471
04 May, 2021 1 commit

Correct spelling (#4250) · e79716e0

Andrew Ziem authored May 04, 2021



* Correct spelling

Most changes were in comments, and there were a few changes to literals for log output.

There were no changes to variable names, function names, IDs, or functionality.

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Correct spelling

Most are code comments, but one case is a literal in a logging message.

There are a few grammar fixes too.
Co-authored-by: James Lamb <jaylamb20@gmail.com>

e79716e0

02 May, 2021 1 commit
- [docs][python] update some docs related to custom objective (#4245) · 1a367c65
  Nikita Titov authored May 02, 2021
  
  1a367c65
16 Feb, 2021 2 commits
- [ci][python] run isort in CI linting job (#3990) · d6ebd063
  Nikita Titov authored Feb 16, 2021
```
* run isort in CI linting job

* workaround conda compatibility issues
```
  d6ebd063
- [ci][python] apply isort to python-package/lightgbm/engine.py #3958 (#3970) · 6110bd15
  Zhuyi Xue authored Feb 16, 2021
  
  6110bd15
25 Jan, 2021 1 commit
- [dask][docs] initial setup for Dask docs (#3822) · 36322cee
  Nikita Titov authored Jan 25, 2021
```
* initial Dask docs

* fix MRO

* address review comments
```
  36322cee
24 Jan, 2021 1 commit

[python] Allow to register custom logger in Python-package (#3820) · b7ccdaf0

Nikita Titov authored Jan 24, 2021

* centralize Python-package logging in one place

* continue

* fix test name

* removed unused import

* enhance test

* fix lint

* hotfix test

* workaround for GPU test

* remove custom logger from Dask-package

* replace one log func with flags by multiple funcs

b7ccdaf0

19 Jan, 2021 1 commit
- [docs] fix current RTD failures (#3787) · 78778085
  Nikita Titov authored Jan 19, 2021
```
* fix docs

* Update basic.py

* Update engine.py
```
  78778085
09 Dec, 2020 1 commit

[python] Drop Python 2 support (#3581) · 44a6fb7f

Nikita Titov authored Dec 09, 2020

* Update setup.py

* Update .appveyor.yml

* Update .travis.yml

* Update .vsts-ci.yml

* Update __init__.py

* Update test.sh

* Update test_windows.ps1

* Update advanced_example.py

* Update requirements_base.txt

* Update conf.py

* Update conf.py

* Update test_engine.py

* Update utils.py

* Update dockerfile-r

* Update README.md

* Update dockerfile.gpu

* Update test_consistency.py

* Update basic.py

* Update compat.py

* Update engine.py

* Update sklearn.py

* Update sklearn.py

* Update callback.py

* Update setup.py

* Update __init__.py

* Update plotting.py

* Update sklearn.py

* Update engine.py

* Update compat.py

* Update callback.py

* Update basic.py

* Update compat.py

* Update basic.py

* Update basic.py

* Update compat.py

* Update compat.py

* Update plotting.py

* Update engine.py

* Update basic.py

* Update sklearn.py

* Update compat.py

* Update engine.py

* Update engine.py

* Update callback.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update sklearn.py

* Update sklearn.py

* Update plotting.py

* Update sklearn.py

* Update compat.py

* Update compat.py

* Update engine.py

* Update plotting.py

* Update sklearn.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update compat.py

* Update compat.py

* Update compat.py

* Update engine.py

* Update basic.py

* Update compat.py

* Update basic.py

* Update basic.py

* Update basic.py

* Update compat.py

* Update compat.py

* Update basic.py

* Update basic.py

* Update .vsts-ci.yml

* Update .vsts-ci.yml

* Update conf.py

* Revert "Update dockerfile-r"

This reverts commit 4ff6ffc7e3eeda24cc6a59a3bb0c973f02d9d71c.

44a6fb7f

06 Sep, 2020 1 commit

[Python] Refactor scikit-learn API to allow a list of evaluation metrics (#3254) · afc76d2c

Germán Ramírez-Espinoza authored Sep 07, 2020



* Refactors sklearn API to allow a list of evaluation metrics in the parameter eval_metric of the class (and subclasses of) LGBMModel. Also adds unit tests for this functionality

* Simplify expression to check whether the user passed one or multiple metrics to eval_metric parameter

* Simplify new tests by using custom metrics already defined in the test file

* Update docstring to reflect the fact that the parameter "feval" from the "train" and "cv" functions can also receive a list of callables

* Remove oxford comma from docstrings

Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Use named-parameters to make sure code is compatible with future versions of scikit-learn

Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Remove throwaway return value to make code more succinct
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Move statement to group together the code related to feval

* Avoid modifying original args as it causes errors in scikit-learn tools

For details see: https://github.com/microsoft/LightGBM/pull/2619



* Consolidate multiple eval-metrics unit-tests into one test
Co-authored-by: German I Ramirez-Espinoza <gire@home>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

afc76d2c

06 Aug, 2020 1 commit

[doc] better doc for `keep_training_booster` (#3275) · 6f54ec3d

Guolin Ke authored Aug 06, 2020



* [doc] better doc for `keep_training_booster`

* Update python-package/lightgbm/engine.py
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

6f54ec3d

02 Aug, 2020 1 commit

[python] add return_cvbooster flag to cv func and publish _CVBooster (#283,#2105,#1445) (#3204) · 1d59a045

momijiame authored Aug 03, 2020



* [python] add return_cvbooster flag to cv function and rename _CVBooster to make public (#283,#2105)

* [python] Reduce expected metric of unit testing

* [docs] add the CVBooster to the documentation

* [python] reflect the review comments

- Add some clarifications to the documentation
- Rename CVBooster.append to make private
- Decrease iteration rounds of testing to save CI time
- Use CVBooster as root member of lgb

* [python] add more checks in testing for cv
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* [python] add docstring for instance attributes of CVBooster
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* [python] fix docstring
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

1d59a045