Commits · 2c8bb45b2c4408876433c866683515dacce9b1b0 · tianlh / LightGBM-DCU

10 Sep, 2021 1 commit

[R-package] avoid unnecessary computation and add tests for Dataset set_reference() method (#4587) · a08c37f6

James Lamb authored Sep 10, 2021



* [R-package] avoid unnecessary computation in Dataset set_reference() method

* re-arrange conditions

* do more validation upfront and add tests

* Update R-package/tests/testthat/test_dataset.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/tests/testthat/test_dataset.R
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

a08c37f6

02 Sep, 2021 2 commits

[R-package] fix inaccurate error message in Dataset get_colnames() method (#4588) · dc09d1b4

James Lamb authored Sep 02, 2021



* [R-package] fix inaccurate log message in Dataset get_colnames() method

* Update R-package/R/lgb.Dataset.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

dc09d1b4

[R-package] preserve uses of '...' in Dataset slice() method (#4581) · e0d93b5d

James Lamb authored Sep 02, 2021



* [R-package] preserve uses of '...' in Dataset slice() method

* Update R-package/R/lgb.Dataset.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

e0d93b5d

01 Sep, 2021 2 commits

[R-package] fix inaccurate comments, remove unnecessary comments (#4582) · a0d227a1
James Lamb authored Sep 01, 2021

a0d227a1

[R-package] deprecate the use of 'info' in Dataset (#4573) · 4ee6399d

James Lamb authored Sep 01, 2021



* [R-package] introduce keyword arguments for Dataset properties

* adding examples

* trying to fix loading issues

* add check on use of info and fix examples

* eliminate one '...'

* Update R-package/R/lgb.Dataset.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/R/lgb.Dataset.R

* Dataset get_params() is public
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

4ee6399d

30 Aug, 2021 1 commit

[R-package] deprecate uses of '...' in Dataset slice() method (#4572) · c27ebcd8

James Lamb authored Aug 30, 2021



* [R-package] deprecate uses of '...' in Dataset slice() method

* Update R-package/R/lgb.Dataset.R

* Update R-package/R/lgb.Dataset.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

c27ebcd8

29 Aug, 2021 2 commits

[R-package] fix warnings in demos (#4569) · 846e8954

James Lamb authored Aug 29, 2021



* [R-package] fix warnings in demos

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* fix additional params issues in multiclass and categorical_feature examples

* Update R-package/demo/multiclass.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

846e8954

[R-package] fix warnings in examples (#4568) · b4213e96
James Lamb authored Aug 29, 2021
```
* [R-package] fix warnings in examples

* fix silently-ignored parameter
```
b4213e96

28 Aug, 2021 1 commit
- [R-package] use {testthat} SummaryReporter in tests (#4567) · b765fa6e
  James Lamb authored Aug 28, 2021
  
  b765fa6e
25 Aug, 2021 3 commits

[R-package] remove unused code checking has_header in Dataset() (fixes #4553) (#4554) · f5925c3f
James Lamb authored Aug 25, 2021

f5925c3f
[R-package] add deprecation warnings on uses of '...' in predict() and reset_parameter() (#4548) · bd28a364
James Lamb authored Aug 25, 2021
```
* [R-package] add deprecation warnings on uses of '...' in predict()

* add importFrom(utils, modifyList) in NAMESPACE
```
bd28a364

[docs] Clarify the fact that predict() on a file does not support saved... · 417ba192

James Lamb authored Aug 25, 2021


[docs] Clarify the fact that predict() on a file does not support saved Datasets (fixes #4034) (#4545)

* documentation changes

* add list of supported formats to error message

* add unit tests

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* update per review comments

* make references consistent
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

417ba192

19 Aug, 2021 1 commit

[R-package] fix OpenMP checking on macOS (fixes #4131) (#4507) · dbccc1e7

James Lamb authored Aug 19, 2021

* [R-package] fix OpenMP checking on macOS

* adding clang flags back

* fix detection on Mac

* remove CC since it is now unused

* use flags specific to C++11

* regenerate configure

dbccc1e7

18 Aug, 2021 2 commits

[R-package] remove unused '...' in Booster constructor (#4523) · a7ff1172
James Lamb authored Aug 18, 2021
```
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>
```
a7ff1172

[R-package] pass R-configured compiler flags to checks in configure (#4506) · 2edb8188

James Lamb authored Aug 18, 2021



* [R-package] pass compiler flags to checks in configure

* leave OpenMP check alone

* prefer C++11 flags

* install Matrix in valgrind tests

* one less AC_LANG() call
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>

2edb8188

17 Aug, 2021 1 commit
- [R-package] add deprecation warnings about some uses of '...' (#4522) · 112db8ab
  James Lamb authored Aug 17, 2021
```
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>
```
  112db8ab
14 Aug, 2021 1 commit

[R-package] use C++ compiler for pre-compile checks on Windows (#4504) · 86ead205

James Lamb authored Aug 14, 2021



* [R-package] use C++ compiler for pre-compile checks on Windows

* install Matrix in valgrind test

* Add {Matrix} in more places in CI and docs

* use CXX11

* use flags specific to C++11

* missing backtick
Co-authored-by: Nikita Titov <nekit94-12@hotmail.com>

86ead205

09 Aug, 2021 1 commit
- [R-package] remove unused variable `R_SCRIPT` in configure.win (#4505) · 2f376426
  James Lamb authored Aug 09, 2021
  
  2f376426
30 Jul, 2021 1 commit
- [R-package] limit exported symbols in DLL (#4494) · 5d5f4909
  James Lamb authored Jul 30, 2021
  
  5d5f4909
27 Jun, 2021 1 commit

[R-package] fix protection stack imbalance and unprotected objects (fixes #4390) (#4391) · aacb4c8f

Fabio Sigrist authored Jun 27, 2021



* [R-package] fix protection stack imbalance and unprotected objects issues

* [R-package] fix minor linting issues

* [ci][R-package] change timeout-minutes in valgrind test

* [R-package] remove extra space
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* [R-package] remove counter for number of protected objects

* Update .github/workflows/r_valgrind.yml
Co-authored-by: James Lamb <jaylamb20@gmail.com>

aacb4c8f

26 Jun, 2021 1 commit
- fix param aliases (#4387) · aab8fc18
  Nikita Titov authored Jun 26, 2021
  
  aab8fc18
22 Jun, 2021 1 commit

[docs][R-package] add authors in R-package description (#4395) · 0ca2c494

Nikita Titov authored Jun 22, 2021



* add authors in R-package description

* Update R-package/DESCRIPTION
Co-authored-by: James Lamb <jaylamb20@gmail.com>

0ca2c494

17 Jun, 2021 1 commit
- [R-package] remove unnecessary comments (#4383) · 4167649c
  James Lamb authored Jun 17, 2021
```
* [R-package] remove unnecessary comments

* Update R-package/R/lgb.Booster.R
```
  4167649c
16 Jun, 2021 1 commit
- [R-package] consolidate duplicate lists of Dataset info keys (#4381) · 4530deda
  James Lamb authored Jun 16, 2021
```
* [R-package] consolidate duplicate lists of Dataset info keys

* remove extra parentheses
```
  4530deda
15 Jun, 2021 1 commit

[ci] [R-package] add unit tests on monotone constraints (#4352) · a592316a

James Lamb authored Jun 15, 2021

* [R-package] add unit tests on monotone constraints

* testing without skip()

* put skip() back

* make tests consistent with Python

* Update R-package/tests/testthat/test_basic.R

* more changes for consistency with Python tests

a592316a

13 Jun, 2021 1 commit

[R-package] move more finalizer logic into C++ side to address memory leaks (#4353) · 53ffba7c

James Lamb authored Jun 13, 2021



* [R-package] move more finalizer logic intoo C++ side

* add C finalizers

* use gc()

* put skip() back

* Update R-package/tests/testthat/test_lgb.Booster.R
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

53ffba7c

12 Jun, 2021 1 commit
- [R-package] avoid unnecessary computation of std deviations in `lgb.cv()` (#4360) · f0bca1a2
  James Lamb authored Jun 12, 2021
```
* [R-package] avoid unnecessary computation of std deviations in lgb.cv()

* use expect_equal()
```
  f0bca1a2
09 Jun, 2021 1 commit
- [R-package] remove defaults in internal functions (#4361) · a8fae81f
  James Lamb authored Jun 09, 2021
  
  a8fae81f
08 Jun, 2021 1 commit
- [R-package] remove unnecessary library() calls in tests (#4354) · 063e7317
  James Lamb authored Jun 08, 2021
  
  063e7317
06 Jun, 2021 1 commit
- [R-package] resolve test warning about is.na() and handles (#4341) · 20e63387
  James Lamb authored Jun 06, 2021
  
  20e63387
05 Jun, 2021 3 commits
- [R-package] factor out lgb.check.r6.class() (#4343) · 4ccf92be
  James Lamb authored Jun 05, 2021
```
* [R-package] factor out lgb.check.r6.class()

* Predictor
```
  4ccf92be
- [R-package] remove lgb.last_error() and LGBM_GetLastError_R() (#4344) · 441f38bb
  James Lamb authored Jun 05, 2021
  
  441f38bb
- [R-package] remove unused argument in early stopping callback (#4342) · 3837e60d
  James Lamb authored Jun 05, 2021
  
  3837e60d
04 Jun, 2021 2 commits
- [R-package] remove uses of ... in Predictor constructor (#4338) · c45a82f0
  James Lamb authored Jun 04, 2021
  
  c45a82f0
- [R-package] remove unused code in lgb.params2str() (#4337) · 2b485ce5
  James Lamb authored Jun 04, 2021
  
  2b485ce5
21 May, 2021 1 commit

fix calculation of weighted gamma loss (fixes #4174) (#4283) · 4b1b4124

Michael Mayer authored May 21, 2021

* fixed weighted gamma obj

* added unit tests

* fixing linter errors

* another linter

* set seed

* fix linter (integer seed)

4b1b4124

15 May, 2021 1 commit

[R-package] Handle integer types more accurate in R-to-C interface (#4291) · 90677e43

Nikita Titov authored May 15, 2021

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* Update lightgbm_R.cpp

* fix typos

90677e43

12 May, 2021 1 commit

[R-package] manage Dataset and Booster handles as R external pointers (fixes #3016) (#4265) · 676c95fb

James Lamb authored May 12, 2021



* started converting handles

* more changes

* sort of working for Dataset

* yay all the tests are passing for Dataset handle changes

* working for other handle types

* remove debugging logging

* remove unnecessary spaces

* fix null logic

* more NULL

* updates

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* consolidate steps
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

676c95fb

10 May, 2021 1 commit
- [docs] remove extra spaces in comments and docs (#4269) · a8ee487a
  James Lamb authored May 10, 2021
  
  a8ee487a
09 May, 2021 1 commit

[R-package] move creation of character vectors in some methods to C++ side (#4256) · c1d2dbe2

James Lamb authored May 09, 2021



* [R-package] move creation of character vectors in some methods to C++ side

* convert LGBM_BoosterGetEvalNames_R

* convert LGBM_BoosterDumpModel_R and LGBM_BoosterSaveModelToString_R

* remove debugging code

* update docs

* remove comment

* add handling for larger model strings

* handle large strings in feature and eval names

* got long feature names working

* more fixes

* linting

* resize

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* stricter test
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

c1d2dbe2