Commits · 0246721303e492bb563263d7ad0aad081a22b606 · tianlh / LightGBM-DCU

06 May, 2021 1 commit

[docs][R-package] update docs on C++ interface (#4257) · 02467213

James Lamb authored May 06, 2021



* [R-package] update docs on C++ interface

* Update R-package/src/lightgbm_R.h
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Update R-package/src/lightgbm_R.h
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* add missing start_iteration doc
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

02467213

05 May, 2021 1 commit
- [python] added f-strings to python-package/lightgbm/engine.py (#4258) · 11b77471
  Kantajit Shaw authored May 06, 2021
  
  11b77471
04 May, 2021 4 commits

fix param name (#4253) · fcd24535
Nikita Titov authored May 05, 2021
```
* fix param name

* Update gpu_tree_learner.h

* Update gbdt.h
```
fcd24535
[R-package] Use R standard routines to access character data in C++ (#4252) · ec874325
James Lamb authored May 04, 2021
```
* converted LGBM_BoosterSaveModel_R

* switch all other non-params cases

* handle params
```
ec874325
[ci] Delete lock.yml (#4251) · d511f1a7
Nikita Titov authored May 04, 2021

d511f1a7

Correct spelling (#4250) · e79716e0

Andrew Ziem authored May 04, 2021



* Correct spelling

Most changes were in comments, and there were a few changes to literals for log output.

There were no changes to variable names, function names, IDs, or functionality.

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Clarify a phrase in a comment
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Correct spelling

Most are code comments, but one case is a literal in a logging message.

There are a few grammar fixes too.
Co-authored-by: James Lamb <jaylamb20@gmail.com>

e79716e0

03 May, 2021 2 commits

[R-package] Use R standard routines to access numeric and integer array data in C++ (#4247) · bb88d92e
James Lamb authored May 03, 2021
```
* real pointer for matrix

* remove R_REAL_PTR

* remove R_INT_PTR

* add test
```
bb88d92e

[R-package] use R standard routine to access read-only ints passed to C++ (#4246) · aedfdd0d

James Lamb authored May 03, 2021



* [R-package] replace R_AS_INT with R built-in

* update header

* more changes

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

aedfdd0d

02 May, 2021 3 commits
- [R-package] move Rinternals.h closer to where it is used (#4248) · d29f2c2a
  James Lamb authored May 02, 2021
  
  d29f2c2a
- [R-package] Convert LGBM_GetLastError_R to use R built-in types (#4242) · 66ee2919
  James Lamb authored May 02, 2021
```
* [R-package] move some functions over to SEXP objects

* clarify comment

* remove paste0()

* fix registration table

* fix cmake builds
```
  66ee2919
- [docs][python] update some docs related to custom objective (#4245) · 1a367c65
  Nikita Titov authored May 02, 2021
  
  1a367c65
01 May, 2021 1 commit
- [R-package] remove pre-allocated call_state in C++ calls (#4244) · 26cde5f5
  James Lamb authored May 01, 2021
  
  26cde5f5
30 Apr, 2021 2 commits

[R-package] prevent symbol lookup conflicts (fixes #4045) (#4155) · b27dcfa4

James Lamb authored Apr 30, 2021

* [R-package] prevent symbol lookup conflicts

* add unit tests

* only run test on Windows

* move to .Call() calls

* fix references

* testing registration for CMake builds

* revert NAMESPACE changes

* revert testing changes

b27dcfa4

[docs][python][scikit-learn] added note for LGBMRanker (#4243) · 023dc53d
Nikita Titov authored Apr 30, 2021

023dc53d

29 Apr, 2021 2 commits

[ci] Install graphviz system-widely (#4238) · 91f72e2a

Nikita Titov authored Apr 30, 2021

* Install graphviz from default conda channel

* Update test.sh

* Update setup.sh

* Update test.sh

* Update setup.sh

* Update setup.sh

* Update setup.sh

* Update setup.sh

* Update setup.sh

* Update setup.sh

91f72e2a

show specific error message in TCP accept/send/receive logs (#4128) · f97aa86e
James Lamb authored Apr 28, 2021

f97aa86e

28 Apr, 2021 2 commits
- [R-package] avoid misleading warnings when using interaction constraints (fixes #4108) (#4232) · fa6d3565
  James Lamb authored Apr 28, 2021
  
  fa6d3565
- [ci][python-package] remove unused import in tests (#4233) · 086f0785
  James Lamb authored Apr 28, 2021
  
  086f0785
27 Apr, 2021 1 commit
- Fix typo in binary file already exists error message. (#4231) · d5c2c556
  Chen Yufei authored Apr 27, 2021
  
  d5c2c556
26 Apr, 2021 2 commits
- [R-package] fix warnings in unit tests (#4225) · 5014f19f
  James Lamb authored Apr 26, 2021
  
  5014f19f
- [python][scikit-learn] change MRO (#3192) · b6c71e5e
  Nikita Titov authored Apr 26, 2021
```
* chanche MRO

* fix MRO resolution
```
  b6c71e5e
25 Apr, 2021 2 commits
- [docs] fix broken MS MPI link in Installation Guide (#4224) · eb7a1b7c
  James Lamb authored Apr 25, 2021
  
  eb7a1b7c
- [ci][docs] Unpin Breathe version in requirements.txt (#4222) · 0b1c0222
  Nikita Titov authored Apr 25, 2021
```
This reverts commit 536946e3.
```
  0b1c0222
23 Apr, 2021 1 commit
- added aliases to params (#4205) · 8b477ba3
  Nikita Titov authored Apr 23, 2021
  
  8b477ba3
22 Apr, 2021 3 commits
- [R-package] Move error handling into C++ side (#4163) · 1e95cb09
  James Lamb authored Apr 21, 2021
```
* [R-package] raise errors from C++ side

* working but a lot of warnings

* more changes

* simplify

* cleanup

* linting

* fix valgrind issues

* revert unnecessary change
```
  1e95cb09
- when a leaf has no local data, its histogram shuold be cleared (#4185) · 0a847efe
  shiyu1994 authored Apr 22, 2021
  
  0a847efe
- [R-package] fix grammar in comments · 13d0ceee
  david-cortes authored Apr 22, 2021
  
  13d0ceee
21 Apr, 2021 1 commit

[dask] Fix typo mentioned in 4101 (#4214) · 887ef4cc

Frank Fineis authored Apr 21, 2021



* fix typo in dask _train as mentioned in 4101

* Update python-package/lightgbm/dask.py
Co-authored-by: James Lamb <jaylamb20@gmail.com>

887ef4cc

20 Apr, 2021 1 commit
- [ci] parallelize R package installs in CI jobs (#4198) · 72d7010b
  James Lamb authored Apr 20, 2021
```
* [ci] parallelize R package installs in CI jobs

* build 2

* build 3

* add ncpus in static_analysis
```
  72d7010b
19 Apr, 2021 4 commits

[R-package] clarify parameter documentation (fixes #4193) (#4202) · 53602afa
James Lamb authored Apr 19, 2021
```
* [R-package] clarify parameter documentation

* fixes to braces

* linting
```
53602afa

[python] Migrate to f-strings in python-package/lightgbm/sklearn.py (#4188) · 8e126c80

Akshita Dixit authored Apr 19, 2021



* Migrate to f-strings in python-package/lightgbm/sklearn.py

* Apply suggestions from code review
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update python-package/lightgbm/sklearn.py
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Apply suggestions from code review
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* Add suggestions from code review

* resolve conflicts

* Apply suggestions from code review
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update sklearn.py
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

8e126c80

[R-package] change default nrounds to 100 to match LightGBM core library default (#4197) · c109a595

david-cortes authored Apr 19, 2021



* use same default arguments as python

* Update R-package/R/lgb.cv.R

Changed.
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* revert change in docs
Co-authored-by: James Lamb <jaylamb20@gmail.com>

c109a595

[docs][R-package] Update the explanation of num_threads (fixes #4192) (#4199) · e12409fd

Issac Lee authored Apr 19, 2021

* update the explanation of num_threads in lightgbm.R

* adjusted sentences for linting.

* remove white space for lintr pass

* add note about num_thread param in files

e12409fd

18 Apr, 2021 2 commits

[R-package] Make returned feature importances from lgb.importance() visible by default (#4194) · 69d02e38

david-cortes authored Apr 19, 2021



* Return feature importances as visible

Feature importances are returned as invisible. I don't get why would anyone want them invisible. This PR fixes it.

* Update R-package/R/lgb.importance.R

Thanks, didn't realize that, changed now.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>

69d02e38

[docs] add working dir to R package docker run examples (#4190) · 7ea2bc4d
James Lamb authored Apr 17, 2021

7ea2bc4d

17 Apr, 2021 2 commits

[docs] fix markdown in docs (#4191) · dac77493
Nikita Titov authored Apr 18, 2021

dac77493

[docs] Add changes to gcc-tips (#4187) · 50bca9e4

Akshita Dixit authored Apr 17, 2021



* Add changes to gcc-tips

* Update docs/gcc-Tips.rst
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Update docs/gcc-Tips.rst
Co-authored-by: James Lamb <jaylamb20@gmail.com>

* Remove image files for gcc-tips
Co-authored-by: James Lamb <jaylamb20@gmail.com>

50bca9e4

16 Apr, 2021 3 commits
- [ci] run cpp tests at CI (#4166) · 211ef787
  Nikita Titov authored Apr 16, 2021
```
* run cpp tests at CI

* Update docs/Installation-Guide.rst
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
```
  211ef787
- [ci] unpin CMake version for CUDA + Clang toolchain (#4183) · 3fd9b275
  Nikita Titov authored Apr 16, 2021
```
This reverts commit ab474dc4.
```
  3fd9b275
- [docs] bring back macOS installation method with Homebrew formula in docs (#4182) · fba18e48
  Nikita Titov authored Apr 16, 2021
```
This reverts commit e98da99d.
```
  fba18e48