Fixed gcc non virtual destructor warning (bin.h) and ignored const specifier (dataset.h) (#273)

cba87c37 · cbecker · Guolin Ke · 4f3e9d89 · cba87c37 · cba87c37
Commit cba87c37 authored Jan 30, 2017 by cbecker Committed by Guolin Ke Jan 31, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

include/LightGBM/bin.h include/LightGBM/bin.h +1 -0

include/LightGBM/dataset.h include/LightGBM/dataset.h +1 -1

No files found.
--- a/include/LightGBM/bin.h
+++ b/include/LightGBM/bin.h
@@ -242,6 +242,7 @@ public:
  * \return Bin data
  */
  virtual uint32_t Get(data_size_t idx) = 0;
+  virtual ~BinIterator() = default;
 };

 /*!

--- a/include/LightGBM/dataset.h
+++ b/include/LightGBM/dataset.h
@@ -173,7 +173,7 @@ public:
  * \brief Get Number of queries
  * \return Number of queries
  */
-  inline const data_size_t num_queries() const { return num_queries_; }
+  inline data_size_t num_queries() const { return num_queries_; }

  /*!
  * \brief Get weights for queries, if not exists, will return nullptr