dump_model() bug with num_leaves=1

c45ec4f1 · Guolin Ke · GitHub · 24ad35f7 · c45ec4f1
Unverified Commit c45ec4f1 authored Apr 29, 2019 by Guolin Ke Committed by GitHub Apr 29, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

src/io/tree.cpp src/io/tree.cpp +6 -6

No files found.
--- a/src/io/tree.cpp
+++ b/src/io/tree.cpp
@@ -506,6 +506,12 @@ Tree::Tree(const char* str, size_t* used_len) {
  } else {
    Log::Fatal("Tree model string format error, should contain leaf_value field");
  }
+  
+  if (key_vals.count("shrinkage")) {
+    Common::Atof(key_vals["shrinkage"].c_str(), &shrinkage_);
+  } else {
+    shrinkage_ = 1.0f;
+  }

  if (num_leaves_ <= 1) { return; }

@@ -576,12 +582,6 @@ Tree::Tree(const char* str, size_t* used_len) {
      Log::Fatal("Tree model should contain cat_threshold field");
    }
  }
-
-  if (key_vals.count("shrinkage")) {
-    Common::Atof(key_vals["shrinkage"].c_str(), &shrinkage_);
-  } else {
-    shrinkage_ = 1.0f;
-  }
  max_depth_ = -1;
 }