fix missing value handle in forced split (#1809)

c3f10a1b · Guolin Ke · Qiwei Ye · ef4b5be5 · c3f10a1b
Commit c3f10a1b authored Oct 31, 2018 by Guolin Ke Committed by Qiwei Ye Oct 31, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

src/treelearner/feature_histogram.hpp src/treelearner/feature_histogram.hpp +3 -5

No files found.
--- a/src/treelearner/feature_histogram.hpp
+++ b/src/treelearner/feature_histogram.hpp
@@ -299,13 +299,11 @@ public:
    data_size_t right_count = 0;
    // set values
-    bool use_na_as_missing;
+    bool use_na_as_missing = false;
-    bool skip_default_bin;
+    bool skip_default_bin = false;
    if (meta_->missing_type == MissingType::Zero) {
      skip_default_bin = true;
-      use_na_as_missing = false;
+    } else if (meta_->missing_type == MissingType::NaN) {
-    } else {
-      skip_default_bin = false;
      use_na_as_missing = true;
    }