Skip to content

GitLab

Unverified Commit b8cc8738 authored by James Lamb's avatar James Lamb Committed by GitHub
Browse files

[python-package] make Booster and Dataset 'handle' attributes private (fixes #5313) (#5947)

parent 9edea60e
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 129 additions and 128 deletions
python-package/lightgbm/basic.py
View file @ b8cc8738
This diff is collapsed.
tests/python_package_test/test_basic.py
View file @ b8cc8738
......@@ -393,11 +393,11 @@ def test_add_features_does_not_fail_if_initial_dataset_has_zero_informative_feat
dataset_b = lgb.Dataset(arr_b).construct()
original_handle = dataset_a.handle.value
original_handle = dataset_a._handle.value
dataset_a.add_features_from(dataset_b)
assert dataset_a.num_feature() == 6
assert dataset_a.num_data() == 100
assert dataset_a.handle.value == original_handle
assert dataset_a._handle.value == original_handle
def test_cegb_affects_behavior(tmp_path):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment