skip empty bin when calculating cnt_in_bin in BinMapper::FindBin (fix #4301) (#4325)

3dd4a3f9 · shiyu1994 · GitHub · 36957ed5 · 3dd4a3f9
Unverified Commit 3dd4a3f9 authored Jun 03, 2021 by shiyu1994 Committed by GitHub Jun 02, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

src/io/bin.cpp src/io/bin.cpp +1 -1

No files found.
--- a/src/io/bin.cpp
+++ b/src/io/bin.cpp
@@ -411,7 +411,7 @@ namespace LightGBM {
        cnt_in_bin.resize(num_bin_, 0);
        int i_bin = 0;
        for (int i = 0; i < num_distinct_values; ++i) {
-          if (distinct_values[i] > bin_upper_bound_[i_bin]) {
+          while (distinct_values[i] > bin_upper_bound_[i_bin] && i_bin < num_bin_ - 1) {
            ++i_bin;
          }
          cnt_in_bin[i_bin] += counts[i];