Unverified Commit 296b2a26 authored by Alberto Ferreira's avatar Alberto Ferreira Committed by GitHub
Browse files

[python-package] Some mypy fixes (#3916)

* Some mypy fixes

* address James' comments

* Re-introduce pass in empty classes

* Update compat.py

Remove extra lines
parent dc1bc23a
...@@ -26,7 +26,7 @@ class EarlyStopException(Exception): ...@@ -26,7 +26,7 @@ class EarlyStopException(Exception):
# Callback environment used by callbacks # Callback environment used by callbacks
CallbackEnv = collections.namedtuple( CallbackEnv = collections.namedtuple(
"LightGBMCallbackEnv", "CallbackEnv",
["model", ["model",
"params", "params",
"iteration", "iteration",
......
...@@ -11,12 +11,12 @@ try: ...@@ -11,12 +11,12 @@ try:
except ImportError: except ImportError:
PANDAS_INSTALLED = False PANDAS_INSTALLED = False
class pd_Series: class pd_Series: # type: ignore
"""Dummy class for pandas.Series.""" """Dummy class for pandas.Series."""
pass pass
class pd_DataFrame: class pd_DataFrame: # type: ignore
"""Dummy class for pandas.DataFrame.""" """Dummy class for pandas.DataFrame."""
pass pass
...@@ -49,7 +49,7 @@ try: ...@@ -49,7 +49,7 @@ try:
except ImportError: except ImportError:
DATATABLE_INSTALLED = False DATATABLE_INSTALLED = False
class dt_DataTable: class dt_DataTable: # type: ignore
"""Dummy class for datatable.DataTable.""" """Dummy class for datatable.DataTable."""
pass pass
...@@ -123,17 +123,17 @@ except ImportError: ...@@ -123,17 +123,17 @@ except ImportError:
default_client = None default_client = None
wait = None wait = None
class dask_Array: class dask_Array: # type: ignore
"""Dummy class for dask.array.Array.""" """Dummy class for dask.array.Array."""
pass pass
class dask_DataFrame: class dask_DataFrame: # type: ignore
"""Dummy class for dask.dataframe.DataFrame.""" """Dummy class for dask.dataframe.DataFrame."""
pass pass
class dask_Series: class dask_Series: # type: ignore
"""Dummy class for dask.dataframe.Series.""" """Dummy class for dask.dataframe.Series."""
pass pass
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment