fix #1504

1e53445e · Guolin Ke · GitHub · dae75516 · 1e53445e
Unverified Commit 1e53445e authored Jul 12, 2018 by Guolin Ke Committed by GitHub Jul 12, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 9 deletions

src/io/config.cpp src/io/config.cpp +7 -9

No files found.
--- a/src/io/config.cpp
+++ b/src/io/config.cpp
@@ -214,15 +214,13 @@ void Config::CheckParamConflict() {
      Log::Fatal("Number of classes must be 1 for non-multiclass training");
    }
  }
-  if (is_provide_training_metric || !valid.empty()) {
+  for (std::string metric_type : metric) {
-    for (std::string metric_type : metric) {
+    bool metric_type_multiclass = (CheckMultiClassObjective(metric_type) 
-      bool metric_type_multiclass = (CheckMultiClassObjective(metric_type) 
+                                    || metric_type == std::string("multi_logloss")
-                                     || metric_type == std::string("multi_logloss")
+                                    || metric_type == std::string("multi_error"));
-                                     || metric_type == std::string("multi_error"));
+    if ((objective_type_multiclass && !metric_type_multiclass)
-      if ((objective_type_multiclass && !metric_type_multiclass)
+      || (!objective_type_multiclass && metric_type_multiclass)) {
-        || (!objective_type_multiclass && metric_type_multiclass)) {
+      Log::Fatal("Multiclass qbjective and metrics don't match");
-        Log::Fatal("Objective and metrics don't match");
-      }
    }
  }