Commit 0c5f390a authored by yvandenis's avatar yvandenis Committed by Guolin Ke
Browse files

Enabling feature_fraction == 1.0f in ResetConfig (#1902)

Init has been updated to allow for feature_fraction == 1.0f but the change has not been copyed in the ResetConfig function.
parent 7282533a
...@@ -52,7 +52,7 @@ public: ...@@ -52,7 +52,7 @@ public:
void ResetConfig(const Config* config) override { void ResetConfig(const Config* config) override {
CHECK(config->bagging_freq > 0 && config->bagging_fraction < 1.0f && config->bagging_fraction > 0.0f); CHECK(config->bagging_freq > 0 && config->bagging_fraction < 1.0f && config->bagging_fraction > 0.0f);
CHECK(config->feature_fraction < 1.0f && config->feature_fraction > 0.0f); CHECK(config->feature_fraction <= 1.0f && config->feature_fraction > 0.0f);
GBDT::ResetConfig(config); GBDT::ResetConfig(config);
// not shrinkage rate for the RF // not shrinkage rate for the RF
shrinkage_rate_ = 1.0f; shrinkage_rate_ = 1.0f;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment