Unverified Commit 80f27d7e authored by Sayak Paul's avatar Sayak Paul Committed by GitHub
Browse files

[tests] skip instead of returning. (#11793)

skip instead of returning.
parent d3e27e05
...@@ -2107,7 +2107,7 @@ class LoraHotSwappingForModelTesterMixin: ...@@ -2107,7 +2107,7 @@ class LoraHotSwappingForModelTesterMixin:
@parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa @parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa
def test_hotswapping_compiled_model_conv2d(self, rank0, rank1): def test_hotswapping_compiled_model_conv2d(self, rank0, rank1):
if "unet" not in self.model_class.__name__.lower(): if "unet" not in self.model_class.__name__.lower():
return pytest.skip("Test only applies to UNet.")
# It's important to add this context to raise an error on recompilation # It's important to add this context to raise an error on recompilation
target_modules = ["conv", "conv1", "conv2"] target_modules = ["conv", "conv1", "conv2"]
...@@ -2117,7 +2117,7 @@ class LoraHotSwappingForModelTesterMixin: ...@@ -2117,7 +2117,7 @@ class LoraHotSwappingForModelTesterMixin:
@parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa @parameterized.expand([(11, 11), (7, 13), (13, 7)]) # important to test small to large and vice versa
def test_hotswapping_compiled_model_both_linear_and_conv2d(self, rank0, rank1): def test_hotswapping_compiled_model_both_linear_and_conv2d(self, rank0, rank1):
if "unet" not in self.model_class.__name__.lower(): if "unet" not in self.model_class.__name__.lower():
return pytest.skip("Test only applies to UNet.")
# It's important to add this context to raise an error on recompilation # It's important to add this context to raise an error on recompilation
target_modules = ["to_q", "conv"] target_modules = ["to_q", "conv"]
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment