Skip to content

GitLab

Commit c128c2ed authored by Woosuk Kwon's avatar Woosuk Kwon
Browse files

Fix double free

parent c80ed212
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
cacheflow/master/block_manager.py
View file @ c128c2ed
...@@ -115,13 +115,13 @@ class BlockSpaceManager: ...@@ -115,13 +115,13 @@ class BlockSpaceManager:
last_block = block_table[-1] last_block = block_table[-1]
assert last_block.device == Device.GPU assert last_block.device == Device.GPU
if last_block.ref_count == 1: if last_block.ref_count == 1:
# Append. # Not shared with other sequences. Appendable.
return None return None
else: else:
# The last block is shared with other sequences. # The last block is shared with other sequences.
# Copy on Write: Allocate a new block and copy the tokens. # Copy on Write: Allocate a new block and copy the tokens.
new_block = self.gpu_allocator.allocate() new_block = self.gpu_allocator.allocate()
block_table.append(new_block) block_table[-1] = new_block
self.gpu_allocator.free(last_block) self.gpu_allocator.free(last_block)
return last_block.block_number, new_block.block_number return last_block.block_number, new_block.block_number
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment