Unverified Commit 4cea74c7 authored by ljss's avatar ljss Committed by GitHub
Browse files

Set top_p=0 and top_k=-1 in greedy sampling (#1748)

parent a921d8be
...@@ -147,6 +147,8 @@ class SamplingParams: ...@@ -147,6 +147,8 @@ class SamplingParams:
self._verify_non_beam_search() self._verify_non_beam_search()
if self.temperature < _SAMPLING_EPS: if self.temperature < _SAMPLING_EPS:
# Zero temperature means greedy sampling. # Zero temperature means greedy sampling.
self.top_p = 1.0
self.top_k = -1
self._verify_greedy_sampling() self._verify_greedy_sampling()
def _verify_args(self) -> None: def _verify_args(self) -> None:
...@@ -214,10 +216,6 @@ class SamplingParams: ...@@ -214,10 +216,6 @@ class SamplingParams:
if self.best_of > 1: if self.best_of > 1:
raise ValueError("best_of must be 1 when using greedy sampling." raise ValueError("best_of must be 1 when using greedy sampling."
f"Got {self.best_of}.") f"Got {self.best_of}.")
if self.top_p < 1.0 - _SAMPLING_EPS:
raise ValueError("top_p must be 1 when using greedy sampling.")
if self.top_k != -1:
raise ValueError("top_k must be -1 when using greedy sampling.")
@cached_property @cached_property
def sampling_type(self) -> SamplingType: def sampling_type(self) -> SamplingType:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment