Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
norm
vllm
Commits
3711811b
Unverified
Commit
3711811b
authored
Feb 08, 2024
by
Woosuk Kwon
Committed by
GitHub
Feb 08, 2024
Browse files
Disable custom all reduce by default (#2808)
parent
65b89d16
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
8 deletions
+18
-8
vllm/config.py
vllm/config.py
+18
-8
No files found.
vllm/config.py
View file @
3711811b
...
@@ -388,16 +388,26 @@ class ParallelConfig:
...
@@ -388,16 +388,26 @@ class ParallelConfig:
if
self
.
pipeline_parallel_size
>
1
:
if
self
.
pipeline_parallel_size
>
1
:
raise
NotImplementedError
(
raise
NotImplementedError
(
"Pipeline parallelism is not supported yet."
)
"Pipeline parallelism is not supported yet."
)
if
is_hip
():
if
not
self
.
disable_custom_all_reduce
and
self
.
world_size
>
1
:
if
is_hip
():
self
.
disable_custom_all_reduce
=
True
logger
.
info
(
"Disabled the custom all-reduce kernel because it is not "
"supported on AMD GPUs."
)
elif
self
.
pipeline_parallel_size
>
1
:
self
.
disable_custom_all_reduce
=
True
logger
.
info
(
"Disabled the custom all-reduce kernel because it is not "
"supported with pipeline parallelism."
)
# FIXME(woosuk): Fix the stability issues and re-enable the custom
# all-reduce kernel.
if
not
self
.
disable_custom_all_reduce
and
self
.
world_size
>
1
:
self
.
disable_custom_all_reduce
=
True
self
.
disable_custom_all_reduce
=
True
logger
.
info
(
logger
.
info
(
"Disabled the custom all-reduce kernel because it is not "
"Custom all-reduce kernels are temporarily disabled due to "
"supported on AMD GPUs."
)
"stability issues. We will re-enable them once the issues are "
elif
self
.
pipeline_parallel_size
>
1
:
"resolved."
)
self
.
disable_custom_all_reduce
=
True
logger
.
info
(
"Disabled the custom all-reduce kernel because it is not "
"supported with pipeline parallelism."
)
class
SchedulerConfig
:
class
SchedulerConfig
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment