Commit 5c37e69c authored by Shining Sun's avatar Shining Sun Committed by Toby Boyd
Browse files

Add usernames to TODOs (#6619)

parent 7772cb1d
...@@ -261,7 +261,7 @@ class DatasetManager(object): ...@@ -261,7 +261,7 @@ class DatasetManager(object):
file_pattern = os.path.join( file_pattern = os.path.join(
epoch_data_dir, rconst.SHARD_TEMPLATE.format("*")) epoch_data_dir, rconst.SHARD_TEMPLATE.format("*"))
# TODO: remove this contrib import # TODO(seemuch): remove this contrib import
# pylint: disable=line-too-long # pylint: disable=line-too-long
from tensorflow.contrib.tpu.python.tpu.datasets import StreamingFilesDataset from tensorflow.contrib.tpu.python.tpu.datasets import StreamingFilesDataset
# pylint: enable=line-too-long # pylint: enable=line-too-long
......
...@@ -72,7 +72,7 @@ def construct_estimator(model_dir, params): ...@@ -72,7 +72,7 @@ def construct_estimator(model_dir, params):
model_fn = neumf_model.neumf_model_fn model_fn = neumf_model.neumf_model_fn
if params["use_xla_for_gpu"]: if params["use_xla_for_gpu"]:
# TODO: remove the contrib imput # TODO(seemuch): remove the contrib imput
from tensorflow.contrib.compiler import xla from tensorflow.contrib.compiler import xla
logging.info("Using XLA for GPU for training and evaluation.") logging.info("Using XLA for GPU for training and evaluation.")
model_fn = xla.estimator_model_fn(model_fn) model_fn = xla.estimator_model_fn(model_fn)
......
...@@ -116,7 +116,7 @@ def neumf_model_fn(features, labels, mode, params): ...@@ -116,7 +116,7 @@ def neumf_model_fn(features, labels, mode, params):
beta2=params["beta2"], beta2=params["beta2"],
epsilon=params["epsilon"]) epsilon=params["epsilon"])
if params["use_tpu"]: if params["use_tpu"]:
# TODO: remove this contrib import # TODO(seemuch): remove this contrib import
optimizer = tf.contrib.tpu.CrossShardOptimizer(optimizer) optimizer = tf.contrib.tpu.CrossShardOptimizer(optimizer)
mlperf_helper.ncf_print(key=mlperf_helper.TAGS.MODEL_HP_LOSS_FN, mlperf_helper.ncf_print(key=mlperf_helper.TAGS.MODEL_HP_LOSS_FN,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment