GitLab

Found with performance-unnecessary-value-param
Signed-off-by: Rosen Penev <rosenp@gmail.com>

* partially fix clang compilation

Missing header and mistaken algorithm usage.

Also removed it name from range loops. It's not correct.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

* run through clang's -Wrange-loop-analysis

Some range loops should not use references as they need to copy.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

* manual range loop conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-return-braced-init-list
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with readability-inconsistent-declaration-parameter-name
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-use-bool-literals
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-raw-string-literal
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-use-emplace
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-loop-convert
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with readability-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>

* spelling: differently

* spelling: irrelevant

* spelling: specified

The BadFile exception which is thrown when failing to open a file now
contains the filename.

Fix invocation of clang-format in CMakeLists and apply clang-format.

Fix stack overflow in HandleNode by explicitly limiting the depth of recursion.

It's clearly related to an existing node, so it can have a mark and give
an error location.

The explicitly defaulted or implemented move constructors and assignment
operators are made "noexcept".

Bugfix:
* src/stream.cpp Stream::Stream() char_traits::int_type intro[4] is
  now aggregate-initialized (to zero) to avoid UB.

Minor changes:
* Using std::isinf() and std::signbit() instead of comparing for
  equality with infinity.
* src/streamcharsource.h: Added #include "stream.h".
* src/stream.h: Forward declaring "class StreamCharSource".
* Some implicit casting changed into static_cast's.
Signed-off-by: Ted Lyngmo <ted@lyncon.se>

This is in preparation for other patches that will make use of the
macro. The patch also removes #undef:ing the macro after its been
used to not make the header inclusion order critical. Otherwise,
the new header would always have to be the last of the yaml-cpp
headers to be included.

E.g. `!2`.

Also add a test for a parser with no data

Also run clang-format on these files as requested

Invalid access via operator[] or as<> will now print the offending key, if possible.

For example:

a:
  x: 1
  y: 2

node["a"]["z"].as<int>()

will say that the key "z" was invalid.

* Add compilation flags: -Wshadow -Weffc++ -pedantic -pedantic-errors
* Delete implicit copy & move constructors & assignment operators
  in classes with pointer data members.
* An exception to the above: Add default copy & move constructors &
  assignment operators for the Binary class.
* Convert boolean RegEx operators to binary operators.
* Initialize all members in all classes in ctors.
* Let default ctor delegate to the converting ctor in
  Binary and RegEx
* Don't change any tests except regex_test (as a result of the change
  to binary operators).

Note: https://bugzilla.redhat.com/show_bug.cgi?id=1544675 makes
-Weffc++ report a false positive in "include/yaml-cpp/node/impl.h".

ref #110

The issue is that numbers like
2.01 or 3.01 can not be precisely represented with binary floating point
numbers.

This replaces all occurrences of 'std::numeric_limits<T>::digits10 + 1' with
'std::numeric_limits<T>::max_digits10'.

Background:
Using 'std::numeric_limits<T>::digits10 + 1' is not precise enough.
Converting a 'float' into a 'string' and back to a 'float' will not always
produce the original 'float' value. To guarantee that the 'string'
representation has sufficient precision the value
'std::numeric_limits<T>::max_digits10' has to be used.

* Removed an expression which is always true
* The second expression (ch is space) is removed because the first one contains space 0x20
* nextEmptyLine is always false so it is removed from the expression

* fix up static, so works as DLL

* Skip newlines in binary decoding
This fixes #387

* Skip all whitespace characters

This also removes spaces and tabs in addition to newlines.