• Ted Lyngmo's avatar
    Apply formatting/style tweaks to comply with compile time diagnostics for g++ and clang++ (#686) · 0d5c5715
    Ted Lyngmo authored
    * Add compilation flags: -Wshadow -Weffc++ -pedantic -pedantic-errors
    * Delete implicit copy & move constructors & assignment operators
      in classes with pointer data members.
    * An exception to the above: Add default copy & move constructors &
      assignment operators for the Binary class.
    * Convert boolean RegEx operators to binary operators.
    * Initialize all members in all classes in ctors.
    * Let default ctor delegate to the converting ctor in
      Binary and RegEx
    * Don't change any tests except regex_test (as a result of the change
      to binary operators).
    
    Note: https://bugzilla.redhat.com/show_bug.cgi?id=1544675 makes
    -Weffc++ report a false positive in "include/yaml-cpp/node/impl.h".
    0d5c5715
node_data.cpp 6.96 KB