Don't strip debug symbols in debug mode (#669)

d361ea15 · Dean Moldovan · Wenzel Jakob · d5ce82b6 · d361ea15
Commit d361ea15 authored Feb 14, 2017 by Dean Moldovan Committed by Wenzel Jakob Feb 14, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

tools/pybind11Tools.cmake tools/pybind11Tools.cmake +2 -2

No files found.
--- a/tools/pybind11Tools.cmake
+++ b/tools/pybind11Tools.cmake
@@ -173,8 +173,8 @@ function(pybind11_add_module target_name)

  _pybind11_add_lto_flags(${target_name} ${ARG_THIN_LTO})

-  # Set the default symbol visibility to hidden (very important to obtain small binaries)
-  if (NOT MSVC)
+  if (NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug)
+    # Set the default symbol visibility to hidden (very important to obtain small binaries)
    target_compile_options(${target_name} PRIVATE "-fvisibility=hidden")

    # Strip unnecessary sections of the binary on Linux/Mac OS