fix: func_handle for rule of two (#3169)

* Fix func_handle for rule of two * Apply reviewer suggestion

fix: func_handle for rule of two (#3169)
* Fix func_handle for rule of two * Apply reviewer suggestion
9f204a18 · Aaron Gokaslan · Henry Schreiner · ada6b791 · 9f204a18
Commit 9f204a18 authored Aug 03, 2021 by Aaron Gokaslan Committed by Henry Schreiner Aug 03, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

include/pybind11/functional.h include/pybind11/functional.h +3 -1

No files found.
--- a/include/pybind11/functional.h
+++ b/include/pybind11/functional.h
@@ -70,9 +70,11 @@ public:
        struct func_handle {
            function f;
            func_handle(function &&f_) noexcept : f(std::move(f_)) {}
-            func_handle(const func_handle& f_) {
+            func_handle(const func_handle &f_) { operator=(f_); }
+            func_handle &operator=(const func_handle &f_) {
                gil_scoped_acquire acq;
                f = f_.f;
+                return *this;
            }
            ~func_handle() {
                gil_scoped_acquire acq;