fix(cmake): use case-insensitive CMAKE_BUILD_TYPE comparisons (#4078)

8a4bca82 · Daniel Dinu · GitHub · 29f4940c · 8a4bca82 · 8a4bca82
Unverified Commit 8a4bca82 authored Aug 08, 2022 by Daniel Dinu Committed by GitHub Aug 08, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

tools/pybind11NewTools.cmake tools/pybind11NewTools.cmake +3 -1

tools/pybind11Tools.cmake tools/pybind11Tools.cmake +3 -1

No files found.
--- a/tools/pybind11NewTools.cmake
+++ b/tools/pybind11NewTools.cmake
@@ -233,7 +233,9 @@ function(pybind11_add_module target_name)
    endif()
  endif()
-  if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
+  # Use case-insensitive comparison to match the result of $<CONFIG:cfgs>
+  string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
+  if(NOT MSVC AND NOT ${uppercase_CMAKE_BUILD_TYPE} MATCHES DEBUG|RELWITHDEBINFO)
    # Strip unnecessary sections of the binary on Linux/macOS
    pybind11_strip(${target_name})
  endif()

--- a/tools/pybind11Tools.cmake
+++ b/tools/pybind11Tools.cmake
@@ -208,7 +208,9 @@ function(pybind11_add_module target_name)
    endif()
  endif()
-  if(NOT MSVC AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
+  # Use case-insensitive comparison to match the result of $<CONFIG:cfgs>
+  string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
+  if(NOT MSVC AND NOT ${uppercase_CMAKE_BUILD_TYPE} MATCHES DEBUG|RELWITHDEBINFO)
    pybind11_strip(${target_name})
  endif()