chore: Optimize iterator advance() call (#4237)

8781daf6 · Aaron Gokaslan · GitHub · 0927c4d1 · 8781daf6
Unverified Commit 8781daf6 authored Oct 12, 2022 by Aaron Gokaslan Committed by GitHub Oct 12, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

include/pybind11/pytypes.h include/pybind11/pytypes.h +1 -1

No files found.
--- a/include/pybind11/pytypes.h
+++ b/include/pybind11/pytypes.h
@@ -1382,7 +1382,7 @@ public:
 private:
    void advance() {
        value = reinterpret_steal<object>(PyIter_Next(m_ptr));
-        if (PyErr_Occurred()) {
+        if (value.ptr() == nullptr && PyErr_Occurred()) {
            throw error_already_set();
        }
    }