Fix Py_buffer leak on GetBuffer failure

Fixes #852.

Fix Py_buffer leak on GetBuffer failure
Fixes #852.
731a9f6c · Jason Rhinelander · 4567f1f8 · 731a9f6c
Commit 731a9f6c authored May 16, 2017 by Jason Rhinelander
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

include/pybind11/pytypes.h include/pybind11/pytypes.h +3 -1

No files found.
--- a/include/pybind11/pytypes.h
+++ b/include/pybind11/pytypes.h
@@ -1155,8 +1155,10 @@ public:
        int flags = PyBUF_STRIDES | PyBUF_FORMAT;
        if (writable) flags |= PyBUF_WRITABLE;
        Py_buffer *view = new Py_buffer();
-        if (PyObject_GetBuffer(m_ptr, view, flags) != 0)
+        if (PyObject_GetBuffer(m_ptr, view, flags) != 0) {
+            delete view;
            throw error_already_set();
+        }
        return buffer_info(view);
    }
 };