Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
gaoqiong
pybind11
Commits
649eb91f
Commit
649eb91f
authored
Jan 13, 2021
by
Ralf W. Grosse-Kunstleve
Browse files
Adding comment re potential use_count data race.
parent
6294eb26
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
0 deletions
+4
-0
include/pybind11/smart_holder_poc.h
include/pybind11/smart_holder_poc.h
+4
-0
No files found.
include/pybind11/smart_holder_poc.h
View file @
649eb91f
...
...
@@ -131,6 +131,10 @@ struct smart_holder {
throw
std
::
runtime_error
(
std
::
string
(
"Cannot disown nullptr ("
)
+
context
+
")."
);
}
if
(
vptr
.
use_count
()
!=
1
)
{
// In multithreaded environments accessing use_count is racy,
// but in the context of Python it is a bug (elsewhere) if the
// Global Interpreter Lock (GIL) is not being held when this code
// is reached.
throw
std
::
runtime_error
(
std
::
string
(
"Cannot disown use_count != 1 ("
)
+
context
+
")."
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment