Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
gaoqiong
pybind11
Commits
49c389b7
Unverified
Commit
49c389b7
authored
Oct 08, 2020
by
Henry Schreiner
Committed by
GitHub
Oct 08, 2020
Browse files
ci: test on Windows 3.8 and 3.9 (mostly) (#2560)
* ci: skip cpptest on Win Py 3.8+ * docs: minor typo caught by @rwgk
parent
b6f37f67
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
9 deletions
+5
-9
.github/workflows/ci.yml
.github/workflows/ci.yml
+4
-8
docs/upgrade.rst
docs/upgrade.rst
+1
-1
No files found.
.github/workflows/ci.yml
View file @
49c389b7
...
@@ -70,14 +70,6 @@ jobs:
...
@@ -70,14 +70,6 @@ jobs:
python
:
pypy3
python
:
pypy3
arch
:
x64
arch
:
x64
# Currently broken on embed_test
-
runs-on
:
windows-latest
python
:
3.8
arch
:
x64
-
runs-on
:
windows-latest
python
:
3.9
arch
:
x64
name
:
"
🐍
${{
matrix.python
}}
•
${{
matrix.runs-on
}}
•
${{
matrix.arch
}}
${{
matrix.args
}}"
name
:
"
🐍
${{
matrix.python
}}
•
${{
matrix.runs-on
}}
•
${{
matrix.arch
}}
${{
matrix.args
}}"
runs-on
:
${{ matrix.runs-on }}
runs-on
:
${{ matrix.runs-on }}
...
@@ -132,6 +124,8 @@ jobs:
...
@@ -132,6 +124,8 @@ jobs:
run
:
cmake --build . --target pytest -j
2
run
:
cmake --build . --target pytest -j
2
-
name
:
C++11 tests
-
name
:
C++11 tests
# TODO: Figure out how to load the DLL on Python 3.8+
if
:
"
!(runner.os
==
'Windows'
&&
(matrix.python
==
3.8
||
matrix.python
==
3.9))"
run
:
cmake --build . --target cpptest -j
2
run
:
cmake --build . --target cpptest -j
2
-
name
:
Interface test C++11
-
name
:
Interface test C++11
...
@@ -158,6 +152,8 @@ jobs:
...
@@ -158,6 +152,8 @@ jobs:
run
:
cmake --build build2 --target pytest
run
:
cmake --build build2 --target pytest
-
name
:
C++ tests
-
name
:
C++ tests
# TODO: Figure out how to load the DLL on Python 3.8+
if
:
"
!(runner.os
==
'Windows'
&&
(matrix.python
==
3.8
||
matrix.python
==
3.9))"
run
:
cmake --build build2 --target cpptest
run
:
cmake --build build2 --target cpptest
-
name
:
Interface test
-
name
:
Interface test
...
...
docs/upgrade.rst
View file @
49c389b7
...
@@ -90,7 +90,7 @@ In addition, the following changes may be of interest:
...
@@ -90,7 +90,7 @@ In addition, the following changes may be of interest:
pybind11 will cause pybind11 to use the new Python mechanisms instead of its
pybind11 will cause pybind11 to use the new Python mechanisms instead of its
own custom search, based on a patched version of classic ``FindPythonInterp``
own custom search, based on a patched version of classic ``FindPythonInterp``
/ ``FindPythonLibs``. In the future, this may become the default. A recent
/ ``FindPythonLibs``. In the future, this may become the default. A recent
(3.15+ or 3.18.2+) version of CMake recommended.
(3.15+ or 3.18.2+) version of CMake
is
recommended.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment