"testing/python/vscode:/vscode.git/clone" did not exist on "49d5d80eb6895386565ab960a8e10351c12419cf"
Commit 3f8da236 authored by Ralf W. Grosse-Kunstleve's avatar Ralf W. Grosse-Kunstleve
Browse files

Commenting out const in def_buffer(... const). With this, test_buffers builds...

Commenting out const in def_buffer(... const). With this, test_buffers builds and runs with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. Explanation why the const needs to be removed, or fix elsewhere, is still needed, but left for later.
parent 07dab2ea
...@@ -1410,7 +1410,8 @@ public: ...@@ -1410,7 +1410,8 @@ public:
template <typename Return, typename Class, typename... Args> template <typename Return, typename Class, typename... Args>
class_ &def_buffer(Return (Class::*func)(Args...) const) { class_ &def_buffer(Return (Class::*func)(Args...) const) {
return def_buffer([func] (const type &obj) { return (obj.*func)(); }); // NEEDED: Explanation why the const needs to be removed, or fix elsewhere.
return def_buffer([func] (/*const*/ type &obj) { return (obj.*func)(); });
} }
template <typename C, typename D, typename... Extra> template <typename C, typename D, typename... Extra>
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment