Skip to content

GitLab

Commit 329d9833 authored by Dean Moldovan's avatar Dean Moldovan Committed by Wenzel Jakob
Browse files

Revert "Template array constructor (#582)" 

This reverts commit bee8827a.
parent 11a337f1
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
include/pybind11/numpy.h
View file @ 329d9833
......@@ -337,9 +337,8 @@ public:
array() : array(0, static_cast<const double *>(nullptr)) {}
template <typename Shape, typename Strides>
array(const pybind11::dtype &dt, const Shape &shape,
const Strides &strides, const void *ptr = nullptr,
array(const pybind11::dtype &dt, const std::vector<size_t> &shape,
const std::vector<size_t> &strides, const void *ptr = nullptr,
handle base = handle()) {
auto& api = detail::npy_api::get();
auto ndim = shape.size();
......@@ -537,7 +536,7 @@ protected:
throw std::runtime_error("array is not writeable");
}
template <typename Shape> static std::vector<size_t> default_strides(const Shape& shape, size_t itemsize) {
static std::vector<size_t> default_strides(const std::vector<size_t>& shape, size_t itemsize) {
auto ndim = shape.size();
std::vector<size_t> strides(ndim);
if (ndim) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment